This is a list of all comments for HD-DEN-12845-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/SyringePump.c
Revision Comment by Sean Nash on 25 May 2022, 09:22 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13073

  Space before final parenthesis.

  Reply by Dara Navaei on 13 June 2022, 09:26
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by Sean Nash on 25 May 2022, 09:20 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13070

  Rather than UI sending this message to f/w so f/w can send
  event message back to UI to log it, maybe UI can just log it
  itself?

  Reply by Dara Navaei on 14 June 2022, 09:49
  > Removed the message.

    Reply by Sean Nash on 14 June 2022, 10:59
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 25 May 2022, 09:19 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13069

  Remove blank line.

  Reply by Dara Navaei on 13 June 2022, 09:30
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:14
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Switches.c
Revision Comment by Sean Nash on 25 May 2022, 09:23 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13074

  Spaces between parenthesis and condition.

  Reply by Dara Navaei on 13 June 2022, 09:24
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by Sean Nash on 25 May 2022, 09:21 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13072

  Remove blank line.

  Reply by Dara Navaei on 13 June 2022, 09:27
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by Sean Nash on 25 May 2022, 09:21 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13071

  Should log volume level before and after.

  Reply by Dara Navaei on 13 June 2022, 09:28
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:14
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Sean Nash on 25 May 2022, 09:24 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13075

  Too many parenthesis in first part of condition I think.

  Reply by Dara Navaei on 13 June 2022, 09:23
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:10
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Michael Garthwaite on 13 June 2022, 15:26 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13136

  Im assuming that this if statement covers sub modes like Saline
  and Blood Prime. How do we know during blood prime,
  specifically, that we would not be dealing with an edge case in
  treatment parameters for the patient (Ex: -300 mmHg to -270
  mmHg) and triggering a false positive alarm?
  
  Note: I dont know actual patient bp values but these are
  currently acceptable treatment parameters for arterial pressure
  limits.

  Reply by Sean Nash on 13 June 2022, 17:50
  > We got recommendation to monitor arterial pressure even when
  > not dialyzing if patient is still connected (so all other
  > treatment mode states other than dialysis when not delivering
  > saline bolus), but didn't want to apply the user provided
  > limits - just want to monitor for max pressure situation.

    Reply by Michael Garthwaite on 14 June 2022, 11:09
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 25 May 2022, 09:24 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13076

  Too many parenthesis in first part of condition I think.

  Reply by Dara Navaei on 13 June 2022, 09:22
  > Done.

    Reply by Sean Nash on 13 June 2022, 11:10
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 25 May 2022, 09:25 
https://devapps.diality.us/cru/HD-DEN-12845-2#c13077

  I don't think we need to broadcast usage data regularly (like
  every second), but may want to send it once in a while to get
  logged - maybe when we transition to treatment mode to start a
  new treatment.

  Reply by Dara Navaei on 13 June 2022, 09:20
  > It is not broadcast all the time. It is sent per request.

    Reply by Sean Nash on 13 June 2022, 11:08
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-12845-2 https://devapps.diality.us/cru/HD-DEN-12845-2

Title: HD-DEN-12845_SW Dev Sprint S71 Steve
Statement of Objectives:


State: Closed

Summary: 

Author: Steve Jarpe
Moderator: Steve Jarpe
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei
     Darren Cox