This is a list of all comments for HD-DEN-13154-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/SyringePump.c
Revision Comment by Michael Garthwaite on 07 March 2023, 16:32 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16611

  Should we check for stall in bolus & continuous states?

  Reply by Sean Nash on 08 March 2023, 09:35
  > Concern was originally just for retract due to highest speed.
  > We ended up reducing retract speed to reduce likelihood of
  > stalls.  Still a good idea to check for it though and since
  > retract, preload and seek all share same relatively high
  > speed, these are the ops that have the check.  For bolus and
  > continuous, should not stall at these speeds and would catch
  > with rate alarm if it did.

    Reply by Michael Garthwaite on 08 March 2023, 09:47
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by Michael Garthwaite on 01 March 2023, 16:04 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16557

  This will hard fault the HD. Please change to
  getTreatmentParameterU32()

  Reply by Sean Nash on 06 March 2023, 11:37
  > Fixed.

    Reply by Michael Garthwaite on 07 March 2023, 16:34
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Michael Garthwaite on 07 March 2023, 16:25 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16609

  Shouldnt this be set to 0U instead of 0.0F?

  Reply by Sean Nash on 08 March 2023, 09:41
  > Fixed.

    Reply by Michael Garthwaite on 08 March 2023, 09:47
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.h
Revision Comment by Michael Garthwaite on 07 March 2023, 16:24 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16608

  This should be U32.

  Reply by Sean Nash on 08 March 2023, 09:33
  > Fixed.

    Reply by Michael Garthwaite on 08 March 2023, 09:47
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialInFlow.c
Revision Comment by Michael Garthwaite on 01 March 2023, 16:04 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16558

  This will hard fault the HD. Please change to
  getTreatmentParameterU32()

  Reply by Sean Nash on 06 March 2023, 11:36
  > Fixed.

    Reply by Michael Garthwaite on 07 March 2023, 16:33
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Michael Garthwaite on 07 March 2023, 16:34 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16614

  Shouldnt this be set to 0U instead of 0.0F?

  Reply by Sean Nash on 08 March 2023, 09:30
  > Fixed.

    Reply by Michael Garthwaite on 08 March 2023, 09:46
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialInFlow.h
Revision Comment by Michael Garthwaite on 07 March 2023, 16:35 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16616

  This should be U32.

  Reply by Sean Nash on 08 March 2023, 09:32
  > Fixed.

    Reply by Michael Garthwaite on 08 March 2023, 09:47
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DGInterface.c
Revision Comment by Michael Garthwaite on 07 March 2023, 16:26 
https://devapps.diality.us/cru/HD-DEN-13154-1#c16610

  seems odd to create a variable just for it to be returned. Is
  this value supposed to be overridable?

  Reply by Sean Nash on 08 March 2023, 09:40
  > Variable is also updated by receipts of DG flow broadcasts.
  > I believe it is overridable on DG side.

    Reply by Michael Garthwaite on 08 March 2023, 09:48
    > RESOLVED IN CODE WALKTHROUGH.


---

ID: HD-DEN-13154-1 https://devapps.diality.us/cru/HD-DEN-13154-1

Title: HD-DEN-13154_Heparin Syringe Empty Position Incorrect
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (4 active, 2 completed*)
     Michael Garthwaite   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe