This is a list of all comments for HD-DEN-13903-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by wbracken on 28 September 2022, 11:09 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14020

  Is adcDialInPumpMCCurrentmA an output?

  Reply by Michael Garthwaite on 12 October 2022, 15:45
  > Fixed. Thanks!

    Reply by wbracken on 12 October 2022, 16:08
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialInFlow.c
Revision Comment by wbracken on 23 September 2022, 14:55 
https://devapps.diality.us/cru/HD-DEN-13903-1#c13951

  Need F.  Magic numbers should be #define?

  Reply by Michael Garthwaite on 12 October 2022, 10:05
  > Fixed. Thanks!

    Reply by wbracken on 12 October 2022, 16:09
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 October 2022, 08:30 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14178

  Remove param.

  Reply by Sean Nash on 12 October 2022, 16:03
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 October 2022, 08:29 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14177

  Add space before last ")"

  Reply by Michael Garthwaite on 12 October 2022, 09:33
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 16:02
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by wbracken on 23 September 2022, 14:56 
https://devapps.diality.us/cru/HD-DEN-13903-1#c13952

  Need F.  Magic numbers need #defines?

  Reply by Michael Garthwaite on 12 October 2022, 10:05
  > Fixed. Thanks!

    Reply by wbracken on 12 October 2022, 16:08
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by wbracken on 28 September 2022, 11:10 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14021

  Is adcDialInPumpMCCurrentmA and output?

  Reply by Michael Garthwaite on 12 October 2022, 10:05
  > Fixed. Thanks!

    Reply by wbracken on 12 October 2022, 16:08
    > RESOLVED IN CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by wbracken on 28 September 2022, 11:15 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14022

  Remove blank line.

  Reply by Michael Garthwaite on 12 October 2022, 10:05
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 16:03
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 12 October 2022, 08:40 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14182

  Remove extra blank line.

  Reply by Michael Garthwaite on 12 October 2022, 09:32
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 16:04
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/Dialysis.c
Revision Comment by Sean Nash on 12 October 2022, 08:37 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14179

  Remove last param.

  Reply by Michael Garthwaite on 12 October 2022, 09:34
  > Fixed. Thanks!

    Reply by Sean Nash on 12 October 2022, 16:02
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeFault.c
Revision Comment by Sean Nash on 12 October 2022, 08:37 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14180

  Remove last param.

  Reply by Michael Garthwaite on 12 October 2022, 09:07
  > This whole block of code ( lines 127 - 178 ) was removed in
  > when staging was merged in and not reflected on crucible.

    Reply by Sean Nash on 12 October 2022, 16:04
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 12 October 2022, 08:38 
https://devapps.diality.us/cru/HD-DEN-13903-1#c14181

  Remove last param.

  Reply by Michael Garthwaite on 12 October 2022, 08:59
  > This whole block of code ( lines 248 - 304 ) was removed in
  > when staging was merged in and not reflected on crucible.

    Reply by Sean Nash on 12 October 2022, 16:04
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-13903-1 https://devapps.diality.us/cru/HD-DEN-13903-1

Title: HD-DEN-13903_S80 MG Dial 204
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox