This is a list of all comments for HD-DEN-14328-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Prime.c
Revision Comment by Sean Nash on 19 January 2023, 13:14 
https://devapps.diality.us/cru/HD-DEN-14328-1#c16154

  Add blank line between declaration and code.

  Reply by Michael Garthwaite on 19 January 2023, 13:25
  > Fixed. Thanks!

    Reply by Sean Nash on 19 January 2023, 13:50
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/Rinseback.c
Revision Comment by Sean Nash on 19 January 2023, 13:15 
https://devapps.diality.us/cru/HD-DEN-14328-1#c16155

  Put this (and blank line after) at top of function.

  Reply by Michael Garthwaite on 19 January 2023, 13:25
  > Fixed. Thanks!

    Reply by Sean Nash on 19 January 2023, 13:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/TreatmentEnd.c
Revision Comment by Sean Nash on 19 January 2023, 13:15 
https://devapps.diality.us/cru/HD-DEN-14328-1#c16156

  Put this (and blank line after) at top of function.

  Reply by Michael Garthwaite on 19 January 2023, 13:25
  > Fixed. Thanks!

    Reply by Sean Nash on 19 January 2023, 13:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/TreatmentRecirc.c
Revision Comment by Sean Nash on 19 January 2023, 13:16 
https://devapps.diality.us/cru/HD-DEN-14328-1#c16157

  Put this (and blank line after) at top of function.

  Reply by Michael Garthwaite on 19 January 2023, 13:25
  > Fixed. Thanks!

    Reply by Sean Nash on 19 January 2023, 13:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/TreatmentStop.c
Revision Comment by Sean Nash on 19 January 2023, 13:16 
https://devapps.diality.us/cru/HD-DEN-14328-1#c16158

  Add blank line between declaration and code.

  Reply by Michael Garthwaite on 19 January 2023, 13:25
  > Fixed. Thanks!

    Reply by Sean Nash on 19 January 2023, 13:48
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14328-1 https://devapps.diality.us/cru/HD-DEN-14328-1

Title: HD-DEN-14328_HD Event Issues
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     wbracken
     Darren Cox
     jtaylor
     Steve Jarpe