This is a list of all comments for HD-DEN-14458-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by wbracken on 12 December 2022, 10:28 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15184

  Delete extra line.

  Reply by Dara Navaei on 14 December 2022, 11:42
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 December 2022, 09:27 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15198

  Should be absolute value (in case measMotorSpeedInRotorRPM is
  negative for reverse direction).

  Reply by Dara Navaei on 14 December 2022, 11:42
  > Done.

    Reply by Sean Nash on 14 December 2022, 11:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialInFlow.c
Revision Comment by Sean Nash on 14 December 2022, 09:28 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15199

  Should be absolute value (in case measMotorSpeedInRotorRPM is
  negative for reverse direction).

  Reply by Dara Navaei on 14 December 2022, 11:41
  > Done.

    Reply by Sean Nash on 14 December 2022, 11:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by wbracken on 12 December 2022, 10:29 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15185

  Remove blank line.

  Reply by Dara Navaei on 14 December 2022, 11:42
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 December 2022, 09:29 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15200

  Should be absolute value (in case measMotorSpeedInRotorRPM is
  negative for reverse direction).

  Reply by Dara Navaei on 14 December 2022, 11:40
  > Done.

    Reply by Sean Nash on 14 December 2022, 11:49
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/SelfTests.c
Revision Comment by wbracken on 08 December 2022, 14:54 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15177

  Update function header.

  Reply by Dara Navaei on 14 December 2022, 11:37
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:21
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 08 December 2022, 14:56 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15178

  Remove comment and bracket

  Reply by Dara Navaei on 14 December 2022, 11:46
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:17
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 08 December 2022, 14:56 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15179

  Remove comments.

  Reply by Dara Navaei on 14 December 2022, 11:46
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:16
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 08 December 2022, 14:58 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15180

  Remove code.

  Reply by Dara Navaei on 14 December 2022, 11:46
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:15
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 08 December 2022, 14:58 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15181

  Remove commented lines.

  Reply by Dara Navaei on 14 December 2022, 11:45
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:15
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 08 December 2022, 14:59 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15182

  Update function header.

  Reply by Dara Navaei on 14 December 2022, 11:45
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:15
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 08 December 2022, 15:01 
https://devapps.diality.us/cru/HD-DEN-14458-1#c15183

  Remove comment and brackets.

  Reply by Dara Navaei on 14 December 2022, 11:43
  > Done.

    Reply by Sean Nash on 14 December 2022, 13:14
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14458-1 https://devapps.diality.us/cru/HD-DEN-14458-1

Title: HD-DEN-14458_Reservoirs Don T Drain When Treatment IS Ended From Pre Treatment 
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 1 completed*)
     Sean Nash   (*)
     Michael Garthwaite
     wbracken
     Darren Cox
     jtaylor