This is a list of all comments for HD-DEN-14980-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by Sean Nash on 21 April 2023, 13:30 
https://devapps.diality.us/cru/HD-DEN-14980-1#c17191

  Comment doesn't seem to match how timer is used (to decide
  whether to block alarm trigger).

  Reply by jtaylor on 21 April 2023, 15:01
  > Comment corrected.

    Reply by Sean Nash on 24 April 2023, 09:41
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 20 April 2023, 11:25 
https://devapps.diality.us/cru/HD-DEN-14980-1#c17170

  Add alarmStatus to header

  Reply by jtaylor on 21 April 2023, 08:18
  > Done.

    Reply by wbracken on 21 April 2023, 10:23
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 21 April 2023, 13:40 
https://devapps.diality.us/cru/HD-DEN-14980-1#c17192

  This should probably be up top before the outer if (i.e.
  checked every time) as there is no dependency on the given
  alarm ID.

  Reply by jtaylor on 21 April 2023, 15:02
  > Alarm checks re-ordered.

    Reply by Sean Nash on 24 April 2023, 09:40
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 24 April 2023, 09:39 
https://devapps.diality.us/cru/HD-DEN-14980-1#c17208

  This if should be the outermost if (before the if above) so
  that the else with the s/w fault aligns with it.

  Reply by jtaylor on 24 April 2023, 12:25
  > Thank you - corrected.

    Reply by Sean Nash on 24 April 2023, 13:55
    > Was expecting you to move if, not else.
    > Doesn't make sense to check alarm (line 359..361) before
    > validating alarm (line 364).

      Reply by jtaylor on 24 April 2023, 15:19
      > Done.

        Reply by Sean Nash on 24 April 2023, 17:13
        > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmt.h
Revision Comment by Sean Nash on 21 April 2023, 11:42 
https://devapps.diality.us/cru/HD-DEN-14980-1#c17189

  Not needed.  Remove.

  Reply by jtaylor on 21 April 2023, 12:10
  > AlarmMgmt.h reverted. The timer moved to static AlarmMgnt
  > local.

    Reply by Sean Nash on 21 April 2023, 13:42
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14980-1 https://devapps.diality.us/cru/HD-DEN-14980-1

Title: HD-DEN-14980_Unable TO Resume After HD Unit Plugged Back IN Pre Treatment After Priming
Statement of Objectives:


State: Closed

Summary: 

Author: jtaylor
Moderator: jtaylor
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Dara Navaei
     dcox
     Steve Jarpe