This is a list of all comments for HD-DEN-15024-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/SyringePump.c Revision Comment by Sean Nash on 26 April 2023, 18:40 https://devapps.diality.us/cru/HD-DEN-15024-1#c17279 This appears to be causing problems 1) at startup and 2) after fast operations (e.g. retract, preload, seek). For #1, not sure what's happening at startup, but apparently the position reported by FPGA is not stable for a little while after startup. Probably need to exempt first second (previous 1sec persistence seemed to work fine) after powerup to prevent false alarms. For #2, I think it just takes a little while for pump to actually come to full stop after pump was running fast. The syringe pump monitor and controller are running in priority task at 100 Hz, so a count of 5 is only 50 ms. Need to play around with this count to see how much time is needed to come to complete stop and then set count to something north of that time (at 10ms per count) for margin. Reply by Darren Cox on 27 April 2023, 16:37 > Changed to 10 along with the max windowed timer count. > DVT-005 was failing with a count of 5-7. It is passing now > with max of 10. Reply by Sean Nash on 01 May 2023, 11:45 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-15024-1 https://devapps.diality.us/cru/HD-DEN-15024-1 Title: HD-DEN-15024_FW Srshd 1333 Vtchd 283 Alarm ID HD Syringe Pump Not Stopped Error ID 111 Does Not Statement of Objectives: State: Closed Summary: Author: Darren Cox Moderator: Darren Cox Reviewers: (5 active, 1 completed*) Sean Nash (*) Michael Garthwaite wbracken Dara Navaei jtaylor Steve Jarpe