This is a list of all comments for HD-DEN-15199-1.

Review Summary: No summary


----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 02 May 2023, 16:52 
https://devapps.diality.us/cru/HD-DEN-15199-1#c17307

  Remove extra blank line.

  Reply by Dara Navaei on 04 May 2023, 10:35
  > Done

    Reply by Sean Nash on 08 May 2023, 08:48
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: TestSupport.h
Revision Comment by Sean Nash on 08 May 2023, 08:52 
https://devapps.diality.us/cru/HD-DEN-15199-1#c17338

  Recommend being more direct in naming:
  TEST_CONFIG_USE_WET_CARTRIDGE
  TEST_CONFIG_USE_WORN_CARTRIDGE

  Reply by Dara Navaei on 08 May 2023, 15:58
  > This was updated but not pushed.

    Reply by Sean Nash on 09 May 2023, 08:21
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/SelfTests.c
Revision Comment by Sean Nash on 08 May 2023, 09:01 
https://devapps.diality.us/cru/HD-DEN-15199-1#c17340

  I don't think a worn cartridge should fail here (should still
  be dry).  I think only wet cartridge should be checked here.

  Reply by Dara Navaei on 09 May 2023, 09:38
  > Done

    Reply by Sean Nash on 09 May 2023, 10:39
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 08 May 2023, 09:03 
https://devapps.diality.us/cru/HD-DEN-15199-1#c17341

  Why isn't this just an else?  And if else should be swapped so
  normal action (alarm) comes first with if and the else should
  be the exception (else).

  Reply by Dara Navaei on 09 May 2023, 09:40
  > Done

    Reply by Sean Nash on 09 May 2023, 10:40
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 May 2023, 17:06 
https://devapps.diality.us/cru/HD-DEN-15199-1#c17308

  Let's discuss how test config is being used in this case.  It
  seems like it's all over the place to me.

  Reply by Dara Navaei on 04 May 2023, 10:39
  > Please see changes.

    Reply by Sean Nash on 08 May 2023, 08:58
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 08 May 2023, 09:06 
https://devapps.diality.us/cru/HD-DEN-15199-1#c17342

  Is this needed?  Why would a worn cartridge fail pressure test?

  Reply by Dara Navaei on 08 May 2023, 15:55
  > This was a mistake. I fixed it.

    Reply by Sean Nash on 09 May 2023, 08:25
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15199-1 https://devapps.diality.us/cru/HD-DEN-15199-1

Title: HD-DEN-15199_FW DN Sprint 95 Part 2
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox
     jtaylor
     Steve Jarpe