This is a list of all comments for HD-DEN-15274-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by wbracken on 11 May 2023, 16:37 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17363

  Add comment

  Reply by Dara Navaei on 14 May 2023, 12:40
  > Done

    Reply by wbracken on 14 May 2023, 15:43
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 12 May 2023, 09:43 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17377

  Put this prototype declaration last w/ blank line before.

  Reply by Dara Navaei on 15 May 2023, 20:14
  > Done

    Reply by Sean Nash on 16 May 2023, 09:17
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 09:47 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17378

  Comment for what we're doing here.

  Reply by Dara Navaei on 14 May 2023, 12:40
  > Done

    Reply by Sean Nash on 14 May 2023, 16:53
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 09:49 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17379

  Update inputs

  Reply by Dara Navaei on 14 May 2023, 12:39
  > Done

    Reply by Sean Nash on 14 May 2023, 16:55
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 10:07 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17386

  I think this whole function should be moved down into test
  support functions section.

  Reply by Dara Navaei on 14 May 2023, 12:27
  > Done

    Reply by Sean Nash on 14 May 2023, 16:55
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 10:02 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17384

  case body should be indented.

  Reply by Dara Navaei on 14 May 2023, 12:28
  > Done. This indentation was picked by Code Composer Studios
  > though.

    Reply by Sean Nash on 14 May 2023, 16:56
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 17 May 2023, 10:22 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17633

  Add patientConnectionConfirm and doorOpened to header.

  Reply by Dara Navaei on 17 May 2023, 11:24
  > Done

    Reply by Dara Navaei on 19 October 2023, 09:04
    > RESOLVED in CODE WALKTHROUGH

Revision Comment by Sean Nash on 12 May 2023, 09:55 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17380

  FULL volume is 1500.  Unlikely to be less than 1500 as fills
  tend to overshoot a little (they don't stop until at least
  1500).  Add new #define for a max start value - maybe 1575 and
  use that instead.

  Reply by Dara Navaei on 14 May 2023, 12:32
  > Done

    Reply by Sean Nash on 14 May 2023, 16:56
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 09:59 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17382

  If res 1 is active, you will not set rsrvrCmd to anything but
  you are still sending command below.

  Reply by Dara Navaei on 14 May 2023, 12:37
  > I was thinking to send the command anyways. If the active
  > reservoir is what we need, it will be ignored. But I changed
  > the code.

    Reply by Sean Nash on 14 May 2023, 16:56
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 09:57 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17381

  Use new #define (from comment above).

  Reply by Dara Navaei on 14 May 2023, 12:37
  > Done

    Reply by Sean Nash on 14 May 2023, 16:57
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 10:00 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17383

  Use new #define from comment above.

  Reply by Dara Navaei on 14 May 2023, 12:37
  > Done

    Reply by Sean Nash on 14 May 2023, 16:57
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 10:02 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17385

  I think there are cases where rsrvrCmd is not set and so we
  should not be calling this function in those cases.

  Reply by Dara Navaei on 14 May 2023, 12:37
  > I changed the code.

    Reply by Sean Nash on 14 May 2023, 16:57
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 May 2023, 17:00 
https://devapps.diality.us/cru/HD-DEN-15274-1#c17502

  Consider moving this declarations to top of function and then
  removing the outer {} for these cases.

  Reply by Dara Navaei on 15 May 2023, 20:15
  > Done

    Reply by Sean Nash on 16 May 2023, 09:12
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15274-1 https://devapps.diality.us/cru/HD-DEN-15274-1

Title: HD-DEN-15274_HD DG Test Configuration Setup
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     jtaylor   (*)
     Michael Garthwaite
     Darren Cox
     Steve Jarpe