This is a list of all comments for HD-DEN-15367-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ModeFault.c Revision Comment by Sean Nash on 09 June 2023, 15:16 https://devapps.diality.us/cru/HD-DEN-15367-1#c17772 Blank line between declaration and code. Reply by Dara Navaei on 12 June 2023, 08:59 > Done Reply by Sean Nash on 12 June 2023, 13:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by wbracken on 29 May 2023, 00:15 https://devapps.diality.us/cru/HD-DEN-15367-1#c17655 Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse Reply by Dara Navaei on 12 June 2023, 09:13 > Done Reply by wbracken on 12 June 2023, 10:57 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 30 May 2023, 08:25 https://devapps.diality.us/cru/HD-DEN-15367-1#c17672 Make 2nd condition similar to 1st ( != TRUE ) so any value that is not 1 will take normal path. And should this be an OR (not AND)? Reply by Sean Nash on 12 June 2023, 13:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 29 May 2023, 00:17 https://devapps.diality.us/cru/HD-DEN-15367-1#c17656 Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState Reply by Dara Navaei on 12 June 2023, 09:12 > Done Reply by wbracken on 12 June 2023, 10:58 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by wbracken on 06 June 2023, 18:27 https://devapps.diality.us/cru/HD-DEN-15367-1#c17766 Add function header. Reply by Dara Navaei on 12 June 2023, 09:03 > Done Reply by wbracken on 12 June 2023, 11:03 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 06 June 2023, 18:27 https://devapps.diality.us/cru/HD-DEN-15367-1#c17767 Add function header. Reply by Dara Navaei on 12 June 2023, 09:03 > Done Reply by wbracken on 12 June 2023, 11:03 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by wbracken on 06 June 2023, 13:17 https://devapps.diality.us/cru/HD-DEN-15367-1#c17763 Add disinfectCancelReqID Reply by Dara Navaei on 12 June 2023, 09:06 > Done Reply by wbracken on 13 June 2023, 11:47 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Darren Cox on 14 June 2023, 10:08 https://devapps.diality.us/cru/HD-DEN-15367-1#c17881 Where is currentDGCleaningMode initialized? Reply by Dara Navaei on 14 June 2023, 10:11 > It is called in the translationToStandyMode in the function > clearCurrentCleaningModeStatus(). Reply by Darren Cox on 14 June 2023, 10:18 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 06 June 2023, 13:19 https://devapps.diality.us/cru/HD-DEN-15367-1#c17764 Isn't currentStandbyState an output? Reply by Dara Navaei on 12 June 2023, 09:05 > That is true I fixed it. Reply by wbracken on 13 June 2023, 11:46 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 06 June 2023, 13:20 https://devapps.diality.us/cru/HD-DEN-15367-1#c17765 Add disinfectCancelReqID, currentStandbyState, currentDGCleaningMode Reply by Dara Navaei on 12 June 2023, 09:04 > Updated the function header. Reply by wbracken on 13 June 2023, 11:45 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 07 June 2023, 10:01 https://devapps.diality.us/cru/HD-DEN-15367-1#c17769 Add disinfectCancelReqID to header. Also argument stop. Reply by Dara Navaei on 12 June 2023, 09:01 > Done Reply by wbracken on 12 June 2023, 11:00 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 12 June 2023, 13:45 https://devapps.diality.us/cru/HD-DEN-15367-1#c17810 Alignment. Reply by Dara Navaei on 13 June 2023, 15:33 > Done Reply by Sean Nash on 14 June 2023, 09:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 June 2023, 09:07 https://devapps.diality.us/cru/HD-DEN-15367-1#c17875 Implicit bool to BOOL conversion. Prefer explicit conversion with ternary. Reply by Dara Navaei on 14 June 2023, 09:12 > Done Reply by Sean Nash on 14 June 2023, 09:18 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by Sean Nash on 09 June 2023, 15:14 https://devapps.diality.us/cru/HD-DEN-15367-1#c17770 Blank line between declarations and code. Reply by Sean Nash on 12 June 2023, 13:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 09 June 2023, 15:15 https://devapps.diality.us/cru/HD-DEN-15367-1#c17771 Blank line between declaration and code. Reply by Dara Navaei on 12 June 2023, 09:00 > Done Reply by Sean Nash on 12 June 2023, 13:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/BloodLeak.c Revision Comment by wbracken on 12 June 2023, 10:56 https://devapps.diality.us/cru/HD-DEN-15367-1#c17799 Add bloodLeakPeristenceCtr. Reply by Dara Navaei on 13 June 2023, 15:33 > Done Reply by wbracken on 13 June 2023, 17:20 > RESOLVED IN CODE WALKTHROUGH Revision Comment by jtaylor on 12 June 2023, 14:03 https://devapps.diality.us/cru/HD-DEN-15367-1#c17817 Should choose to either align on "=" or use " = ". Reply by Dara Navaei on 13 June 2023, 15:32 > Aligned, thanks. Reply by jtaylor on 14 June 2023, 09:05 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/BloodLeak.h Revision Comment by jtaylor on 07 June 2023, 09:08 https://devapps.diality.us/cru/HD-DEN-15367-1#c17768 "bloodLeakPersitentCounter" should be bloodLeakPersistentCounter Reply by Dara Navaei on 12 June 2023, 09:02 > Done Reply by jtaylor on 12 June 2023, 14:04 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-15367-1 https://devapps.diality.us/cru/HD-DEN-15367-1 Title: HD-DEN-15367_HD DG Test Configuration Setup Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (5 active, 1 completed*) Sean Nash (*) Michael Garthwaite wbracken Darren Cox jtaylor Steve Jarpe