This is a list of all comments for HD-DEN-15664-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/TreatmentEnd.c Revision Comment by Sean Nash on 20 July 2023, 17:26 https://devapps.diality.us/cru/HD-DEN-15664-1#c18220 We should send this countdown msg from a publish function that gets called by exec function for treatment end only once per second (see how this msg is sent by rinseback mode for example). And should send the message all the time. If in the wait for rinseback state, just send zeroes (and UI won't show countdown). If in paused state, always send 300 seconds for timeout and 300-(bloodSittingTimerCtr / 20) for countdown (don't let it go negative or wrap though). If an alarm dialog is being displayed, it should show the countdown for the whole 5 minutes (not just the last minute after warning). Reply by Darren Cox on 21 July 2023, 12:21 > Updated with publish function and overrides. Reply by Sean Nash on 21 July 2023, 15:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 July 2023, 14:56 https://devapps.diality.us/cru/HD-DEN-15664-1#c18229 Do we need to be able to override broadcast interval for this? I wouldn't think so. But if we do, need Dialin updated to support that. Reply by Darren Cox on 24 July 2023, 11:32 > Removed overrides. Reply by Dara Navaei on 24 July 2023, 11:33 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-15664-1 https://devapps.diality.us/cru/HD-DEN-15664-1 Title: HD-DEN-15664_Blood Pump Stop Time Exceeded Alarms 124 125 165 And 212 Alarm Timer Feature IS Statement of Objectives: State: Closed Summary: Author: Darren Cox Moderator: Darren Cox Reviewers: (4 active, 2 completed*) wbracken (*) jtaylor (*) Sean Nash Michael Garthwaite Dara Navaei Steve Jarpe