This is a list of all comments for HD-DEN-15994-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Rinseback.c
Revision Comment by Sean Nash on 16 August 2023, 15:10 
https://devapps.diality.us/cru/HD-DEN-15994-1#c18606

  This if will prevent countdown timer from being displayed
  unless we are paused or stopped after rinseback.  I think
  countdown timer is definitely needed for rinseback init state
  (pump is stopped and rinseback hasn't even started).  May be
  needed for new reconnect patient state as well.  
  I think it might be simpler/clearer to replace this if with a
  check for whether BP is running or not.  If BP is stopped, we
  proceed to next if.  If BP is running, keep timeouts at zero.

  Reply by jtaylor on 16 August 2023, 15:28
  > Done.

  Reply by Sean Nash on 16 August 2023, 16:42
  > You removed the if (great), but I don't see that you replaced
  > it with BP stopped check.  I don't think we want a countdown
  > if BP is running (blood not sitting).

    Reply by jtaylor on 17 August 2023, 08:15
    > As you pointed out earlier, rinsebackTimerCtr is set to
    > zero in states where BP is running, so the if condition
    > would only be TRUE (rinsebackTimerCtr > 0) if BP is not
    > running.

      Reply by Sean Nash on 17 August 2023, 08:35
      > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 04 August 2023, 12:45 
https://devapps.diality.us/cru/HD-DEN-15994-1#c18446

  This if condition appears to be redundant.  rinsebackTimerCtr
  is set to zero in states where BP is running, so previous if
  condition would only be TRUE (rinsebackTimerCtr > 0) if BP not
  running.

  Reply by jtaylor on 04 August 2023, 15:04
  > Done.

    Reply by Sean Nash on 04 August 2023, 15:49
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15994-1 https://devapps.diality.us/cru/HD-DEN-15994-1

Title: HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
Statement of Objectives:


State: Closed

Summary: 

Author: jtaylor
Moderator: jtaylor
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Darren Cox
     Steve Jarpe