This is a list of all comments for HD-DEN-16093-1.

Review Summary: No summary


----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 21 August 2023, 13:37 
https://devapps.diality.us/cru/HD-DEN-16093-1#c18657

  I think we have been trying to have these types of message IDs
  end in "_CMD_REQUEST".

  Reply by Vinayakam Mani on 21 August 2023, 18:05
  > Done.

    Reply by Sean Nash on 22 August 2023, 11:05
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by Sean Nash on 21 August 2023, 13:43 
https://devapps.diality.us/cru/HD-DEN-16093-1#c18658

  Consider following up on this command's success once we're in
  complete state (would need to add a handler function for
  complete state).  There is a getDGCommandResponse() function in
  DGInterface that we're using for other DG commands to make sure
  DG got and accepted the command (and sometimes retrying if
  not).

  Reply by Vinayakam Mani on 21 August 2023, 18:04
  > Done.

    Reply by Sean Nash on 22 August 2023, 11:17
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 August 2023, 11:17 
https://devapps.diality.us/cru/HD-DEN-16093-1#c18675

  Rename function to name of state (like others).

  Reply by Vinayakam Mani on 22 August 2023, 13:17
  > Updated.

    Reply by Sean Nash on 22 August 2023, 14:29
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16093-1 https://devapps.diality.us/cru/HD-DEN-16093-1

Title: HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (4 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Darren Cox
     Steve Jarpe