This is a list of all comments for HD-DEN-16391-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/DGInterface.c
Revision Comment by Sean Nash on 27 November 2023, 09:14 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19260

  Any reason why these reservoir variables are not part of the
  DG_TDI_TEMP_COUNTER_T structure?

  Reply by Vinayakam Mani on 27 November 2023, 11:07
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:29
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:09 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19251

  Should be currentActiveRes.

  Reply by Vinayakam Mani on 27 November 2023, 11:07
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:32
    > First letter (c) should be lower case.

      Reply by Vinayakam Mani on 28 November 2023, 10:25
      > Done.

        Reply by Sean Nash on 28 November 2023, 11:18
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by jtaylor on 20 November 2023, 10:23 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19250

  Extra blank line.

  Reply by Vinayakam Mani on 27 November 2023, 11:07
  > Done.

    Reply by jtaylor on 28 November 2023, 11:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:09 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19252

  Space after if.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:32
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:09 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19253

  Space between parenthesis.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:32
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:11 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19254

  Space after if.
  Also, consider refactoring this code by combining with if
  statement above.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:33
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:11 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19255

  Space after if.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:12 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19256

  Space after if.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:12 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19257

  Space after if.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:13 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19258

  Space after if.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:36
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 27 November 2023, 09:13 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19259

  Remove blank line.

  Reply by Vinayakam Mani on 27 November 2023, 11:08
  > Done.

    Reply by Sean Nash on 28 November 2023, 09:36
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DGInterface.h
Revision Comment by Sean Nash on 28 November 2023, 09:28 
https://devapps.diality.us/cru/HD-DEN-16391-1#c19284

  Would dgCurrentActiveReservoir be a better name?  I assume Temp
  refers to temperature (not temporary), but purpose is still not
  clear.

  Reply by Vinayakam Mani on 28 November 2023, 10:23
  > Done. it was meant to be temporary variable, as I see other
  > place "temp" used as temperature, changing name as suggested
  > to avoid confusion.

    Reply by Sean Nash on 28 November 2023, 11:17
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16391-1 https://devapps.diality.us/cru/HD-DEN-16391-1

Title: HD-DEN-16391_Bugfix/Den 16391 FW Dialysate Temperature Alarm Not Sensitive Enough Use Tdi Moving Avg
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     jpaguio
     Michael Garthwaite
     wbracken
     dcox
     jtaylor