This is a list of all comments for HD-DEN-16518-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by Michael Garthwaite on 15 January 2024, 10:25 
https://devapps.diality.us/cru/HD-DEN-16518-1#c19345

  This will cause open loop control mode to have a minimum of 11%
  instead of 10%. For open loop, pwmDC is assigned a value at
  line 295.  Do we still need the #define for the 10% pwm lower
  limit?

  Reply by Sean Nash on 15 January 2024, 10:42
  > Do we want to have the 11% minimum here?  I thought it was
  > just for closed loop control.

  Reply by Vinayakam Mani on 15 January 2024, 11:01
  > Updated code changes. Open loop still maintains the minimum
  > PWM duty cycle as 10%.

    Reply by Vinayakam Mani on 15 January 2024, 11:04
    > Updated code changes. Open loop still maintains the minimum
    > PWM duty cycle as 10%.

      Reply by Michael Garthwaite on 15 January 2024, 11:10
      > RESOLVED IN CODE WALKTHROUGH.


---

ID: HD-DEN-16518-1 https://devapps.diality.us/cru/HD-DEN-16518-1

Title: HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Darren Cox