This is a list of all comments for HD-DEN-16563-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Sean Nash on 25 January 2024, 10:15 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19358

  MIN_TIME_BETWEEN_AIR_TRAP_FILL_LOW_PRESSURE_ALARM_EXEMPTIONS_MS
  (as a suggestion).
  Also be more descriptive in comments.

  Reply by Sean Nash on 02 February 2024, 10:09
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 02 February 2024, 10:07 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19390

  This effectively changes exemption start to time of valve open
  instead of close.  We don't want to do that.

  Reply by Vinayakam Mani on 02 February 2024, 16:52
  > Done

    Reply by Sean Nash on 05 February 2024, 13:20
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 05 February 2024, 13:24 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19406

  I think reset flag should not be set here.  Should be set by
  new function when valve is closed I think.

  Reply by Vinayakam Mani on 05 February 2024, 15:18
  > lowVenousPressureExemptCheck - flag initialized to TRUE in
  > the Init routine.  Whenever valve opens (fill), it resets the
  > flag to "FALSE" ,the Exempt counter is not incremented. When
  > valve closes, flag is set back to TRUE and Exempt counter
  > being incremented.

    Reply by Sean Nash on 06 February 2024, 09:23
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 05 February 2024, 13:20 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19403

  Shouldn't this be set to TRUE?

  Reply by Vinayakam Mani on 05 February 2024, 15:23
  > lowVenousPressureExemptCheck - flag initialized to TRUE in
  > the Init routine. Whenever valve opens (fill), it resets the
  > flag to "FALSE" ,the Exempt counter is not incremented. When
  > valve closes, flag is set back to TRUE and Exempt counter
  > being incremented.

    Reply by Sean Nash on 06 February 2024, 09:23
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 05 February 2024, 13:18 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19402

  Add space between if and (.  Add to comment that low venous
  pressure must be exempt to increment counter.

  Reply by Vinayakam Mani on 05 February 2024, 15:53
  > Done.

    Reply by Sean Nash on 06 February 2024, 09:12
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 05 February 2024, 13:22 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19405

  Should also set new flag to FALSE here I think.

  Reply by Vinayakam Mani on 05 February 2024, 15:55
  > lowVenousPressureExemptCheck - flag initialized to TRUE in
  > the Init routine. Whenever valve opens (fill), it resets the
  > flag to "FALSE" ,the Exempt counter is not incremented. When
  > valve closes, flag is set back to TRUE and Exempt counter
  > being incremented.

    Reply by Sean Nash on 06 February 2024, 09:23
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 05 February 2024, 13:24 
https://devapps.diality.us/cru/HD-DEN-16563-1#c19407

  I think this function should set the old reset flag to FALSE
  here.  Function doesn't need a parameter because it is only
  called when valve closes which should always set reset flag to
  FALSE.

  Reply by Vinayakam Mani on 05 February 2024, 15:54
  > Done. Removed the parameter in function.

    Reply by Sean Nash on 06 February 2024, 09:22
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-16563-1 https://devapps.diality.us/cru/HD-DEN-16563-1

Title: HD-DEN-16563_Venous Pressure Readings Were Below 20Mmhg For 1.5 Minutes Before Low Venous 
Statement of Objectives:


State: Closed

Summary: 

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     jpaguio
     Dara Navaei
     Darren Cox