This is a list of all comments for HD-DEN-16851-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by Sean Nash on 01 May 2024, 14:22 https://devapps.diality.us/cru/HD-DEN-16851-1#c19692 should be 1,000 Reply by Vinayakam Mani on 02 May 2024, 11:13 > Done. Reply by Sean Nash on 02 May 2024, 11:26 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:24 https://devapps.diality.us/cru/HD-DEN-16851-1#c19693 Should be a F32 since it's an average. Comment should say 10s or something generic. Reply by Vinayakam Mani on 02 May 2024, 11:14 > Done. Reply by Sean Nash on 02 May 2024, 11:26 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:25 https://devapps.diality.us/cru/HD-DEN-16851-1#c19694 Change to "bloodPumpPartialOcclusionBaseline". Reply by Vinayakam Mani on 02 May 2024, 11:14 > Done. Reply by Sean Nash on 02 May 2024, 11:27 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:28 https://devapps.diality.us/cru/HD-DEN-16851-1#c19695 Not needed if you only trigger alarm after 1st stage destabilization state. Reply by Sean Nash on 02 May 2024, 11:28 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:29 https://devapps.diality.us/cru/HD-DEN-16851-1#c19728 I think these can remain U32s. It's just when we divide total by count to get the filtered value, then we should have F32. Reply by Vinayakam Mani on 02 May 2024, 12:27 > Done. Reply by Sean Nash on 02 May 2024, 12:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:31 https://devapps.diality.us/cru/HD-DEN-16851-1#c19729 Can stay U32. Reply by Vinayakam Mani on 02 May 2024, 12:27 > Done. Reply by Sean Nash on 02 May 2024, 12:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:32 https://devapps.diality.us/cru/HD-DEN-16851-1#c19696 0.0F. Reply by Vinayakam Mani on 02 May 2024, 11:14 > Done. Reply by Sean Nash on 02 May 2024, 11:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:35 https://devapps.diality.us/cru/HD-DEN-16851-1#c19731 Are we guaranteed to be in Treatment mode here? If not, check mode too. Reply by Vinayakam Mani on 02 May 2024, 12:28 > Yes, when we are not in treatment mode, the state machine > sets the state to "pressure_limits_state_off" at start of > this function ( line : 673). hence mode check is not > necessary. Reply by Sean Nash on 02 May 2024, 12:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:47 https://devapps.diality.us/cru/HD-DEN-16851-1#c19697 I think for partial occlusion, we need a separate 15 min timer and should not be a timeout - needs to be a timercounter so it can be paused when not in dialysis state. Reply by Vinayakam Mani on 02 May 2024, 11:14 > Done. Reply by Sean Nash on 02 May 2024, 11:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:38 https://devapps.diality.us/cru/HD-DEN-16851-1#c19733 Casting not necessary. Reply by Vinayakam Mani on 02 May 2024, 12:30 > Done Reply by Sean Nash on 02 May 2024, 12:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:54 https://devapps.diality.us/cru/HD-DEN-16851-1#c19698 Must be in dialysis state and stage 2 or stable pressure state. Reply by Vinayakam Mani on 02 May 2024, 11:15 > Done. Reply by Sean Nash on 02 May 2024, 11:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:56 https://devapps.diality.us/cru/HD-DEN-16851-1#c19699 Use F32 macro since filtered pressure will be float. Reply by Vinayakam Mani on 02 May 2024, 11:15 > Done. Reply by Sean Nash on 02 May 2024, 11:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:39 https://devapps.diality.us/cru/HD-DEN-16851-1#c19736 F32 not needed here. Reply by Vinayakam Mani on 02 May 2024, 12:31 > Done Reply by Sean Nash on 02 May 2024, 12:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:40 https://devapps.diality.us/cru/HD-DEN-16851-1#c19737 Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32. You might want to cast the total as F32 as well for consistency. Reply by Vinayakam Mani on 02 May 2024, 12:31 > Done Reply by Sean Nash on 02 May 2024, 12:53 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 02 May 2024, 11:43 https://devapps.diality.us/cru/HD-DEN-16851-1#c19738 I think we just want to publish the baseline here (not +1000). Reply by Vinayakam Mani on 02 May 2024, 12:31 > Done. Reply by Sean Nash on 02 May 2024, 12:54 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.h Revision Comment by Sean Nash on 01 May 2024, 14:13 https://devapps.diality.us/cru/HD-DEN-16851-1#c19690 Change to "bldPumpOcclusionLongFilter". Reply by Vinayakam Mani on 02 May 2024, 11:15 > Done. Reply by Sean Nash on 02 May 2024, 11:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 May 2024, 14:16 https://devapps.diality.us/cru/HD-DEN-16851-1#c19691 Capitalize Baseline. Reply by Vinayakam Mani on 02 May 2024, 11:15 > Done. Reply by Sean Nash on 02 May 2024, 11:26 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-16851-1 https://devapps.diality.us/cru/HD-DEN-16851-1 Title: HD-DEN-16851_New Alarm For Increased Occlus Statement of Objectives: State: Closed Summary: Author: Vinayakam Mani Moderator: Vinayakam Mani Reviewers: (3 active, 2 completed*) Sean Nash (*) Dara Navaei (*) pvedantam jpaguio Michael Garthwaite