This is a list of all comments for HD-DEN-1906-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by pmontazemi on 02 March 2020, 10:09 https://devapps.diality.us/cru/HD-DEN-1906-1#c1304 Remove. Reply by Sean Nash on 02 March 2020, 13:38 > Done. Reply by pmontazemi on 02 March 2020, 14:11 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 March 2020, 10:10 https://devapps.diality.us/cru/HD-DEN-1906-1#c1305 Remove. Reply by Sean Nash on 02 March 2020, 13:37 > This is a doxygen "end of group" comment. Reply by pmontazemi on 02 March 2020, 14:10 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.h Revision Comment by pmontazemi on 02 March 2020, 10:10 https://devapps.diality.us/cru/HD-DEN-1906-1#c1306 Why /// instead of //? I see this in many places. Reply by Sean Nash on 02 March 2020, 13:36 > Needed for doxygen. Reply by pmontazemi on 02 March 2020, 14:10 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/TreatmentStop.c Revision Comment by pmontazemi on 02 March 2020, 10:28 https://devapps.diality.us/cru/HD-DEN-1906-1#c1309 Remove. Reply by Sean Nash on 02 March 2020, 13:34 > This is a doxygen "end of group" comment. Reply by pmontazemi on 02 March 2020, 14:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/TreatmentStop.h Revision Comment by pmontazemi on 02 March 2020, 10:28 https://devapps.diality.us/cru/HD-DEN-1906-1#c1310 Remove. Reply by Sean Nash on 02 March 2020, 13:34 > This is a doxygen "end of group" comment. Reply by pmontazemi on 02 March 2020, 14:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by pmontazemi on 02 March 2020, 10:17 https://devapps.diality.us/cru/HD-DEN-1906-1#c1308 Remove. Reply by Sean Nash on 02 March 2020, 13:35 > Done. Reply by pmontazemi on 02 March 2020, 14:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/CommBuffers.c Revision Comment by pmontazemi on 02 March 2020, 10:29 https://devapps.diality.us/cru/HD-DEN-1906-1#c1311 Remove. Reply by pmontazemi on 02 March 2020, 14:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 March 2020, 10:29 https://devapps.diality.us/cru/HD-DEN-1906-1#c1312 Remove. Reply by Sean Nash on 02 March 2020, 13:31 > Done. Reply by pmontazemi on 02 March 2020, 14:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 March 2020, 10:29 https://devapps.diality.us/cru/HD-DEN-1906-1#c1313 Remove extra line at EOF. Reply by Sean Nash on 02 March 2020, 13:31 > Done. Reply by pmontazemi on 02 March 2020, 14:07 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by pmontazemi on 02 March 2020, 10:38 https://devapps.diality.us/cru/HD-DEN-1906-1#c1316 Remove extra lines at EOF. Reply by Sean Nash on 02 March 2020, 13:28 > Done. Reply by pmontazemi on 02 March 2020, 14:05 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by pmontazemi on 02 March 2020, 10:30 https://devapps.diality.us/cru/HD-DEN-1906-1#c1314 Remove. Reply by Sean Nash on 02 March 2020, 13:30 > Done. Reply by pmontazemi on 02 March 2020, 14:07 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/WatchdogMgmt.c Revision Comment by pmontazemi on 02 March 2020, 10:39 https://devapps.diality.us/cru/HD-DEN-1906-1#c1317 Remove extra lines at EOF. Reply by Sean Nash on 02 March 2020, 13:28 > Done. Reply by pmontazemi on 02 March 2020, 14:05 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by pmontazemi on 02 March 2020, 10:39 https://devapps.diality.us/cru/HD-DEN-1906-1#c1318 Remove. Reply by Sean Nash on 02 March 2020, 13:27 > CAN_TEST build switch and related code is removed. Reply by pmontazemi on 02 March 2020, 14:04 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeFault.c Revision Comment by pmontazemi on 02 March 2020, 10:16 https://devapps.diality.us/cru/HD-DEN-1906-1#c1307 Extra line. Reply by Sean Nash on 02 March 2020, 13:36 > Removed. Reply by pmontazemi on 02 March 2020, 14:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/MsgQueues.c Revision Comment by pmontazemi on 02 March 2020, 10:30 https://devapps.diality.us/cru/HD-DEN-1906-1#c1315 Remove extra lines at EOF. Reply by Sean Nash on 02 March 2020, 13:29 > Done. Reply by pmontazemi on 02 March 2020, 14:07 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-1906-1 https://devapps.diality.us/cru/HD-DEN-1906-1 Title: HD-DEN-1906_Ultrafiltration Part 1 of 3 Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (1 active, 2 completed*) Dara Navaei (*) pmontazemi (*) Behrouz NematiPour