This is a list of all comments for HD-DEN-3115-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by pmontazemi on 14 May 2020, 15:20 https://devapps.diality.us/cru/HD-DEN-3115-1#c1911 Really? Every 10 s we control the blood pump? Reply by Sean Nash on 14 May 2020, 15:45 > This is what looks best at this time. Flow sensors tend to be > pretty accurate if you average over a long time, but very > choppy in the short or even medium term. However, if I extend > the filter time to 10 s, then the control interval has to be > at least 10 s as well. I've discussed with Blaine and Nick to > verify this is ok. I think we don't want the blood and > dialysate inlet pumps to be very reactive anyway - the > treatment lasts 1-8 hours, so we can start with an estimated > PWM that will be close and then take a minute to gradually > improve on that estimate with our slower control. Reply by pmontazemi on 18 May 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 June 2020, 10:35 https://devapps.diality.us/cru/HD-DEN-3115-1#c2465 From a physics perspective, why do we need different PWM ramp up and ramp down rates? Reply by Sean Nash on 24 June 2020, 08:47 > Slower ramp up gives time to detect occlusion before things > get too fast. Also, for blood, we will want to ramp up > slowly for patient comfort I imagine. > For ramp down, I think we want to be more aggressive in > stopping pumps - may be due to alarm - want to get to > controlled stop ASAP. Reply by pmontazemi on 06 July 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 May 2020, 15:21 https://devapps.diality.us/cru/HD-DEN-3115-1#c1912 I am assuming this is test code? Reply by Sean Nash on 14 May 2020, 15:44 > Yes, supporting System's flow sensor testing. Reply by pmontazemi on 18 May 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:26 https://devapps.diality.us/cru/HD-DEN-3115-1#c1861 Where does this constant come from? Create a #define for it. Reply by pmontazemi on 12 May 2020, 08:44 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:26 https://devapps.diality.us/cru/HD-DEN-3115-1#c1862 Why -1.0? Reply by Sean Nash on 11 May 2020, 18:17 > We want motor speeds in reverse direction represented as > negative number. Reply by pmontazemi on 12 May 2020, 08:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:28 https://devapps.diality.us/cru/HD-DEN-3115-1#c1863 measuredMotorSpeed Reply by pmontazemi on 12 May 2020, 08:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:28 https://devapps.diality.us/cru/HD-DEN-3115-1#c1864 measured throughout because it can be confused with measure Reply by pmontazemi on 12 May 2020, 08:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:29 https://devapps.diality.us/cru/HD-DEN-3115-1#c1865 What does impliedFlow mean in terms of controls? Reply by Sean Nash on 11 May 2020, 18:14 > It's flow that we would expect from displacement of each > rotor turn based on measured motor speed. Motor speed can be > converted to rotor speed, then rotor speed to flow. Reply by pmontazemi on 12 May 2020, 08:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by pmontazemi on 14 May 2020, 15:22 https://devapps.diality.us/cru/HD-DEN-3115-1#c1914 I see many functions are the same for both blood and dialysate pumps and their control, perhaps worth considering consolidating into FWCommon? Reply by Sean Nash on 14 May 2020, 15:37 > I've considered this and generally agree. I've been waiting > for dust to settle a bit on design - if the design for the 2 > pumps diverges a lot, I'd want to keep them separate. If > they stay this aligned, I'll want to move a lot of the common > code to a common module. Reply by pmontazemi on 18 May 2020, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 May 2020, 15:22 https://devapps.diality.us/cru/HD-DEN-3115-1#c1913 Every 10 s? Reply by Sean Nash on 14 May 2020, 15:39 > This is what looks best at this time. Flow sensors tend to > be pretty accurate if you average over a long time, but very > choppy in the short or even medium term. However, if I > extend the filter time to 10 s, then the control interval has > to be at least 10 s as well. I've discussed with Blaine and > Nick to verify this is ok. I think we don't want the blood > and dialysate inlet pumps to be very reactive anyway - the > treatment lasts 1-8 hours, so we can start with an estimated > PWM that will be close and then take a minute to gradually > improve on that estimate with our slower control. Reply by pmontazemi on 18 May 2020, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:31 https://devapps.diality.us/cru/HD-DEN-3115-1#c1866 Why some of them are ///< and some ///>? Reply by Sean Nash on 13 May 2020, 10:30 > Fixed. Reply by pmontazemi on 13 May 2020, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:32 https://devapps.diality.us/cru/HD-DEN-3115-1#c1867 Why start variable name with cap? Reply by Sean Nash on 11 May 2020, 18:04 > These are structure names. I'm working my way through > removing the use of this macro everywhere due to Doxygen > issue. Fixed these. Reply by pmontazemi on 12 May 2020, 08:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialOutFlow.c Revision Comment by pmontazemi on 11 May 2020, 16:35 https://devapps.diality.us/cru/HD-DEN-3115-1#c1870 0x10000 #define as constant Reply by Sean Nash on 11 May 2020, 18:01 > Fixed. Reply by pmontazemi on 12 May 2020, 08:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:36 https://devapps.diality.us/cru/HD-DEN-3115-1#c1872 Same here. Reply by Sean Nash on 11 May 2020, 18:01 > Fixed. Reply by pmontazemi on 12 May 2020, 08:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:36 https://devapps.diality.us/cru/HD-DEN-3115-1#c1871 Why -1.0? Reply by Sean Nash on 11 May 2020, 18:02 > We want RPM speeds in reverse direction to be presented as > negative number. Reply by pmontazemi on 12 May 2020, 08:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by pmontazemi on 11 May 2020, 16:42 https://devapps.diality.us/cru/HD-DEN-3115-1#c1877 Remove commented lines Reply by Sean Nash on 11 May 2020, 17:50 > Peman, these are engineering build switches. I need to be > able to comment/uncomment these as the need arises. Reply by pmontazemi on 12 May 2020, 08:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by pmontazemi on 27 May 2020, 09:31 https://devapps.diality.us/cru/HD-DEN-3115-1#c2054 Is this supposed to change? Is this per device? Is this general parameter? Reply by Sean Nash on 27 May 2020, 10:19 > This whole state machine is UF test code (because we don't > yet have prescription settings and pre-treatment modes > implemented). Reply by pmontazemi on 27 May 2020, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 31 May 2020, 15:18 https://devapps.diality.us/cru/HD-DEN-3115-1#c2128 Create constant if this is here to stay. Reply by Sean Nash on 02 June 2020, 11:55 > This is test code. I've added a comment to this line for > TODO to define this volume in pre-treatment mode when > developed. Reply by pmontazemi on 05 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/CommBuffers.c Revision Comment by pmontazemi on 11 May 2020, 16:38 https://devapps.diality.us/cru/HD-DEN-3115-1#c1873 Why commented out? Reply by Sean Nash on 11 May 2020, 17:57 > I didn't intend to keep it commented out - I had commented it > out to troubleshoot something and forgot to put it back. > Fixed. Reply by pmontazemi on 12 May 2020, 08:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/Interrupts.c Revision Comment by pmontazemi on 11 May 2020, 16:39 https://devapps.diality.us/cru/HD-DEN-3115-1#c1874 Remove commented line Reply by Sean Nash on 11 May 2020, 17:53 > The commented line is how it was supposed to be. Looks like > the two signals got swapped. I didn't want to delete until I > know what EE was going to do. Reply by pmontazemi on 12 May 2020, 08:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:40 https://devapps.diality.us/cru/HD-DEN-3115-1#c1875 Remove commented line Reply by Sean Nash on 11 May 2020, 17:54 > The commented line is how it was supposed to be. Looks like > the two signals got swapped. I didn't want to delete until I > know what EE was going to do. Reply by pmontazemi on 12 May 2020, 08:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:40 https://devapps.diality.us/cru/HD-DEN-3115-1#c1876 What should we do here? Reply by Sean Nash on 11 May 2020, 17:54 > Unsure. It shouldn't happen as I've not configured any other > edges. But if it did, I'm not sure I want to alarm on that - > probably no harm in ignoring it. I would like to know it's > happening though, so I'm torn. > Thoughts? Reply by pmontazemi on 12 May 2020, 08:39 > Propose that we throw in a software fault. Reply by pmontazemi on 13 May 2020, 10:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialInFlow.h Revision Comment by pmontazemi on 11 May 2020, 16:33 https://devapps.diality.us/cru/HD-DEN-3115-1#c1868 Again, should it be ///< or ///>? Reply by pmontazemi on 12 May 2020, 08:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 May 2020, 16:34 https://devapps.diality.us/cru/HD-DEN-3115-1#c1869 Choice of name, can be confused with Dialin API... Reply by Sean Nash on 11 May 2020, 18:04 > I noticed that a long time ago - but it's everywhere. Would > be very painful to change now. Reply by pmontazemi on 12 May 2020, 08:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by pmontazemi on 23 June 2020, 17:02 https://devapps.diality.us/cru/HD-DEN-3115-1#c2561 VDr (instead of VDzr)? Reply by Sean Nash on 24 June 2020, 08:52 > This is HD side so not VDr. I got this abbreviation from HD > HDD. My flow path diagram has these two valves as VDi and > VDo (for bypassing the dialyzer). HDD has VDio and VDzr. > Not sure why the discrepancy, but I think it makes sense to > follow HDD for FPGA register names. Reply by pmontazemi on 06 July 2020, 10:52 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 23 June 2020, 17:01 https://devapps.diality.us/cru/HD-DEN-3115-1#c2559 VDr (instead of VDzr)? Reply by Sean Nash on 24 June 2020, 08:50 > This is HD side so not VDr. I got this abbreviation from HD > HDD. My flow path diagram has these two valves as VDi and > VDo (for bypassing the dialyzer). HDD has VDio and VDzr. > Not sure why the discrepancy, but I think it makes sense to > follow HDD for FPGA register names. Reply by pmontazemi on 06 July 2020, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 May 2020, 12:23 https://devapps.diality.us/cru/HD-DEN-3115-1#c2120 What is the difference between Readings1 and Readings2? I am not a big fan of iterating function names. Reply by Sean Nash on 29 May 2020, 13:51 > Agreed. Fixed. Reply by pmontazemi on 01 June 2020, 10:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/het.c Revision Comment by pmontazemi on 19 June 2020, 08:58 https://devapps.diality.us/cru/HD-DEN-3115-1#c2436 Why were the #pragmas removed? Reply by Sean Nash on 19 June 2020, 09:15 > HALCoGen removed these when I changed from FIQ to IRQ. Reply by pmontazemi on 19 June 2020, 10:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: Common.h Revision Comment by qnguyen on 07 July 2020, 14:08 https://devapps.diality.us/cru/HD-DEN-3115-1#c2726 Misspelled significant and this should be 3-byte word? Reply by Dara Navaei on 19 October 2023, 08:40 > RESOLVED in CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by pmontazemi on 19 May 2020, 07:58 https://devapps.diality.us/cru/HD-DEN-3115-1#c1930 Comment? Reply by Sean Nash on 19 May 2020, 08:27 > Added comments. Reply by pmontazemi on 20 May 2020, 13:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 19 May 2020, 21:05 https://devapps.diality.us/cru/HD-DEN-3115-1#c1932 Align comments Reply by Sean Nash on 20 May 2020, 08:41 > Done. Reply by pmontazemi on 20 May 2020, 13:08 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DGInterface.h Revision Comment by pmontazemi on 04 June 2020, 11:35 https://devapps.diality.us/cru/HD-DEN-3115-1#c2179 Remove //100 commented. Reply by Sean Nash on 05 June 2020, 10:20 > Done. Reply by pmontazemi on 05 June 2020, 10:38 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by pmontazemi on 27 May 2020, 09:30 https://devapps.diality.us/cru/HD-DEN-3115-1#c2053 Remove extra line. Reply by Sean Nash on 27 May 2020, 10:20 > Done. Reply by pmontazemi on 27 May 2020, 10:46 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.h Revision Comment by pmontazemi on 02 June 2020, 11:24 https://devapps.diality.us/cru/HD-DEN-3115-1#c2160 Insert blank line between each comment/void Reply by Sean Nash on 02 June 2020, 11:58 > Done Reply by pmontazemi on 05 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 June 2020, 11:25 https://devapps.diality.us/cru/HD-DEN-3115-1#c2161 Same here. Reply by Sean Nash on 02 June 2020, 11:57 > Done Reply by pmontazemi on 05 June 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 June 2020, 11:25 https://devapps.diality.us/cru/HD-DEN-3115-1#c2162 Same here. Reply by Sean Nash on 02 June 2020, 11:57 > Done Reply by pmontazemi on 05 June 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 02 June 2020, 11:25 https://devapps.diality.us/cru/HD-DEN-3115-1#c2163 Same here. Reply by Sean Nash on 02 June 2020, 11:57 > Done Reply by pmontazemi on 05 June 2020, 10:38 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_vim.c Revision Comment by pmontazemi on 19 June 2020, 09:02 https://devapps.diality.us/cru/HD-DEN-3115-1#c2442 Why change from FIQ to IRQ? Reply by Sean Nash on 19 June 2020, 09:06 > FIQs are non-maskable - cannot protect thread sensitive code > from interruption. FIQs were a hopefully temporary way to > get the interrupt priority I needed. I reviewed the RM46 > datasheet last weekend and found a way to change IRQ > priorities and so I no longer need FIQs. Reply by pmontazemi on 19 June 2020, 10:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/adc.c Revision Comment by pmontazemi on 19 June 2020, 08:57 https://devapps.diality.us/cru/HD-DEN-3115-1#c2435 Why were the #pragmas removed? Reply by Sean Nash on 19 June 2020, 09:15 > HALCoGen removed these when I changed from FIQ to IRQ. Reply by pmontazemi on 19 June 2020, 10:43 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sci.c Revision Comment by pmontazemi on 19 June 2020, 08:59 https://devapps.diality.us/cru/HD-DEN-3115-1#c2437 Why were the #pragmas removed? Reply by Sean Nash on 19 June 2020, 09:14 > HALCoGen removed these when I changed from FIQ to IRQ. Reply by pmontazemi on 19 June 2020, 10:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_core.asm Revision Comment by pmontazemi on 19 June 2020, 09:00 https://devapps.diality.us/cru/HD-DEN-3115-1#c2438 What setting changed in sys_core? Things were changed at the assembly level. Reply by Sean Nash on 19 June 2020, 09:13 > I re-sized stacks in HALCoGen and it made these changes. Reply by pmontazemi on 19 June 2020, 10:45 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_dma.c Revision Comment by pmontazemi on 19 June 2020, 09:00 https://devapps.diality.us/cru/HD-DEN-3115-1#c2439 Why were the #pragmas removed? Reply by Sean Nash on 19 June 2020, 09:13 > HALCoGen did this when I changed from FIQ to IRQ. Reply by pmontazemi on 19 June 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_link.cmd Revision Comment by pmontazemi on 19 June 2020, 09:01 https://devapps.diality.us/cru/HD-DEN-3115-1#c2440 What changed in the memory mapping? Reply by Sean Nash on 19 June 2020, 09:10 > I re-sized the various stacks. Reply by pmontazemi on 19 June 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_startup.c Revision Comment by pmontazemi on 19 June 2020, 09:01 https://devapps.diality.us/cru/HD-DEN-3115-1#c2441 What changed in VIM? Reply by Sean Nash on 19 June 2020, 09:09 > This is where I am changing the default IRQ priorities to > what I want. Reply by pmontazemi on 19 June 2020, 10:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/CGT.CCS.h Revision Comment by pmontazemi on 19 June 2020, 08:54 https://devapps.diality.us/cru/HD-DEN-3115-1#c2426 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Reply by Dara Navaei on 19 June 2020, 09:23 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:38 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/Compatibility.h Revision Comment by pmontazemi on 19 June 2020, 08:55 https://devapps.diality.us/cru/HD-DEN-3115-1#c2427 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Reply by Dara Navaei on 19 June 2020, 09:23 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/Constants.h Revision Comment by pmontazemi on 19 June 2020, 08:55 https://devapps.diality.us/cru/HD-DEN-3115-1#c2428 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Reply by Dara Navaei on 19 June 2020, 09:23 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/F021.h Revision Comment by pmontazemi on 19 June 2020, 08:55 https://devapps.diality.us/cru/HD-DEN-3115-1#c2429 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright? Reply by Dara Navaei on 19 June 2020, 09:24 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/FapiFunctions.h Revision Comment by pmontazemi on 19 June 2020, 08:55 https://devapps.diality.us/cru/HD-DEN-3115-1#c2430 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright? Reply by Dara Navaei on 19 June 2020, 09:24 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/Helpers.h Revision Comment by pmontazemi on 19 June 2020, 08:55 https://devapps.diality.us/cru/HD-DEN-3115-1#c2431 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright? Reply by Dara Navaei on 19 June 2020, 09:21 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/Registers.h Revision Comment by pmontazemi on 19 June 2020, 08:56 https://devapps.diality.us/cru/HD-DEN-3115-1#c2432 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright? Reply by Dara Navaei on 19 June 2020, 09:24 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/Registers_FMC_LE.h Revision Comment by pmontazemi on 19 June 2020, 08:56 https://devapps.diality.us/cru/HD-DEN-3115-1#c2433 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright? Reply by Dara Navaei on 19 June 2020, 09:25 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: FlashDrvr/Types.h Revision Comment by pmontazemi on 19 June 2020, 08:56 https://devapps.diality.us/cru/HD-DEN-3115-1#c2434 This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright? Reply by Dara Navaei on 19 June 2020, 09:26 > This is the TI copyright that we got these API files > originally. Yes, they are different from the other TI files > that are generated by HALCoGen but they are still TI files > and not ours. When I was working on the copyright script, I > realized the script did not realize they are not our files > and added our copyright. I enhanced the algorithm that checks > whether a file belongs to Diality or not, so this issue will > not happen. At the same time, I removed the Diality > copyright. I am not sure why there is a "?" in their > copyright that does not affect the script's parsing > capabilities. Reply by pmontazemi on 19 June 2020, 10:40 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-3115-1 https://devapps.diality.us/cru/HD-DEN-3115-1 Title: HD-DEN-3115_HD Blood Flow 3 of 3 Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (1 active, 2 completed*) Dara Navaei (*) pmontazemi (*) qnguyen