This is a list of all comments for HD-DEN-5674-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Services/AlarmMgmt.c Revision Comment by pmontazemi on 29 December 2020, 10:53 https://devapps.diality.us/cru/HD-DEN-5674-2#c6905 Why were these all deleted? Reply by Sean Nash on 29 December 2020, 11:29 > Moved to AlarmDefs.h in common as there is need to update > this table when new enum is added. Reply by pmontazemi on 30 December 2020, 14:27 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by pmontazemi on 30 December 2020, 13:59 https://devapps.diality.us/cru/HD-DEN-5674-2#c7021 its instead of it's Reply by pmontazemi on 04 January 2021, 08:12 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:00 https://devapps.diality.us/cru/HD-DEN-5674-2#c7024 its instead of it's Reply by Sean Nash on 30 December 2020, 16:17 > Fixed. Reply by pmontazemi on 04 January 2021, 08:07 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by qnguyen on 30 December 2020, 14:34 https://devapps.diality.us/cru/HD-DEN-5674-2#c7079 should not instead of shouldn't. Reply by Sean Nash on 30 December 2020, 15:56 > Fixed. Reply by qnguyen on 04 January 2021, 08:13 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:51 https://devapps.diality.us/cru/HD-DEN-5674-2#c7005 Should not (formal) instead of Shouldn't (informal) Reply by Sean Nash on 30 December 2020, 13:56 > Fixed. Reply by pmontazemi on 30 December 2020, 14:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:51 https://devapps.diality.us/cru/HD-DEN-5674-2#c7006 it is (formal) instead of it's (informal) Reply by Sean Nash on 30 December 2020, 13:56 > Fixed. Reply by pmontazemi on 30 December 2020, 14:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:52 https://devapps.diality.us/cru/HD-DEN-5674-2#c7007 Should not (formal) instead of Shouldn't (informal) Reply by Sean Nash on 30 December 2020, 13:57 > Fixed. Reply by pmontazemi on 30 December 2020, 14:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:52 https://devapps.diality.us/cru/HD-DEN-5674-2#c7008 Should not (formal) instead of Shouldn't (informal) Reply by Sean Nash on 30 December 2020, 16:19 > Fixed. Reply by pmontazemi on 04 January 2021, 08:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 29 December 2020, 09:02 https://devapps.diality.us/cru/HD-DEN-5674-2#c6867 Suggest using parentheses to separate conditions. Reply by Sean Nash on 29 December 2020, 11:44 > Done. Reply by qnguyen on 30 December 2020, 14:09 > The parentheses for second condition is mismatched. Reply by Sean Nash on 30 December 2020, 16:22 > Fixed. Reply by qnguyen on 04 January 2021, 08:13 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by pmontazemi on 29 December 2020, 10:37 https://devapps.diality.us/cru/HD-DEN-5674-2#c6895 Macro starts with capital "M" for DialIn/DialOut but here with lower cap. Reply by Sean Nash on 29 December 2020, 11:43 > Will start all comments w/ capital. Reply by pmontazemi on 30 December 2020, 14:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:02 https://devapps.diality.us/cru/HD-DEN-5674-2#c6945 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:19 > Fixed. Reply by pmontazemi on 30 December 2020, 14:28 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:03 https://devapps.diality.us/cru/HD-DEN-5674-2#c6947 Do not (formal) instead of don't (informal) Reply by Sean Nash on 30 December 2020, 12:23 > Fixed. Reply by pmontazemi on 30 December 2020, 14:29 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:03 https://devapps.diality.us/cru/HD-DEN-5674-2#c6948 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 12:24 > Fixed. Reply by pmontazemi on 30 December 2020, 14:28 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:03 https://devapps.diality.us/cru/HD-DEN-5674-2#c6949 Add "?" at end of question comment. Reply by Sean Nash on 30 December 2020, 12:27 > Done. Reply by pmontazemi on 30 December 2020, 14:30 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:04 https://devapps.diality.us/cru/HD-DEN-5674-2#c6950 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:28 > Fixed. Reply by pmontazemi on 30 December 2020, 14:30 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by pmontazemi on 30 December 2020, 12:09 https://devapps.diality.us/cru/HD-DEN-5674-2#c6956 we will (formal) instead of we'll (informal) Reply by Sean Nash on 30 December 2020, 12:32 > Fixed. Reply by pmontazemi on 30 December 2020, 14:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:09 https://devapps.diality.us/cru/HD-DEN-5674-2#c6957 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:32 > Fixed. Reply by pmontazemi on 30 December 2020, 14:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:09 https://devapps.diality.us/cru/HD-DEN-5674-2#c6958 Do not (formal) instead of Don't (informal) Reply by Sean Nash on 30 December 2020, 12:32 > Fixed. Reply by pmontazemi on 30 December 2020, 14:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:10 https://devapps.diality.us/cru/HD-DEN-5674-2#c6959 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 12:33 > Fixed. Reply by pmontazemi on 30 December 2020, 14:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialOutFlow.c Revision Comment by pmontazemi on 30 December 2020, 12:29 https://devapps.diality.us/cru/HD-DEN-5674-2#c6973 we will (formal) instead of we'll (informal) Reply by Sean Nash on 30 December 2020, 12:33 > Fixed. Reply by pmontazemi on 30 December 2020, 14:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:29 https://devapps.diality.us/cru/HD-DEN-5674-2#c6974 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:33 > Fixed. Reply by pmontazemi on 30 December 2020, 14:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:30 https://devapps.diality.us/cru/HD-DEN-5674-2#c6977 Do not (formal) instead of Don't (informal) Reply by Sean Nash on 30 December 2020, 12:34 > Fixed. Reply by Dara Navaei on 19 October 2023, 08:17 > RESOLVED in CODE WALKTHROUGH Revision Comment by pmontazemi on 30 December 2020, 12:30 https://devapps.diality.us/cru/HD-DEN-5674-2#c6978 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 12:34 > Fixed. Reply by pmontazemi on 30 December 2020, 14:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:30 https://devapps.diality.us/cru/HD-DEN-5674-2#c6979 Add "?" Reply by Sean Nash on 30 December 2020, 12:35 > Done. Reply by pmontazemi on 30 December 2020, 14:33 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by pmontazemi on 29 December 2020, 10:55 https://devapps.diality.us/cru/HD-DEN-5674-2#c6906 Add TODO to remember to either uncomment or delete the lines below. Reply by Sean Nash on 29 December 2020, 11:34 > These build switches are meant to be commented out at times - > that is how the switch is turned off. Reply by pmontazemi on 30 December 2020, 14:27 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:07 https://devapps.diality.us/cru/HD-DEN-5674-2#c7040 Align comments and numbers. Reply by Sean Nash on 30 December 2020, 15:57 > These comments are aligned when not commented out (switched > off). Reply by pmontazemi on 04 January 2021, 08:10 > Add general TODO here then. Reply by pmontazemi on 04 January 2021, 08:15 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by pmontazemi on 29 December 2020, 10:47 https://devapps.diality.us/cru/HD-DEN-5674-2#c6900 Remove extra line. Reply by Sean Nash on 29 December 2020, 11:42 > Added TODO instead. Reply by pmontazemi on 30 December 2020, 14:23 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by pmontazemi on 30 December 2020, 12:54 https://devapps.diality.us/cru/HD-DEN-5674-2#c6995 Should not (formal) instead of Shouldn't (informal) Reply by Sean Nash on 30 December 2020, 13:39 > Fixed. Reply by pmontazemi on 30 December 2020, 14:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 December 2020, 10:48 https://devapps.diality.us/cru/HD-DEN-5674-2#c6903 Remove extra line. Reply by Sean Nash on 29 December 2020, 11:40 > Added TODO instead. Reply by pmontazemi on 30 December 2020, 14:36 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeTreatment.h Revision Comment by pmontazemi on 30 December 2020, 12:56 https://devapps.diality.us/cru/HD-DEN-5674-2#c6996 ????? are for what? Can we add definition here? Reply by Sean Nash on 30 December 2020, 13:40 > Not sure why I had the ?????. Fixed Reply by pmontazemi on 30 December 2020, 14:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeTreatmentParams.c Revision Comment by qnguyen on 29 December 2020, 08:59 https://devapps.diality.us/cru/HD-DEN-5674-2#c6866 Mismatch param. Reply by Sean Nash on 29 December 2020, 11:46 > Fixed. Reply by qnguyen on 30 December 2020, 14:10 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by pmontazemi on 30 December 2020, 14:02 https://devapps.diality.us/cru/HD-DEN-5674-2#c7028 have not (formal) instead of haven't (informal) Reply by Sean Nash on 30 December 2020, 16:14 > Fixed. Reply by pmontazemi on 04 January 2021, 08:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:03 https://devapps.diality.us/cru/HD-DEN-5674-2#c7029 Do not transmit if not other nodes on CAN bus Reply by Sean Nash on 30 December 2020, 16:14 > Done. Reply by pmontazemi on 04 January 2021, 08:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:03 https://devapps.diality.us/cru/HD-DEN-5674-2#c7030 do not (formal) instead of don't (informal) Reply by Sean Nash on 30 December 2020, 16:13 > Fixed. Reply by pmontazemi on 04 January 2021, 08:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:54 https://devapps.diality.us/cru/HD-DEN-5674-2#c7009 Should not (formal) instead of Shouldn't (informal) Reply by Sean Nash on 30 December 2020, 13:58 > Fixed. Reply by pmontazemi on 30 December 2020, 14:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:55 https://devapps.diality.us/cru/HD-DEN-5674-2#c7010 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 13:59 > Fixed. Reply by pmontazemi on 30 December 2020, 14:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:55 https://devapps.diality.us/cru/HD-DEN-5674-2#c7011 there is (formal) instead of there's (informal) Reply by Sean Nash on 30 December 2020, 14:00 > Fixed. Reply by pmontazemi on 30 December 2020, 14:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:56 https://devapps.diality.us/cru/HD-DEN-5674-2#c7013 We are (formal) instead of We're (informal) Reply by Sean Nash on 30 December 2020, 14:00 > Fixed. Reply by pmontazemi on 30 December 2020, 14:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c7033 Formalize sentence. Reply by Sean Nash on 30 December 2020, 16:12 > Implemented TODO. Removed comment. Reply by pmontazemi on 04 January 2021, 08:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c7034 Formalize sentence. Reply by Sean Nash on 30 December 2020, 16:10 > Implemented TODO. Removed comment. Reply by pmontazemi on 04 January 2021, 08:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:56 https://devapps.diality.us/cru/HD-DEN-5674-2#c7014 there is (formal) instead of there's (informal) Reply by Sean Nash on 30 December 2020, 14:00 > Fixed. Reply by pmontazemi on 30 December 2020, 14:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c7035 Formalize sentence. Reply by Sean Nash on 30 December 2020, 16:02 > Done. Reply by pmontazemi on 04 January 2021, 08:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:56 https://devapps.diality.us/cru/HD-DEN-5674-2#c7015 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 15:59 > Fixed. Reply by pmontazemi on 04 January 2021, 08:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c7036 Formalize sentence. Reply by Sean Nash on 30 December 2020, 16:00 > Done. Reply by pmontazemi on 04 January 2021, 08:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c7037 Formalize sentence. Reply by Sean Nash on 30 December 2020, 15:58 > Done. Reply by pmontazemi on 04 January 2021, 08:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 13:57 https://devapps.diality.us/cru/HD-DEN-5674-2#c7018 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 16:17 > Fixed. Reply by pmontazemi on 04 January 2021, 08:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 14:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c7038 Formalize sentence. Reply by Sean Nash on 30 December 2020, 15:58 > Done. Reply by pmontazemi on 04 January 2021, 08:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/WatchdogMgmt.c Revision Comment by pmontazemi on 30 December 2020, 14:00 https://devapps.diality.us/cru/HD-DEN-5674-2#c7025 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 16:16 > Fixed. Reply by pmontazemi on 04 January 2021, 08:07 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by pmontazemi on 30 December 2020, 12:50 https://devapps.diality.us/cru/HD-DEN-5674-2#c6989 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 13:37 > Fixed. Reply by pmontazemi on 30 December 2020, 14:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:50 https://devapps.diality.us/cru/HD-DEN-5674-2#c6990 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 13:37 > Fixed. Reply by pmontazemi on 30 December 2020, 14:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:51 https://devapps.diality.us/cru/HD-DEN-5674-2#c6991 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 13:37 > Fixed. Reply by pmontazemi on 30 December 2020, 14:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:51 https://devapps.diality.us/cru/HD-DEN-5674-2#c6992 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 13:37 > Fixed. Reply by pmontazemi on 30 December 2020, 14:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:51 https://devapps.diality.us/cru/HD-DEN-5674-2#c6993 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 13:38 > Fixed. Reply by pmontazemi on 30 December 2020, 14:35 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeFault.c Revision Comment by pmontazemi on 30 December 2020, 12:52 https://devapps.diality.us/cru/HD-DEN-5674-2#c6994 Should not (formal) instead of Shouldn't (informal) Reply by Sean Nash on 30 December 2020, 13:38 > Fixed. Reply by pmontazemi on 30 December 2020, 14:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeService.c Revision Comment by pmontazemi on 29 December 2020, 10:47 https://devapps.diality.us/cru/HD-DEN-5674-2#c6901 Remove extra line. Reply by Sean Nash on 30 December 2020, 16:19 > Done. Reply by pmontazemi on 04 January 2021, 08:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 29 December 2020, 10:48 https://devapps.diality.us/cru/HD-DEN-5674-2#c6902 Remove extra line. Reply by Sean Nash on 29 December 2020, 11:41 > Added TODO instead. Reply by pmontazemi on 30 December 2020, 14:26 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by pmontazemi on 30 December 2020, 12:07 https://devapps.diality.us/cru/HD-DEN-5674-2#c6954 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 12:30 > Fixed. Reply by pmontazemi on 30 December 2020, 14:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:07 https://devapps.diality.us/cru/HD-DEN-5674-2#c6955 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 12:30 > Fixed. Reply by pmontazemi on 30 December 2020, 14:31 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.h Revision Comment by pmontazemi on 29 December 2020, 10:50 https://devapps.diality.us/cru/HD-DEN-5674-2#c6904 Do we start comments with capital or not? Need consistency. Reply by Sean Nash on 29 December 2020, 11:46 > Will update all comments to start w/ capital letter. Reply by pmontazemi on 30 December 2020, 14:26 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/AlarmLamp.c Revision Comment by pmontazemi on 30 December 2020, 12:01 https://devapps.diality.us/cru/HD-DEN-5674-2#c6943 What does this comment mean? Are we adding colors (green + red is brown, not yellow)? Are we adding bits or states (then be explicit)? Reply by Sean Nash on 30 December 2020, 12:12 > With our alarm lamp LED(s), turning the green and red LEDs on > will give us yellow. Reply by pmontazemi on 30 December 2020, 14:27 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:01 https://devapps.diality.us/cru/HD-DEN-5674-2#c6944 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:18 > Fixed. Reply by pmontazemi on 30 December 2020, 14:29 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/AirTrap.c Revision Comment by pmontazemi on 30 December 2020, 11:58 https://devapps.diality.us/cru/HD-DEN-5674-2#c6941 Why TODO? Reply by Sean Nash on 30 December 2020, 12:13 > I do not yet know what the actual volume of our venous line > is. Reply by pmontazemi on 30 December 2020, 14:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 11:59 https://devapps.diality.us/cru/HD-DEN-5674-2#c6942 we have (formal) instead of we've (informal) Reply by Sean Nash on 30 December 2020, 12:18 > Fixed. Reply by pmontazemi on 30 December 2020, 14:27 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Buttons.c Revision Comment by pmontazemi on 30 December 2020, 12:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c6951 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:28 > Fixed. Reply by pmontazemi on 30 December 2020, 14:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:05 https://devapps.diality.us/cru/HD-DEN-5674-2#c6952 we are (forma) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:29 > Fixed. Reply by pmontazemi on 30 December 2020, 14:30 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 30 December 2020, 12:06 https://devapps.diality.us/cru/HD-DEN-5674-2#c6953 we are (formal) instead of we're (informal) Reply by Sean Nash on 30 December 2020, 12:29 > Fixed. Reply by pmontazemi on 30 December 2020, 14:31 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Tasks/TaskBG.c Revision Comment by pmontazemi on 30 December 2020, 14:01 https://devapps.diality.us/cru/HD-DEN-5674-2#c7027 Cannot (formal) instead of Can't (informal) Reply by Sean Nash on 30 December 2020, 16:15 > Fixed. Reply by pmontazemi on 04 January 2021, 08:07 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-5674-2 https://devapps.diality.us/cru/HD-DEN-5674-2 Title: HD-DEN-5674_Alarm Design (3 of 4) Statement of Objectives: State: Closed Summary: Author: Sean Nash Reviewers: (0 active, 3 completed*) qnguyen (*) Dara Navaei (*) pmontazemi (*)