This is a list of all comments for HD-DEN-6200-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by Sean Nash on 21 January 2021, 09:18 https://devapps.diality.us/cru/HD-DEN-6200-1#c7544 Consider having a switch statement here for each reject reason code. Maybe we're only handling the invalid parameter reason for now, but we may change our minds later. You can group the rest of the reasons+default with just a comment that our state machines will detect and handle failure of DG to advance for now. This will make it clear that we didn't forget about the other cases. Reply by qnguyen on 21 January 2021, 10:20 > Added the switch statement. > Added comment and TODO. Reply by Sean Nash on 21 January 2021, 10:34 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Prime.c Revision Comment by Sean Nash on 15 January 2021, 10:26 https://devapps.diality.us/cru/HD-DEN-6200-1#c7403 I think we want to drain reservoir all the way now that we're moving away from the straw concept. Let's discuss this. Reply by qnguyen on 15 January 2021, 15:15 > Changed drain volume to 0. Reply by Sean Nash on 18 January 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 11:04 https://devapps.diality.us/cru/HD-DEN-6200-1#c7419 Is half fill appropriate for both reservoirs? I think we need a TODO here to determine the fill volume we want for each reservoir and I believe they will be different in the end so we probably need two #defines here. Reply by qnguyen on 15 January 2021, 15:14 > Added TODO. Reply by Sean Nash on 18 January 2021, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 10:52 https://devapps.diality.us/cru/HD-DEN-6200-1#c7416 I think we want to be broadcasting priming progress (% complete or maybe est. time (in secs) countdown) during prime (really prime+wet self-tests) so UI can show progress. Peter may have already defined a msg for this. Consider what else may need to be broadcast during prime for Dialin purposes. Reply by qnguyen on 15 January 2021, 21:26 > Added priming time countdown and priming current state. Reply by Sean Nash on 18 January 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 10:59 https://devapps.diality.us/cru/HD-DEN-6200-1#c7417 What if DG does not go to drain mode (e.g. DG rejected drain command)? We will get stuck in this state. Let's discuss DG command handling - we may need to add more to DG response so HD can handle these types of issues. Reply by qnguyen on 18 January 2021, 23:01 > Added handler to DG command response. Reply by Sean Nash on 20 January 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 11:09 https://devapps.diality.us/cru/HD-DEN-6200-1#c7421 Do we need to wait until we're done with first part of dialysate prime (or at least check to make sure it's already done) before we switch reservoirs? Reply by qnguyen on 15 January 2021, 11:27 > The first part of dialysate prime actually waits for > reservoir 1 to be complete and become active. Reply by Sean Nash on 15 January 2021, 11:38 > I understand that prime will likely finish its job before > the reservoir fills, but what if it doesn't? If fill > finishes first, this code will switch reservoirs before > prime was done using it. Reply by qnguyen on 15 January 2021, 11:48 > Moved reservoir switching to prime state machine. Reply by Sean Nash on 18 January 2021, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 20 January 2021, 10:38 https://devapps.diality.us/cru/HD-DEN-6200-1#c7534 Why are there several cases with same outcome in this function? Reply by qnguyen on 20 January 2021, 11:41 > These states rely on valves setting change on the transition > of the previous state. Therefore, we need to start from the > beginning state. Reply by pmontazemi on 21 January 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 15 January 2021, 10:13 https://devapps.diality.us/cru/HD-DEN-6200-1#c7398 Maybe just call init function above in case other inits get added there? Reply by qnguyen on 15 January 2021, 10:39 > Done. Reply by Sean Nash on 18 January 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 10:14 https://devapps.diality.us/cru/HD-DEN-6200-1#c7399 Do we need to broadcast anything during pre-treatment mode? I think sub-mode states are already broadcast elsewhere, but think about any Dialin needs. Reply by qnguyen on 18 January 2021, 14:36 > Pretreatment mode does not have data needed to be broadcast. > We might have more data once the mode is more mature. Reply by Sean Nash on 20 January 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 10:16 https://devapps.diality.us/cru/HD-DEN-6200-1#c7400 Add more constraints. Should not accept start treatment request if we haven't completed all pre-treatment steps through to patient connection at the end. Reply by Sean Nash on 18 January 2021, 09:40 > Is this signal indicating start of treatment or proceeding to > patient connection? Function name indicates former, > conditions indicate latter. Reply by qnguyen on 18 January 2021, 14:04 > Fixed. This signal indicates the start of treatment. Reply by Sean Nash on 20 January 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 10:18 https://devapps.diality.us/cru/HD-DEN-6200-1#c7401 Why only this one alarm? I think wherever possible, we want to be more general about alarm user actions. If user chooses to end treatment in response to any alarm that didn't block that option, we should allow it. Reply by Sean Nash on 18 January 2021, 09:42 > Some user actions may depend on which sub-mode or even > sub-mode state we are in (e.g. stop or resume would need to > be handled if we're priming or re-circulating or doing self > tests, but not loading cartridge/disposables). So some > signals can be handled here and others will need to be > forwarded to the current sub-mode where more context can be > assessed. Reply by qnguyen on 20 January 2021, 19:25 > Signals have been forwarded to appropriate sub-mode to > handle. Reply by Sean Nash on 21 January 2021, 10:34 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 January 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6200-1#c7402 I think clearing off alarm is handled when user chooses an action (resume, ACK, end Tx, ...). I don't think you need to clear these alarms here. Reply by qnguyen on 15 January 2021, 21:32 > Removed alarm clear action. Reply by Sean Nash on 18 January 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by pmontazemi on 15 January 2021, 15:02 https://devapps.diality.us/cru/HD-DEN-6200-1#c7442 Add extra line. Reply by qnguyen on 15 January 2021, 21:31 > Done. Reply by pmontazemi on 18 January 2021, 10:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 15 January 2021, 15:02 https://devapps.diality.us/cru/HD-DEN-6200-1#c7443 Add extra line. Reply by qnguyen on 15 January 2021, 21:31 > Done. Reply by pmontazemi on 18 January 2021, 10:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 15 January 2021, 15:02 https://devapps.diality.us/cru/HD-DEN-6200-1#c7444 Add extra line. Reply by qnguyen on 15 January 2021, 21:31 > Done. Reply by pmontazemi on 18 January 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 15 January 2021, 15:03 https://devapps.diality.us/cru/HD-DEN-6200-1#c7445 Add extra line. Reply by qnguyen on 15 January 2021, 21:30 > Done. Reply by pmontazemi on 18 January 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: MsgDefs.h Revision Comment by Sean Nash on 18 January 2021, 09:49 https://devapps.diality.us/cru/HD-DEN-6200-1#c7459 One msg for all DG commands? How will HD know which command is being responded to? Reply by qnguyen on 18 January 2021, 14:00 > The message has a command id field. Reply by Sean Nash on 20 January 2021, 10:35 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 18 January 2021, 09:36 https://devapps.diality.us/cru/HD-DEN-6200-1#c7456 Are these for HD to DG commands? Clarify in comment, name. Reply by qnguyen on 18 January 2021, 14:03 > Added clarification to comment and name. Reply by Sean Nash on 20 January 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.h Revision Comment by pmontazemi on 21 January 2021, 10:27 https://devapps.diality.us/cru/HD-DEN-6200-1#c7551 What made us change our mind and pass in set temperature command compared to before (just turning OFF and ON)? Reply by qnguyen on 21 January 2021, 10:35 > Before, the HD sends target temperature using another > message. So now we add the target temperature to this > command, so DG can handle the full command. Reply by pmontazemi on 21 January 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-6200-1 https://devapps.diality.us/cru/HD-DEN-6200-1 Title: HD-DEN-6200_HD Disposable Priming Dialyzer Side Statement of Objectives: State: Closed Summary: Author: qnguyen Reviewers: (1 active, 2 completed*) Sean Nash (*) pmontazemi (*) Dara Navaei