This is a list of all comments for HD-DEN-6402-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/Prime.c Revision Comment by pmontazemi on 11 February 2021, 10:41 https://devapps.diality.us/cru/HD-DEN-6402-1#c7969 Add comment for this #define. Reply by qnguyen on 11 February 2021, 10:53 > It has the doxygen comment above it. Reply by pmontazemi on 11 February 2021, 11:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 08 February 2021, 09:46 https://devapps.diality.us/cru/HD-DEN-6402-1#c7834 This flag does not appear to be a "result". Rename to primeCompleted. Reply by qnguyen on 08 February 2021, 11:06 > Done. Reply by Sean Nash on 11 February 2021, 10:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 08 February 2021, 09:48 https://devapps.diality.us/cru/HD-DEN-6402-1#c7835 Is this response persistent? Or does this function consume the response? Even if persistent, I suspect a new response will replace previous response and this makes me nervous. I think it would be safer to have a separate flag for each possible response so there is no race condition. Reply by qnguyen on 09 February 2021, 19:09 > Fixed. Now store command response for each possible commands > rather than one command response for all commands. Reply by Sean Nash on 11 February 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 08 February 2021, 09:51 https://devapps.diality.us/cru/HD-DEN-6402-1#c7836 If not yet in fill mode, will dgCmdResp persist to next time? Reply by qnguyen on 08 February 2021, 10:16 > It will persist unless HD issues another command to DG. Reply by Sean Nash on 11 February 2021, 10:49 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/SelfTests.c Revision Comment by Sean Nash on 01 February 2021, 22:47 https://devapps.diality.us/cru/HD-DEN-6402-1#c7790 Add _MS to end to indicate unit of time. Reply by qnguyen on 03 February 2021, 16:47 > Done. Reply by Sean Nash on 11 February 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:46 https://devapps.diality.us/cru/HD-DEN-6402-1#c7789 Add _ML_MIN to end to indicate units. Reply by qnguyen on 03 February 2021, 16:47 > Done. Reply by Sean Nash on 11 February 2021, 10:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 08 February 2021, 09:26 https://devapps.diality.us/cru/HD-DEN-6402-1#c7831 Rate is mL/min, not mL. Reply by qnguyen on 08 February 2021, 12:02 > Corrected. Reply by Sean Nash on 11 February 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:44 https://devapps.diality.us/cru/HD-DEN-6402-1#c7788 Add _MS to end to indicate units of time. Also, is this a self-test for blood pump occlusion sensor? If so, maybe replace "PRESSURE" with "OCCLUSION" to clarify. Reply by qnguyen on 03 February 2021, 16:48 > Done. This is not a self-test for blood pump occlusion sensor > (OB). This is for PBa and PBo pressure sensors. Reply by Sean Nash on 11 February 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:48 https://devapps.diality.us/cru/HD-DEN-6402-1#c7791 Is there no upper limit for arterial or lower limit for venous pressure? Reply by qnguyen on 04 February 2021, 08:58 > When we run blood pump in forward direction, we should see > negative on arterial and positive on venous. > This limit here is to stop blood pump even if the time to run > the blood has not been reached. Reply by Sean Nash on 11 February 2021, 10:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:49 https://devapps.diality.us/cru/HD-DEN-6402-1#c7792 Is this a maximum? Also, add _MMHG to end to indicate units of pressure. Reply by qnguyen on 03 February 2021, 16:50 > Done. It is a tolerance on pressure difference after we > return back to normal state from pressure self-tests. Reply by Sean Nash on 11 February 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:50 https://devapps.diality.us/cru/HD-DEN-6402-1#c7793 Capitalize state Reply by qnguyen on 03 February 2021, 16:50 > Done. Reply by Sean Nash on 11 February 2021, 10:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:58 https://devapps.diality.us/cru/HD-DEN-6402-1#c7795 I think this function is too big. I generally prefer to have static functions to call for each case unless it's a one-liner to keep the switch state from getting too big. Reply by qnguyen on 03 February 2021, 17:16 > Agree. All multi-lines state have been moved to a static > function. Reply by Sean Nash on 11 February 2021, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 08 February 2021, 09:29 https://devapps.diality.us/cru/HD-DEN-6402-1#c7832 This function is too big. Create static functions to handle these switch cases. Reply by qnguyen on 08 February 2021, 11:42 > Done. Reply by Sean Nash on 11 February 2021, 10:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by pmontazemi on 11 February 2021, 10:33 https://devapps.diality.us/cru/HD-DEN-6402-1#c7949 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:53 > This is doxygen style comment if not in the same line. Reply by Dara Navaei on 19 October 2023, 08:12 > RESOLVED in CODE WALKTHROUGH Revision Comment by Sean Nash on 01 February 2021, 22:09 https://devapps.diality.us/cru/HD-DEN-6402-1#c7786 Name is too vague. Make it clear this minimum is for occlusion sensors. And also if this minimum applies to narrower scope(s) (like no cartridge or dry or wet) or is it general and should never be less than this? Reply by qnguyen on 03 February 2021, 17:22 > Renamed. Reply by Sean Nash on 11 February 2021, 10:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:33 https://devapps.diality.us/cru/HD-DEN-6402-1#c7787 So in this dry test, I guess if any one of these is out of range we can say something is wrong with the way the cartridge was loaded. Should we try to distinguish between improperly loaded cartridge and no cartridge loaded (all 3 occlusions are < threshold)? Reply by qnguyen on 01 February 2021, 23:01 > 1) When we fail this test, we only alarm to let the user know > and take action. > 2) We should. The alarms activation will be moved into this > function. Reply by Sean Nash on 11 February 2021, 10:41 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 01 February 2021, 23:17 https://devapps.diality.us/cru/HD-DEN-6402-1#c7800 I think there are a few things that need to happen in patient connection sub-mode (e.g. get UF volume, get initial blood pressure reading, ...) before user should be allowed to start treatment. Need to check which state in patient connection sub-mode we're in too - should the last state where we've done everything and waiting for user to start. Reply by qnguyen on 09 February 2021, 19:12 > This will be done once we get to patient connection sub-mode. > Added TODO. Reply by Sean Nash on 11 February 2021, 10:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:13 https://devapps.diality.us/cru/HD-DEN-6402-1#c7799 What is happening in this sub-mode that can be resumed? Reply by qnguyen on 09 February 2021, 19:24 > Removed the sub-mode. Each sub-mode will have their > pause/stopped state. Reply by Sean Nash on 11 February 2021, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:27 https://devapps.diality.us/cru/HD-DEN-6402-1#c7803 Should we check door before we run the self tests? Reply by qnguyen on 03 February 2021, 18:14 > Done. Reply by Sean Nash on 11 February 2021, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:29 https://devapps.diality.us/cru/HD-DEN-6402-1#c7804 And if we fail self-tests? Where do we go? Are all failures a fault? Reply by qnguyen on 01 February 2021, 23:35 > For no cartridge self-tests, all failures result in a fault > because they are essentially POST tests. Reply by Sean Nash on 11 February 2021, 10:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:31 https://devapps.diality.us/cru/HD-DEN-6402-1#c7805 Check for door open before running self-tests. Really, self-test execution should go last and only if no door open and no stop signal. Reply by qnguyen on 09 February 2021, 19:26 > Done. Reply by Sean Nash on 11 February 2021, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:33 https://devapps.diality.us/cru/HD-DEN-6402-1#c7806 Are these the only two alarms possible in this state? Consider using the alarm stop signal here instead of checking specific alarm status. Reply by qnguyen on 09 February 2021, 19:26 > Done. Reply by Sean Nash on 11 February 2021, 10:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:39 https://devapps.diality.us/cru/HD-DEN-6402-1#c7808 Move execPrime() to end - only if no door open and no alarm stop signal. Reply by qnguyen on 09 February 2021, 19:25 > Done. Reply by Sean Nash on 11 February 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:50 https://devapps.diality.us/cru/HD-DEN-6402-1#c7810 What is this state? Where did it get set? Why aren't we going back to recirc state? Reply by qnguyen on 09 February 2021, 19:25 > Removed this sub-mode. Reply by Sean Nash on 11 February 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 23:52 https://devapps.diality.us/cru/HD-DEN-6402-1#c7811 Consider returning a OPN_CLS_STATE_T instead of BOOL for readability. Reply by qnguyen on 03 February 2021, 18:14 > Done. Also moved the function to FPGA module. Reply by Sean Nash on 11 February 2021, 10:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/AlarmMgmt.h Revision Comment by pmontazemi on 11 February 2021, 10:44 https://devapps.diality.us/cru/HD-DEN-6402-1#c7973 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:52 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by pmontazemi on 11 February 2021, 10:44 https://devapps.diality.us/cru/HD-DEN-6402-1#c7974 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:52 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by pmontazemi on 11 February 2021, 10:24 https://devapps.diality.us/cru/HD-DEN-6402-1#c7943 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 11:07 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:25 https://devapps.diality.us/cru/HD-DEN-6402-1#c7944 So for system versions >= P-BETA v0.5, bloodFlowCalGain equals -1.0f? And why is the blood flow sensor installed forward on v0.4.5 and backward on all upward system versions? Reply by qnguyen on 11 February 2021, 10:55 > No, this is for system version <= P-BETA v0.5. Reply by pmontazemi on 11 February 2021, 11:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 16:35 https://devapps.diality.us/cru/HD-DEN-6402-1#c7761 So if calibration is good but flow sensor is bad, we won't apply calibration? I think these two checks should be separated. Start test as passed. Then fail if either check is failed. Reply by qnguyen on 01 February 2021, 22:58 > If the flow sensor is bad, we will go to fault. In this case, > the calibration does not matter anymore. Reply by Sean Nash on 01 February 2021, 23:56 > Fair point. Reply by Sean Nash on 11 February 2021, 10:50 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by pmontazemi on 11 February 2021, 10:31 https://devapps.diality.us/cru/HD-DEN-6402-1#c7946 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:53 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 22:05 https://devapps.diality.us/cru/HD-DEN-6402-1#c7785 Same comment as in BloodFlow.c Reply by qnguyen on 03 February 2021, 17:17 > If the sensor is bad, we will go to fault. In this case, the > calibration does not matter anymore. Reply by Sean Nash on 11 February 2021, 10:49 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by pmontazemi on 11 February 2021, 10:45 https://devapps.diality.us/cru/HD-DEN-6402-1#c7975 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:51 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: HDDefs.h Revision Comment by Sean Nash on 01 February 2021, 22:54 https://devapps.diality.us/cru/HD-DEN-6402-1#c7794 Can this wait for door close be a state within the self-test no cartridge sub-mode? Also need to wait for user to open the door at the end of self-test no cartridge sub-mode or beginning of cartridge install sub-mode and then close the door again at end of cartridge install sub-mode. I see that some of these sub-modes don't have states, but probably should or will eventually. The 3 self-test sub-modes can have their own state machines in SelfTests.c. I think Recirc and Cartridge Install sub-modes may need their own .c files (PreTreatmentRecirc.c and DisposableInstall.c?) with state machines of their own as well. Reply by qnguyen on 03 February 2021, 18:11 > Removed. Door close has been converted to sub-mode state for > appropriate sub-mode (no cartridge self-test, dry self-test) Reply by Sean Nash on 11 February 2021, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 15:47 https://devapps.diality.us/cru/HD-DEN-6402-1#c7754 Dry-run? Reply by qnguyen on 03 February 2021, 18:10 > Reworded. Reply by Sean Nash on 11 February 2021, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 15:48 https://devapps.diality.us/cru/HD-DEN-6402-1#c7755 Looks like you've merged prime and wet self-tests. Maybe mention wet self-tests in the comment. Reply by qnguyen on 03 February 2021, 18:10 > Done. Reply by Sean Nash on 11 February 2021, 10:51 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 15:48 https://devapps.diality.us/cru/HD-DEN-6402-1#c7756 Why do we need this start state? For modes, we have the transitionTo...() functions that get called automatically before starting a new mode. For sub-modes and their states, the general approach should be to handle transition logic at the same point the code changes the sub-mode/state. You can consider a separate transition state like this if there are a lot of states that could transition to this state or if the transition is very complex, but this one doesn't seem to fit either category. Reply by qnguyen on 09 February 2021, 19:14 > Removed. This has been converted to pre-treatment recirculate > sub-mode state. Reply by Sean Nash on 11 February 2021, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 February 2021, 15:54 https://devapps.diality.us/cru/HD-DEN-6402-1#c7757 Any reason why pause state can't be part of patient connection state? Reply by qnguyen on 09 February 2021, 19:14 > Removed. Pause state should be handled by sub-mode. Reply by Sean Nash on 11 February 2021, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7918 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:59 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7919 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:58 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7921 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by Dara Navaei on 19 October 2023, 08:13 > RESOLVED in CODE WALKTHROUGH Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7922 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7923 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7924 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dara Navaei on 11 February 2021, 09:42 https://devapps.diality.us/cru/HD-DEN-6402-1#c7882 Align the comment. Reply by qnguyen on 11 February 2021, 11:05 > Fixed. Reply by Dara Navaei on 11 February 2021, 11:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7925 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7926 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7927 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7928 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:21 https://devapps.diality.us/cru/HD-DEN-6402-1#c7929 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:22 https://devapps.diality.us/cru/HD-DEN-6402-1#c7930 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:22 https://devapps.diality.us/cru/HD-DEN-6402-1#c7931 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:57 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:04 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:22 https://devapps.diality.us/cru/HD-DEN-6402-1#c7932 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:03 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7933 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:02 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7934 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:02 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7935 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:03 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7936 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:02 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7938 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by Dara Navaei on 19 October 2023, 08:13 > RESOLVED in CODE WALKTHROUGH Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7939 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:03 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7940 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:56 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:02 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 17 February 2021, 09:18 https://devapps.diality.us/cru/HD-DEN-6402-1#c8159 Need to add these new alarms to alarm table below. Reply by qnguyen on 17 February 2021, 10:38 > These new alarms have been added to the alarm table. Reply by Sean Nash on 17 February 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: MsgDefs.h Revision Comment by pmontazemi on 11 February 2021, 10:23 https://devapps.diality.us/cru/HD-DEN-6402-1#c7941 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:55 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 16 February 2021, 13:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:24 https://devapps.diality.us/cru/HD-DEN-6402-1#c7942 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:55 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:01 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: DGDefs.h Revision Comment by pmontazemi on 11 February 2021, 10:17 https://devapps.diality.us/cru/HD-DEN-6402-1#c7912 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:49 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:18 https://devapps.diality.us/cru/HD-DEN-6402-1#c7914 Don't we need to tell it also which valves setting we are moving towards? I guess I am unclear about the purpose of this one flag in this enumerator. Reply by qnguyen on 11 February 2021, 10:49 > This enumerator is for HD to know which command DG is > responding to. Reply by pmontazemi on 11 February 2021, 11:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:17 https://devapps.diality.us/cru/HD-DEN-6402-1#c7913 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:50 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:18 https://devapps.diality.us/cru/HD-DEN-6402-1#c7915 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:50 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:18 https://devapps.diality.us/cru/HD-DEN-6402-1#c7916 Remove extra "/" from comment. Reply by qnguyen on 11 February 2021, 10:50 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 17 February 2021, 09:19 https://devapps.diality.us/cru/HD-DEN-6402-1#c8160 Why commented out? Reply by qnguyen on 17 February 2021, 10:37 > These has been uncommented. Reply by Sean Nash on 17 February 2021, 10:38 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by pmontazemi on 11 February 2021, 10:47 https://devapps.diality.us/cru/HD-DEN-6402-1#c7982 Delete or add TODO comment. Reply by qnguyen on 11 February 2021, 10:49 > TODO is at line 32. Reply by pmontazemi on 11 February 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Prime.h Revision Comment by pmontazemi on 11 February 2021, 10:43 https://devapps.diality.us/cru/HD-DEN-6402-1#c7972 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:52 > This is doxygen style comment if not in the same line. Reply by Dara Navaei on 19 October 2023, 08:13 > RESOLVED in CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by Sean Nash on 08 February 2021, 09:43 https://devapps.diality.us/cru/HD-DEN-6402-1#c7833 This is now included in the header file so we can remove here. Reply by qnguyen on 08 February 2021, 11:19 > Done. Reply by Sean Nash on 11 February 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 11 February 2021, 10:38 https://devapps.diality.us/cru/HD-DEN-6402-1#c7960 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:53 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 15 February 2021, 13:27 https://devapps.diality.us/cru/HD-DEN-6402-1#c8116 Should not there be two IDs we are passing in? i.e., are we taking both actions on the same reservoir? Reply by qnguyen on 16 February 2021, 09:59 > We are taking both actions on the same reservoir. [~snash] > can provide more details. Reply by Sean Nash on 17 February 2021, 09:12 > Before switching to newly filled reservoir, we want to take > a baseline weight (before starting UF with it). So we are > initializing the starting and final weights for the > reservoir here. As UF progresses on this reservoir after > we switch to it, the final weight will gradually increase > and the delta between the two is how much UF we've taken > using this reservoir. Reply by pmontazemi on 17 February 2021, 10:40 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DGInterface.h Revision Comment by pmontazemi on 11 February 2021, 10:31 https://devapps.diality.us/cru/HD-DEN-6402-1#c7945 Remove all extra "/" from all comments. Reply by qnguyen on 11 February 2021, 10:54 > This is doxygen style comment if not in the same line. Reply by pmontazemi on 11 February 2021, 11:01 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 10 February 2021, 23:06 https://devapps.diality.us/cru/HD-DEN-6402-1#c7856 Do we need a setting for normal control via active reservoir? Or will the next cmdSetDGActiveReservoir command put the valves back in a normal state? Reply by qnguyen on 11 February 2021, 00:00 > Next cmdSetDGActiveReservoir will put the valves back in a > normal state. Reply by Sean Nash on 11 February 2021, 10:36 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-6402-1 https://devapps.diality.us/cru/HD-DEN-6402-1 Title: HD-DEN-6402_HD Dev Pre Treatment Self Tests Statement of Objectives: State: Closed Summary: Author: qnguyen Moderator: qnguyen Reviewers: (0 active, 3 completed*) Sean Nash (*) Dara Navaei (*) pmontazemi (*)