This is a list of all comments for HD-DEN-752-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Buttons.c
Revision Comment by pmontazemi on 03 December 2019, 10:45 
https://devapps.diality.us/cru/HD-DEN-752-2#c408

  1. Space between arithmetic signs;
  2. Did you want to use the STUCK_BUTTON_TIMEOUT instead of 1000
  if they are correlated?

  Reply by pmontazemi on 04 December 2019, 10:07
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by lbaloa on 04 December 2019, 08:41 
https://devapps.diality.us/cru/HD-DEN-752-2#c449

  I would suggest using && operator to reduce complexity of code

  Reply by lbaloa on 04 December 2019, 10:14
  > RESOLVED IN CODE WALKTHROUGH


---

ID: HD-DEN-752-2 https://devapps.diality.us/cru/HD-DEN-752-2

Title: Added blood pump control per flow.  Added timeout to power off request.  Added more interrupt handling....
Statement of Objectives:
Added blood pump control per flow.  Added timeout to power off request.  Added more interrupt handling.  Added parity checking for CAN RAM.

State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (0 active, 0 completed*)