This is a list of all comments for HD-DEN-759-1. Review Summary: No summary General Comment by lbaloa on 14 November 2019, 13:04 https://devapps.diality.us/cru/HD-DEN-759-1#c261 Are we reviewing vector cast unit testing and integration testing? if that is the case, we are not doing it via text, are we? Reply by lbaloa on 15 November 2019, 10:10 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Common.h Revision Comment by pmontazemi on 05 December 2019, 08:42 https://devapps.diality.us/cru/HD-DEN-759-1#c474 Spaces between arithmetic sign and arguments, also did you want to add spaces between (v, l, and u)? If so, we need to do it everywhere in this code and everywhere else. Reply by Sean Nash on 06 December 2019, 07:44 > Agreed. Reply by pmontazemi on 10 December 2019, 16:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/AlarmLamp.c Revision Comment by pmontazemi on 14 November 2019, 11:37 https://devapps.diality.us/cru/HD-DEN-759-1#c222 Here it takes value "2", which corresponds to what? Reply by pmontazemi on 15 November 2019, 10:25 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by pmontazemi on 03 December 2019, 15:00 https://devapps.diality.us/cru/HD-DEN-759-1#c416 I would add a conversion factor equal to 1000. Reply by Sean Nash on 03 December 2019, 16:00 > Done. Reply by pmontazemi on 04 December 2019, 10:12 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 07 November 2019, 15:09 https://devapps.diality.us/cru/HD-DEN-759-1#c198 How do we know that these are the only parameters that are needed to sense and control the blood pump? Is this list planned to be changed? Reply by Sean Nash on 07 November 2019, 15:32 > This module is very preliminary. I don't have any feedback > from flow sensor or pump yet. States may be added, but I > don't currently see a need for any more. There will be a lot > more detail (possibly sub-states) needed in the "control to > target" state. Reply by pmontazemi on 08 November 2019, 13:21 > RESOLVED in CODE WALKTHROUGH. Revision Comment by lbaloa on 25 November 2019, 08:14 https://devapps.diality.us/cru/HD-DEN-759-1#c322 Wouldn't be simpler to have flow rate to be signed and have positive to be one direction and negative in another? Reply by Sean Nash on 25 November 2019, 08:26 > I considered that. The flow rate ultimately needs to be > converted to an unsigned PWM duty cycle for pump speed and a > direction signal to the motor controller. This seemed to be > a more natural way to achieve these ends. Also, with this > approach there is no ambiguity about which direction is being > commanded. Reply by lbaloa on 25 November 2019, 14:04 > RESOLVED IN CODE WALKTHROUGH Revision Comment by pmontazemi on 14 November 2019, 11:35 https://devapps.diality.us/cru/HD-DEN-759-1#c220 Can the "3" also be parameterized with an ALL CAPS name? I saw it somewhere else where it took the value "1". Reply by pmontazemi on 15 November 2019, 10:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:36 https://devapps.diality.us/cru/HD-DEN-759-1#c221 Here it is taking value "4". Reply by pmontazemi on 15 November 2019, 10:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 07 November 2019, 15:10 https://devapps.diality.us/cru/HD-DEN-759-1#c199 Do we foresee a scenario where the blood pump would be run in reverse? If not, we should lock the direction and not allow it to change. Reply by Sean Nash on 07 November 2019, 15:38 > I believe there will be during rinseback and possibly during > prime and de-prime sequences. Reply by pmontazemi on 08 November 2019, 13:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 03 December 2019, 15:00 https://devapps.diality.us/cru/HD-DEN-759-1#c417 Space between arithmetic signs. Reply by Sean Nash on 03 December 2019, 15:55 > This is debug code (per #ifdef). I guess I have a general > question of whether we want to enforce coding standards on > test/debug code? Reply by pmontazemi on 04 December 2019, 10:12 > Add TODO comment. Reply by Sean Nash on 04 December 2019, 15:11 > Done. Reply by pmontazemi on 06 December 2019, 10:10 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 07 November 2019, 15:11 https://devapps.diality.us/cru/HD-DEN-759-1#c200 How do we know the ramp rate? Is it fixed or parameterized? Reply by Sean Nash on 07 November 2019, 15:39 > It's just a placeholder for now. It's currently set so that > a 0 to 600 mL/min ramp will take 1 second. For the moment > it's fixed. Blaine said he may fix it in the motor > controller once we understand our needs better so firmware > may not have to worry about it in the end anyway. Reply by pmontazemi on 07 November 2019, 15:48 > Recommending adding this to the comments. Reply by pmontazemi on 08 November 2019, 13:16 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 05 December 2019, 08:36 https://devapps.diality.us/cru/HD-DEN-759-1#c471 I thought we agreed to have spaced between arguments and parentheses? Reply by Sean Nash on 05 December 2019, 08:45 > Fixed. Reply by pmontazemi on 06 December 2019, 10:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 05 December 2019, 08:36 https://devapps.diality.us/cru/HD-DEN-759-1#c472 I thought we agreed to have spaced between arguments and parentheses? Reply by Sean Nash on 06 December 2019, 07:45 > Done. Reply by pmontazemi on 06 December 2019, 10:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 05 December 2019, 08:36 https://devapps.diality.us/cru/HD-DEN-759-1#c473 I thought we agreed to have spaced between arguments and parentheses? Reply by Sean Nash on 05 December 2019, 08:43 > Sorry - must have changed a different line of code. Now > done. Reply by pmontazemi on 06 December 2019, 10:05 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Drivers/CPLD.c Revision Comment by lbaloa on 04 December 2019, 14:49 https://devapps.diality.us/cru/HD-DEN-759-1#c466 We should create a toggle macro for this. Also, do we have a min and max macro? Reply by Sean Nash on 04 December 2019, 14:57 > Done. And yes, we do have MIN and MAX macros in common.h. Reply by lbaloa on 06 December 2019, 10:12 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by pmontazemi on 14 November 2019, 11:38 https://devapps.diality.us/cru/HD-DEN-759-1#c227 Value "10", which is ...? Reply by pmontazemi on 15 November 2019, 10:24 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePrescription.c Revision Comment by pmontazemi on 03 December 2019, 15:01 https://devapps.diality.us/cru/HD-DEN-759-1#c418 Make this a constant that you call here. Reply by Sean Nash on 03 December 2019, 15:54 > This is temporary test code. Reply by pmontazemi on 04 December 2019, 10:11 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 03 December 2019, 15:01 https://devapps.diality.us/cru/HD-DEN-759-1#c419 Make this a constant you call here. Reply by Sean Nash on 03 December 2019, 15:53 > This is engineering code for running on eval board (per > #ifdef). I will remove the whole #ifdef at some point. Reply by pmontazemi on 04 December 2019, 10:10 > Then, please add a TODO comment (or similar). Reply by Sean Nash on 04 December 2019, 15:10 > Done. Reply by pmontazemi on 06 December 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeTreatment.c Revision Comment by pmontazemi on 03 December 2019, 15:01 https://devapps.diality.us/cru/HD-DEN-759-1#c420 Make this a constant you call here. Reply by Sean Nash on 03 December 2019, 15:51 > This is temporary test code (per comment). Reply by pmontazemi on 04 December 2019, 10:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/FPGA.c Revision Comment by pmontazemi on 14 November 2019, 11:42 https://devapps.diality.us/cru/HD-DEN-759-1#c244 Value "27", which is ...? Reply by pmontazemi on 15 November 2019, 10:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:42 https://devapps.diality.us/cru/HD-DEN-759-1#c245 Value "28", which is ...? Reply by pmontazemi on 15 November 2019, 10:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:56 https://devapps.diality.us/cru/HD-DEN-759-1#c326 General coding standard: space between arithmetic signs... Reply by Sean Nash on 25 November 2019, 15:10 > Done. Reply by pmontazemi on 26 November 2019, 16:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:57 https://devapps.diality.us/cru/HD-DEN-759-1#c327 Space between arithmetic sign and arguments. Reply by Sean Nash on 25 November 2019, 15:09 > Done. Reply by pmontazemi on 26 November 2019, 16:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 07 November 2019, 15:15 https://devapps.diality.us/cru/HD-DEN-759-1#c201 How did this compile? Reply by Sean Nash on 07 November 2019, 15:28 > A compound statement body does not need an if or while or for > or anything - it can stand alone. That said, I temporarily > commented out the check because the FPGA protocol changed and > I haven't caught up with it yet so this test was failing. Reply by pmontazemi on 08 November 2019, 13:12 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:42 https://devapps.diality.us/cru/HD-DEN-759-1#c246 Value "29", which is ...? Reply by pmontazemi on 15 November 2019, 10:16 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:42 https://devapps.diality.us/cru/HD-DEN-759-1#c247 Value "30", which is ...? Reply by pmontazemi on 15 November 2019, 10:16 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:42 https://devapps.diality.us/cru/HD-DEN-759-1#c248 Value "31", which is ...? Reply by pmontazemi on 15 November 2019, 10:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:42 https://devapps.diality.us/cru/HD-DEN-759-1#c249 Value "32", which is ...? Reply by Sean Nash on 14 November 2019, 12:36 > These s/w faults will be all over the place. For logging > purposes, I wanted to be able to determine which specific s/w > fault was triggered and why. So I'm triggering the fault > with 2 alarm data elements. First is a unique s/w fault # so > I can go find it in the code. The Second is the value that > caused the fault so I can know what the s/w saw when the > fault was triggered. I'm open to suggestions on the unique # > parameter. I could make (and maintain) a large enum for all > of the s/w fault scenarios. Reply by pmontazemi on 15 November 2019, 10:15 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/source/sys_main.c Revision Comment by pmontazemi on 14 November 2019, 13:00 https://devapps.diality.us/cru/HD-DEN-759-1#c257 Why are there two sys_main.c? How is that even allowed by the OS and Bitbucket/Bamboo? Reply by Dara Navaei on 20 November 2019, 10:06 > The other sys_main.c was outdated and I deleted it. Reply by pmontazemi on 20 November 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Drivers/InternalADC.c Revision Comment by pmontazemi on 14 November 2019, 11:38 https://devapps.diality.us/cru/HD-DEN-759-1#c225 Value "8", which is ...? Reply by pmontazemi on 15 November 2019, 10:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:38 https://devapps.diality.us/cru/HD-DEN-759-1#c226 Value "9", which is ...? Reply by pmontazemi on 15 November 2019, 10:24 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/Release/App/Controllers/subdir_rules.mk Revision Comment by pmontazemi on 11 November 2019, 12:56 https://devapps.diality.us/cru/HD-DEN-759-1#c217 Why were all these *.mk files removed from the repo? More importantly, how and why were they created to being with? Reply by Sean Nash on 11 November 2019, 17:48 > I fixed issue with release build that Dara brought up. In > doing so, a new "release" folder was created when I did a > build and got committed with the fix. I checked my > .gitignore and saw that the "debug" folder was ignored so I > removed the "release" folder before pushing. For some > reason, I still see the "debug" folder in my git repo so > maybe the .gitignore isn't even working. Reply by Dara Navaei on 12 November 2019, 10:50 > The Debug and Release folders will be removed from the > repository by removing them from the git commit list and > then .gitignore will be effective. We do not need to keep > them in the remote repository. We also had to make sure > that we can both build in Debug and Release mode with no > issues. Reply by pmontazemi on 15 November 2019, 10:26 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by pmontazemi on 11 December 2019, 14:16 https://devapps.diality.us/cru/HD-DEN-759-1#c542 Spaces between 0s. Reply by pmontazemi on 12 December 2019, 10:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 03 December 2019, 15:04 https://devapps.diality.us/cru/HD-DEN-759-1#c421 What is the difference between UI is communicating and UI did communicate? Reply by Sean Nash on 03 December 2019, 15:48 > uiDidCommunicate is latched. It is useful to know that UI > came up and was communicating at some time. > uiIsCommunicating is cleared when the getter function is > called so the UI has to keep communicating to set the flag > again and again (like a comm watchdog). Reply by pmontazemi on 04 December 2019, 10:09 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:58 https://devapps.diality.us/cru/HD-DEN-759-1#c328 Space between arithmetic signs and arguments. Reply by Sean Nash on 25 November 2019, 15:06 > Done. Reply by pmontazemi on 26 November 2019, 16:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by pmontazemi on 25 November 2019, 14:58 https://devapps.diality.us/cru/HD-DEN-759-1#c329 Space between arithmetic signs and arguments. Reply by Sean Nash on 25 November 2019, 15:07 > Done. Reply by pmontazemi on 26 November 2019, 16:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 03 December 2019, 10:55 https://devapps.diality.us/cru/HD-DEN-759-1#c409 Why did we disable the msg to UI? Reply by Sean Nash on 03 December 2019, 13:17 > Was waiting for Behrouz to update UI side to accept payload > change (from empty to confirm/cancel byte). Behrouz updated > UI this morning so I've un-commented the payload change. Reply by pmontazemi on 04 December 2019, 10:13 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:58 https://devapps.diality.us/cru/HD-DEN-759-1#c330 Space between arithmetic signs and arguments. Reply by pmontazemi on 26 November 2019, 16:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:59 https://devapps.diality.us/cru/HD-DEN-759-1#c331 Space between arithmetic signs and arguments. Reply by Sean Nash on 25 November 2019, 15:08 > Done. Reply by pmontazemi on 26 November 2019, 16:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:59 https://devapps.diality.us/cru/HD-DEN-759-1#c332 Space between arithmetic signs and arguments. Reply by Sean Nash on 25 November 2019, 15:05 > Done. Reply by pmontazemi on 26 November 2019, 16:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/AlarmMgmt.c Revision Comment by pmontazemi on 26 November 2019, 16:01 https://devapps.diality.us/cru/HD-DEN-759-1#c371 What is FAUL? Reply by Sean Nash on 26 November 2019, 16:46 > Short for fault mode. Due to formatting, it was useful to > keep all mode enums at same length - so abbreviated to four > letters. Reply by pmontazemi on 26 November 2019, 16:48 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:40 https://devapps.diality.us/cru/HD-DEN-759-1#c232 Value "15", which is ...? Reply by pmontazemi on 15 November 2019, 10:22 > Explicitly explain "0", 1, or 2, ... Reply by pmontazemi on 20 November 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 25 November 2019, 14:52 https://devapps.diality.us/cru/HD-DEN-759-1#c325 What is the 2 for? Reply by Sean Nash on 25 November 2019, 15:12 > Macro is for when you have 2 unsigned 32-bit data values that > you want logged with the triggered alarm. Reply by pmontazemi on 26 November 2019, 16:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:40 https://devapps.diality.us/cru/HD-DEN-759-1#c233 Value "16", which is ...? Reply by pmontazemi on 15 November 2019, 10:22 > Explicitly explain in words, 0, 1, 2, ... Reply by pmontazemi on 20 November 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:40 https://devapps.diality.us/cru/HD-DEN-759-1#c234 Value "17", which is ...? Reply by pmontazemi on 15 November 2019, 10:21 > Explicitly explain 0, 1, and 2 in words. Reply by pmontazemi on 20 November 2019, 10:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:40 https://devapps.diality.us/cru/HD-DEN-759-1#c235 Value "18", which is ...? Reply by pmontazemi on 15 November 2019, 10:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 06 December 2019, 08:33 https://devapps.diality.us/cru/HD-DEN-759-1#c505 What is the rule for arguments between [ ] ? Does it need spacing like ( ) ? Reply by pmontazemi on 10 December 2019, 16:43 > In group setting, decision was made to use the () rules > applied to []. Reply by pmontazemi on 12 December 2019, 10:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:40 https://devapps.diality.us/cru/HD-DEN-759-1#c236 Value "19", which is ...? Reply by pmontazemi on 15 November 2019, 10:19 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/AlarmMgmt.h Revision Comment by Behrouz NematiPour on 03 December 2019, 15:47 https://devapps.diality.us/cru/HD-DEN-759-1#c425 In general, I would explicitly assign numbers to enums and also categorizing them and put a little gap between each category. Reply by Sean Nash on 03 December 2019, 17:48 > My intent is to just have a unique ID for each alarm. It's > kind of like assigning a trace # to a requirement in an SRS. > It's too much trouble to try to keep them in order - you just > assign #s as you write them. > I could assign #s to each or comment w/ # to right of each. Reply by Behrouz NematiPour on 04 December 2019, 10:23 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Behrouz NematiPour on 03 December 2019, 15:49 https://devapps.diality.us/cru/HD-DEN-759-1#c427 In general, I would explicitly assign numbers to enums and also categorizing them and put a little gap between each category. Reply by Sean Nash on 03 December 2019, 17:52 > Same. Reply by Behrouz NematiPour on 04 December 2019, 10:23 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/Buttons.c Revision Comment by pmontazemi on 04 December 2019, 10:06 https://devapps.diality.us/cru/HD-DEN-759-1#c451 Space between arithmetic signs. Reply by Sean Nash on 04 December 2019, 15:09 > Done. Reply by pmontazemi on 06 December 2019, 10:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:37 https://devapps.diality.us/cru/HD-DEN-759-1#c223 Here it takes value "6", which is ...? Reply by pmontazemi on 15 November 2019, 10:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by lbaloa on 04 December 2019, 10:15 https://devapps.diality.us/cru/HD-DEN-759-1#c462 I would suggest using && operator to reduce complexity of code Reply by lbaloa on 04 December 2019, 10:17 > RESOLVED IN CODE WALKTHROUGH. THIS WOULD BE THE PREFERRED > WAY OF DOING IF. Revision Comment by pmontazemi on 14 November 2019, 11:37 https://devapps.diality.us/cru/HD-DEN-759-1#c224 Value "7", which is ...? Reply by pmontazemi on 15 November 2019, 10:25 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/OperationModes.c Revision Comment by pmontazemi on 14 November 2019, 11:39 https://devapps.diality.us/cru/HD-DEN-759-1#c228 Value "11", which is ...? Reply by pmontazemi on 15 November 2019, 10:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:39 https://devapps.diality.us/cru/HD-DEN-759-1#c229 Value "12", which is ...? Reply by pmontazemi on 15 November 2019, 10:23 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:39 https://devapps.diality.us/cru/HD-DEN-759-1#c230 Value "13", which is ...? Reply by pmontazemi on 15 November 2019, 10:23 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:39 https://devapps.diality.us/cru/HD-DEN-759-1#c231 Value 14, which is ...? Reply by pmontazemi on 15 November 2019, 10:23 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/CommBuffers.c Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c237 Value "20", which is ...? Reply by pmontazemi on 15 November 2019, 10:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c238 Value "21", which is ...? Reply by pmontazemi on 15 November 2019, 10:18 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c239 Value "22", which is ...? Reply by pmontazemi on 15 November 2019, 10:18 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c240 Value "23", which is ...? Reply by pmontazemi on 15 November 2019, 10:18 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c241 Value "24", which is ...? Reply by pmontazemi on 15 November 2019, 10:18 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c242 Value "25", which is ...? Reply by pmontazemi on 15 November 2019, 10:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 11:41 https://devapps.diality.us/cru/HD-DEN-759-1#c243 Value "26", which is ...? Reply by pmontazemi on 15 November 2019, 10:17 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/MsgQueues.c Revision Comment by pmontazemi on 14 November 2019, 12:56 https://devapps.diality.us/cru/HD-DEN-759-1#c251 Value "33", which is ...? Reply by pmontazemi on 15 November 2019, 10:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 12:57 https://devapps.diality.us/cru/HD-DEN-759-1#c252 Value "34", which is ...? Reply by pmontazemi on 15 November 2019, 10:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 12:57 https://devapps.diality.us/cru/HD-DEN-759-1#c253 Value "35", which is ...? Reply by pmontazemi on 15 November 2019, 10:14 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 12:57 https://devapps.diality.us/cru/HD-DEN-759-1#c254 Value "36", which is ...? Reply by pmontazemi on 15 November 2019, 10:13 > RESOLVED in CODE WALKTHROUGH. Revision Comment by pmontazemi on 14 November 2019, 12:57 https://devapps.diality.us/cru/HD-DEN-759-1#c255 Value "37", which is ...? Reply by pmontazemi on 15 November 2019, 10:13 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/WatchdogMgmt.c Revision Comment by pmontazemi on 14 November 2019, 12:58 https://devapps.diality.us/cru/HD-DEN-759-1#c256 Value "38", which is ...? Reply by pmontazemi on 15 November 2019, 10:13 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: vectorcast/Hercules_RM46_HD_Project/python/file_hooks.pyc Revision Comment by pmontazemi on 14 November 2019, 13:02 https://devapps.diality.us/cru/HD-DEN-759-1#c259 There is no need to check in *.pyc files, these are compiled Python files at run time. Reply by pmontazemi on 15 November 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: vectorcast/Hercules_RM46_HD_Project/python/setup_teardown.pyc Revision Comment by pmontazemi on 14 November 2019, 13:02 https://devapps.diality.us/cru/HD-DEN-759-1#c260 There is no need to check in *.pyc files, these are compiled Python files at run time. Reply by pmontazemi on 15 November 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Drivers/Comm.c Revision Comment by Dara Navaei on 23 November 2019, 16:51 https://devapps.diality.us/cru/HD-DEN-759-1#c320 Was this created by VectorCAST directly? Reply by Sean Nash on 24 November 2019, 20:22 > This was something I temporarily added to handle the problem > of trying to access RM46 registers while running in MinGW > where such an attempt would cause a memory access error and > crash the test case. Jim from VC finally gave me a way to do > this from inside VC so I don't have to add this code - so > I've since removed it. Reply by Dara Navaei on 26 November 2019, 16:45 > RESOLVED in CODE WALKTHROUGH ---------------------------------------- File: firmware/irqDispatch_c.c Revision Comment by pmontazemi on 26 November 2019, 16:04 https://devapps.diality.us/cru/HD-DEN-759-1#c372 Is this Diality file or TI file? Reply by Sean Nash on 26 November 2019, 16:44 > It's a TI example file. No copyright on it. And we've > customized it a little, so decision made to absorb it as our > own. Reply by pmontazemi on 26 November 2019, 16:48 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Tasks/TaskPriority.h Revision Comment by pmontazemi on 03 December 2019, 15:06 https://devapps.diality.us/cru/HD-DEN-759-1#c422 Is there value in parameterizing this number? Reply by Sean Nash on 03 December 2019, 15:42 > Some functions executed from a given task may want to know > how often they are being called - so I provide this > definition. From RTI registers I could get a clock divider > value and somehow derive the timing from it, but that would > be pretty complex as even those values depend on other > general clock settings. Reply by pmontazemi on 04 December 2019, 10:08 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-759-1 https://devapps.diality.us/cru/HD-DEN-759-1 Title: HD-DEN-759_BloodFlow Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (0 active, 4 completed*) Dara Navaei (*) Behrouz NematiPour (*) pmontazemi (*) lbaloa (*)