This is a list of all comments for HD-DEN-8030-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by qnguyen on 21 June 2021, 23:23 https://devapps.diality.us/cru/HD-DEN-8030-1#c10308 Do we need to do something with the payload? Reply by Dara Navaei on 24 June 2021, 09:46 > I added the rest of the code. Reply by qnguyen on 25 June 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by qnguyen on 28 June 2021, 11:16 https://devapps.diality.us/cru/HD-DEN-8030-1#c10338 Remove this one. This has been handled at line 1679. Reply by Dara Navaei on 01 July 2021, 09:02 > Done Reply by qnguyen on 07 July 2021, 10:45 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemCommMessages.h Revision Comment by qnguyen on 02 July 2021, 09:59 https://devapps.diality.us/cru/HD-DEN-8030-1#c10345 Should we rename this message ID? The name does not seems to match the broadcast function. Reply by Dara Navaei on 05 July 2021, 19:27 > Done Reply by qnguyen on 07 July 2021, 10:45 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by Sean Nash on 28 June 2021, 08:50 https://devapps.diality.us/cru/HD-DEN-8030-1#c10334 Add blank lines after declarations. Reply by Dara Navaei on 01 July 2021, 08:58 > Done Reply by Sean Nash on 07 July 2021, 10:44 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 June 2021, 08:52 https://devapps.diality.us/cru/HD-DEN-8030-1#c10335 When are these commandIDs set to anything else? Reply by qnguyen on 28 June 2021, 10:25 > This resets any previous command response that has not been > processed for this specific command. Reply by Dara Navaei on 06 July 2021, 22:02 > I will address this comment in DEN-9054 (switches) branch. Reply by Sean Nash on 07 July 2021, 10:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by qnguyen on 21 June 2021, 23:10 https://devapps.diality.us/cru/HD-DEN-8030-1#c10302 Recommend breaking each state handler into a function. Reply by Dara Navaei on 25 June 2021, 09:03 > Done Reply by qnguyen on 25 June 2021, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 01 July 2021, 11:23 https://devapps.diality.us/cru/HD-DEN-8030-1#c10343 Why deleted? Reply by Dara Navaei on 04 July 2021, 14:20 > I had a similar function for this. Reply by Sean Nash on 07 July 2021, 10:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 21 June 2021, 23:14 https://devapps.diality.us/cru/HD-DEN-8030-1#c10303 Do we need DG to be in standby mode also? Reply by Dara Navaei on 24 June 2021, 09:53 > DG will reject staring any of the disinfects if it is not in > the right mode. Reply by qnguyen on 25 June 2021, 10:33 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 21 June 2021, 23:15 https://devapps.diality.us/cru/HD-DEN-8030-1#c10304 Mismatch description. Reply by Dara Navaei on 24 June 2021, 09:50 > Done Reply by qnguyen on 25 June 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by qnguyen on 21 June 2021, 23:15 https://devapps.diality.us/cru/HD-DEN-8030-1#c10305 Mismatch description. Reply by Dara Navaei on 24 June 2021, 09:50 > Done Reply by qnguyen on 25 June 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/TreatmentEnd.c Revision Comment by qnguyen on 21 June 2021, 23:19 https://devapps.diality.us/cru/HD-DEN-8030-1#c10306 Change the alarm to ALARM_ID_TREATMENT_STOPPED_NO_RINSEBACK. Reply by Dara Navaei on 24 June 2021, 09:49 > Done Reply by qnguyen on 25 June 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/TreatmentStop.c Revision Comment by qnguyen on 21 June 2021, 23:20 https://devapps.diality.us/cru/HD-DEN-8030-1#c10307 Change the alarm to ALARM_ID_TREATMENT_STOPPED_NO_RINSEBACK Reply by Dara Navaei on 24 June 2021, 09:48 > Done Reply by qnguyen on 25 June 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by Sean Nash on 28 June 2021, 08:57 https://devapps.diality.us/cru/HD-DEN-8030-1#c10336 Why do all of these POST tests have these #ifdefs? They don't appear to have anything to do with NV POST. Reply by Dara Navaei on 01 July 2021, 08:59 > The #ifdefs are for making sure NV POST and all the other > POSTs that necessary like the HD valves are done but the rest > are skipped. Reply by Sean Nash on 07 July 2021, 10:44 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-8030-1 https://devapps.diality.us/cru/HD-DEN-8030-1 Title: DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (1 active, 2 completed*) qnguyen (*) Sean Nash (*) pmontazemi