This is a list of all comments for HD-DEN-8534-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Fans.c
Revision Comment by qnguyen on 11 August 2021, 10:10 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10620

  Should be HD FAN alarm

  Reply by Dara Navaei on 11 August 2021, 16:54
  > Done.

    Reply by qnguyen on 13 August 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 August 2021, 11:15 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10633

  We would want target RPM, RPM from tach, and PWM published.

  Reply by Dara Navaei on 12 August 2021, 15:03
  > Done.

    Reply by Sean Nash on 13 August 2021, 10:34
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Temperatures.c
Revision Comment by qnguyen on 11 August 2021, 10:11 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10622

  Wrong alarm id.

  Reply by Dara Navaei on 11 August 2021, 16:58
  > Done.

    Reply by qnguyen on 13 August 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 August 2021, 11:20 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10634

  Make this a declaration and remove declaration above loop.

  Reply by Dara Navaei on 12 August 2021, 15:04
  > Done.

    Reply by Sean Nash on 13 August 2021, 10:34
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by qnguyen on 11 August 2021, 10:11 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10621

  Wrong alarm id.

  Reply by Dara Navaei on 11 August 2021, 17:00
  > Done.

    Reply by qnguyen on 13 August 2021, 10:35
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Tasks/TaskGeneral.c
Revision Comment by Sean Nash on 12 August 2021, 11:33 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10637

  Move switch and temp monitors up above execOperationModes().

  Reply by Dara Navaei on 12 August 2021, 15:08
  > Done.

    Reply by Sean Nash on 13 August 2021, 10:33
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.h
Revision Comment by Sean Nash on 12 August 2021, 11:31 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10636

  ModeStandby.h already included above.  Keep list alphabetized.

  Reply by Dara Navaei on 12 August 2021, 15:07
  > Done. I always try to keep them alphabetized.

    Reply by Sean Nash on 13 August 2021, 10:33
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/Fans.h
Revision Comment by qnguyen on 11 August 2021, 10:09 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10618

  It should be HD fans.

  Reply by Dara Navaei on 11 August 2021, 16:55
  > Done.

    Reply by qnguyen on 13 August 2021, 10:36
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by qnguyen on 11 August 2021, 10:10 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10619

  HD_fans

  Reply by Dara Navaei on 11 August 2021, 16:54
  > Done.

    Reply by qnguyen on 13 August 2021, 10:36
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/TreatmentEnd.c
Revision Comment by qnguyen on 11 August 2021, 10:08 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10617

  Change it to ALARM_ID_TREATMENT_STOPPED_NO_RINSEBACK.

  Reply by Dara Navaei on 11 August 2021, 16:56
  > Done.

    Reply by qnguyen on 13 August 2021, 10:39
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/TreatmentStop.c
Revision Comment by Sean Nash on 12 August 2021, 11:28 
https://devapps.diality.us/cru/HD-DEN-8534-1#c10635

  Maybe renamed.  Should not be removed.

  Reply by Dara Navaei on 12 August 2021, 15:06
  > Done.

    Reply by Sean Nash on 13 August 2021, 10:33
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-8534-1 https://devapps.diality.us/cru/HD-DEN-8534-1

Title: HD-DEN-8534_HD Dev Fan Driver
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (1 active, 2 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     pmontazemi