This is a list of all comments for HD-DEN-9480-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/Valves.c Revision Comment by Sean Nash on 09 November 2021, 13:38 https://devapps.diality.us/cru/HD-DEN-9480-1#c11174 Align comment. Reply by Dara Navaei on 09 November 2021, 20:40 > Done. Reply by Sean Nash on 10 November 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. Revision Comment by hnguyen on 10 November 2021, 18:20 https://devapps.diality.us/cru/HD-DEN-9480-1#c11304 Update @details Inputs, and @detail Outputs as shown below: @detail Inputs: None @detail Outputs: valveSeftTestState, valveSeftTestResult, valveAirTrapStatus, valvesControlSetBits, valvesStatus Reply by Dara Navaei on 10 November 2021, 22:19 > Done. Reply by hnguyen on 11 November 2021, 10:45 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:26 https://devapps.diality.us/cru/HD-DEN-9480-1#c11305 Remove valvesStatus from @details Inputs. Reply by Dara Navaei on 10 November 2021, 22:18 > Done. Reply by hnguyen on 11 November 2021, 10:45 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:26 https://devapps.diality.us/cru/HD-DEN-9480-1#c11306 Remove valvesStatus from @details Inputs. Reply by Dara Navaei on 10 November 2021, 22:17 > Done. Reply by hnguyen on 11 November 2021, 10:44 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 09 November 2021, 13:39 https://devapps.diality.us/cru/HD-DEN-9480-1#c11175 What is the status of this line of code? Are we removing it or keeping it? Reply by Dara Navaei on 09 November 2021, 20:40 > Removed the code. Reply by Sean Nash on 10 November 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. Revision Comment by hnguyen on 10 November 2021, 18:28 https://devapps.diality.us/cru/HD-DEN-9480-1#c11307 valvesStatus should be in Inputs not Outputs Reply by Dara Navaei on 10 November 2021, 22:17 > It is not used for any decision making so it is only output. Reply by hnguyen on 11 November 2021, 10:44 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:29 https://devapps.diality.us/cru/HD-DEN-9480-1#c11308 valvesStatus should be in Inputs not Outputs Reply by Dara Navaei on 10 November 2021, 22:15 > It has to be input and output. Reply by hnguyen on 11 November 2021, 10:43 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:30 https://devapps.diality.us/cru/HD-DEN-9480-1#c11309 I do not see in this function where you read from valveAirTrapStatus. Remove it from @details Inputs. Reply by Dara Navaei on 10 November 2021, 21:52 > Done. Reply by hnguyen on 11 November 2021, 10:43 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:33 https://devapps.diality.us/cru/HD-DEN-9480-1#c11310 @details Inputs: should be none Reply by Dara Navaei on 10 November 2021, 21:50 > Done. Reply by hnguyen on 11 November 2021, 10:43 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:34 https://devapps.diality.us/cru/HD-DEN-9480-1#c11311 @details Outputs: valvesSelfTestResult, valvesStatus Reply by Dara Navaei on 10 November 2021, 21:50 > Done. Reply by hnguyen on 11 November 2021, 10:43 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:35 https://devapps.diality.us/cru/HD-DEN-9480-1#c11312 should be none in Inputs: Reply by Dara Navaei on 10 November 2021, 21:40 > Done. Reply by hnguyen on 11 November 2021, 10:43 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:36 https://devapps.diality.us/cru/HD-DEN-9480-1#c11313 remove valveSeftTestState from Inputs and put it in Outputs. Reply by Dara Navaei on 10 November 2021, 21:38 > This is actually an input because it is used to make a > decision. Reply by hnguyen on 11 November 2021, 10:43 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 09 November 2021, 13:40 https://devapps.diality.us/cru/HD-DEN-9480-1#c11176 What is the status of these commented out lines of code? Are we removing or keeping? Reply by Dara Navaei on 09 November 2021, 20:44 > I removed it. Reply by Sean Nash on 10 November 2021, 10:59 > RESOLVED in CODE WALKTHROUGH. Revision Comment by hnguyen on 10 November 2021, 18:41 https://devapps.diality.us/cru/HD-DEN-9480-1#c11314 Remove 2nd and 3rd variables from Inputs Reply by Dara Navaei on 10 November 2021, 21:37 > Done. Reply by hnguyen on 11 November 2021, 10:42 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:45 https://devapps.diality.us/cru/HD-DEN-9480-1#c11316 Remove valvesControlStatusBits from Inputs since it is not being used in this function Reply by Dara Navaei on 10 November 2021, 21:34 > Done. Reply by hnguyen on 11 November 2021, 10:42 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:43 https://devapps.diality.us/cru/HD-DEN-9480-1#c11315 Spelling error VALVE_CONTORL Reply by Dara Navaei on 10 November 2021, 21:35 > Done. Reply by hnguyen on 11 November 2021, 10:42 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:45 https://devapps.diality.us/cru/HD-DEN-9480-1#c11317 Incorrect function name here. Reply by Dara Navaei on 10 November 2021, 21:33 > Done. Reply by hnguyen on 11 November 2021, 10:42 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:48 https://devapps.diality.us/cru/HD-DEN-9480-1#c11318 Remove valvesStatus from Inputs since the code where it used as Inputs is commented out Reply by Dara Navaei on 10 November 2021, 21:27 > Done. Reply by hnguyen on 11 November 2021, 10:41 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:49 https://devapps.diality.us/cru/HD-DEN-9480-1#c11319 Inputs should be none Reply by Dara Navaei on 10 November 2021, 21:25 > Done. Reply by hnguyen on 11 November 2021, 10:41 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:52 https://devapps.diality.us/cru/HD-DEN-9480-1#c11320 Remove valvesPostionOverride from Inputs Reply by Dara Navaei on 10 November 2021, 21:24 > Done. Reply by hnguyen on 11 November 2021, 10:41 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:54 https://devapps.diality.us/cru/HD-DEN-9480-1#c11321 Replace both Inputs and Outputs with valvesPostionOverride. Reply by Dara Navaei on 10 November 2021, 21:23 > Done. Reply by hnguyen on 11 November 2021, 10:41 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:54 https://devapps.diality.us/cru/HD-DEN-9480-1#c11322 Remove valvesStatus from Inputs Reply by Dara Navaei on 10 November 2021, 21:22 > Done. Reply by hnguyen on 11 November 2021, 10:41 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 18:55 https://devapps.diality.us/cru/HD-DEN-9480-1#c11323 Remove valvesPostionOverride from both Inputs and Outputs Reply by Dara Navaei on 10 November 2021, 21:21 > Done. Reply by hnguyen on 11 November 2021, 10:40 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModeInitPOST.c Revision Comment by Sean Nash on 09 November 2021, 13:37 https://devapps.diality.us/cru/HD-DEN-9480-1#c11171 Need to restore this code. Reply by Dara Navaei on 09 November 2021, 20:38 > Done. Reply by Sean Nash on 10 November 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 09 November 2021, 13:38 https://devapps.diality.us/cru/HD-DEN-9480-1#c11173 Need to restore this code. Reply by Dara Navaei on 09 November 2021, 20:39 > Done. Reply by Sean Nash on 10 November 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. Revision Comment by hnguyen on 10 November 2021, 18:58 https://devapps.diality.us/cru/HD-DEN-9480-1#c11324 Add dgPOSTResultReceived in Outputs Reply by Dara Navaei on 10 November 2021, 21:16 > Done. Reply by hnguyen on 11 November 2021, 10:40 > RESOLVED IN CODE WALKTHROUGH Revision Comment by hnguyen on 10 November 2021, 19:00 https://devapps.diality.us/cru/HD-DEN-9480-1#c11325 remove postPassed Reply by Dara Navaei on 10 November 2021, 21:15 > Done. Reply by hnguyen on 11 November 2021, 10:40 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Services/SystemCommMessages.c Revision Comment by Sean Nash on 09 November 2021, 13:37 https://devapps.diality.us/cru/HD-DEN-9480-1#c11170 Why do I not see a call to this function in SystemComm.c? Reply by Dara Navaei on 09 November 2021, 20:33 > I added the command. Reply by Sean Nash on 10 November 2021, 11:00 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 09 November 2021, 13:33 https://devapps.diality.us/cru/HD-DEN-9480-1#c11169 Either testSetStopRTC() should return a BOOL and set result to that BOOL or you need to just set result to TRUE in this if scope - otherwise the Ack sent below will always be a Nak. Reply by Dara Navaei on 09 November 2021, 20:35 > Fixed the code. Reply by Sean Nash on 10 November 2021, 11:01 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-9480-1 https://devapps.diality.us/cru/HD-DEN-9480-1 Title: HD-DEN-9480_DG_DEV Dialysate Temperature Control Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (1 active, 2 completed*) Sean Nash (*) hnguyen (*) Behrouz NematiPour