This is a list of all comments for HD-DENBUG-326-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/SyringePump.c
Revision Comment by Sean Nash on 22 September 2025, 11:15 
https://devapps.diality.us/cru/HD-DENBUG-326-1#c24411

  These should be initialized to zero in init function.

Revision Comment by Sean Nash on 10 September 2025, 09:47 
https://devapps.diality.us/cru/HD-DENBUG-326-1#c24187

  We are only debouncing the transition from detected to not
  detected (syringe removal).  Is that our design intent?

  Reply by Sean Nash on 03 November 2025, 16:40
  > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 September 2025, 11:17 
https://devapps.diality.us/cru/HD-DENBUG-326-1#c24413

  How is this if different than the else above?  I don't think we
  need a separate if/else for not detected debounce - everything
  can be done in the if/else above.


---

ID: HD-DENBUG-326-1 https://devapps.diality.us/cru/HD-DENBUG-326-1

Title: HD-DENBUG-326_Syringe Switch Detection Failure Staging
Statement of Objectives:


State: Review

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 0 completed*)
     Sean Nash
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Daniel Ho