This is a list of all comments for HD-DENBUG-59-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/HDCommon.h
Revision Comment by Darren Cox on 10 August 2023, 11:41 
https://devapps.diality.us/cru/HD-DENBUG-59-1#c18536

  Remove commented / unused code. If it is to be used, it does
  not check for overflow.

  Reply by Sean Nash on 11 August 2023, 09:33
  > Removed.

    Reply by Darren Cox on 24 August 2023, 13:31
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: AlarmDefs.h
Revision Comment by wbracken on 09 August 2023, 15:21 
https://devapps.diality.us/cru/HD-DENBUG-59-1#c18521

  DGFault instead of Dfault

  Reply by Sean Nash on 11 August 2023, 09:30
  > Fixed.

    Reply by wbracken on 11 August 2023, 10:24
    > RESOLVED IN CODE WALKTHROUGH


---

ID: HD-DENBUG-59-1 https://devapps.diality.us/cru/HD-DENBUG-59-1

Title: HD-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (4 active, 2 completed*)
     wbracken   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Darren Cox
     Steve Jarpe