This is a list of all comments for HD-SPRINT16-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemCommMessages.h
Revision Comment by pmontazemi on 22 April 2020, 12:50 
https://devapps.diality.us/cru/HD-SPRINT16-1#c1619

  Add space.

  Reply by Sean Nash on 22 April 2020, 16:33
  > Done.

    Reply by pmontazemi on 23 April 2020, 10:32
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/HDCommon.h
Revision Comment by pmontazemi on 22 April 2020, 12:51 
https://devapps.diality.us/cru/HD-SPRINT16-1#c1620

  Remove commented lines.

  Reply by Sean Nash on 22 April 2020, 16:30
  > All of these "engineering" build flags are sometimes
  > commented/uncommented depending on what we're building for.
  > e.g. RM46_EVAL_BOARD_TARGET is uncommented when I need to
  > make a build for Behrouz to test on his eval board.  As the
  > need for some of these goes away, I remove them.

    Reply by pmontazemi on 22 April 2020, 16:38
    > We should use the build server combined with the build
    > flags to build whatever is needed. Is the diversity of the
    > various builds that great? My understanding is P-BB (v0.3,
    > same as evel kit), P-BETA (v0.4), P-DVT (v0.7), and
    > P-RELEASE (v1.0).

      Reply by Sean Nash on 22 April 2020, 16:46
      > Those are for master branch builds.  I use these build
      > flags for engineering builds from my working branch.

        Reply by pmontazemi on 23 April 2020, 10:32
        > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-SPRINT16-1 https://devapps.diality.us/cru/HD-SPRINT16-1

Title: HD-SPRINT16
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (0 active, 2 completed*)
     Dara Navaei   (*)
     pmontazemi   (*)