This is a list of all comments for LEAHI-APPLICATION-LDT-1209-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/pages/treatment/sections/TreatmentFlows.qml Revision Comment by Behrouz NematiPour on 11 July 2025, 15:43 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22934 The following: {code} Variables.notSetVariable(vTreatmentSetPoint.bloodFlow) {code} need to change to: {code} Variables.notSetVariable(vTreatmentSetPoint.bloodFlow.toFixed(0)) {code} or (most probably the above is the correct one, but in case) {code} Variables.notSetVariable(vTreatmentSetPoint.bloodFlow).toFixed(0) {code} and does not need the === Reply by Nicholas Ramirez on 11 July 2025, 16:25 > updated Reply by Behrouz NematiPour on 11 July 2025, 17:11 > RESOLVED Revision Comment by Behrouz NematiPour on 15 July 2025, 09:06 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22960 Please refactor any structure, model, view, qml object, usage of TreatmentSetPoint (the naming is too general and confusing) to TreatmentParametersSetPoint. And please test with the simulator to ensure it is working as expected. Reply by Nicholas Ramirez on 15 July 2025, 10:32 > Updated all files to reflect the name change Reply by Behrouz NematiPour on 21 July 2025, 18:52 > RESOLVED. Revision Comment by Behrouz NematiPour on 11 July 2025, 15:47 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22935 To align, do it like the following: {code} extraText : vTreatmentSetPoint.dialysateFlow === 0 || vTDTreatmentStates.txIsolatedUf ? qsTr("OFF" ) : ! vDDGenDialysate.isDialGood ? qsTr("Bypass") : "" {code} Reply by Nicholas Ramirez on 11 July 2025, 16:26 > updated Reply by Behrouz NematiPour on 11 July 2025, 17:19 > RESOLVED Revision Comment by Behrouz NematiPour on 11 July 2025, 15:50 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22936 same Reply by Nicholas Ramirez on 11 July 2025, 16:26 > updated Reply by Behrouz NematiPour on 11 July 2025, 17:19 > RESOLVED Revision Comment by Behrouz NematiPour on 11 July 2025, 15:51 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22937 Same Reply by Nicholas Ramirez on 11 July 2025, 16:26 > updated Reply by Behrouz NematiPour on 11 July 2025, 17:20 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/sections/TreatmentFlowsComponent.qml Revision Comment by Behrouz NematiPour on 11 July 2025, 15:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22938 Remove for now. Or any extra animation or UI cosmetics that are not a requirement. Reply by Nicholas Ramirez on 11 July 2025, 16:26 > removed Reply by Behrouz NematiPour on 11 July 2025, 17:11 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/sections/TreatmentPressures.qml Revision Comment by Behrouz NematiPour on 11 July 2025, 16:00 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22939 Please refactor this property. Properties should not start with a Capital letter. Do the same for the following in VTreatmetnRanges\{.h,.cpp\} - TrancembrncPressureLimitWindow - TrancembrncPressureMonitor Reply by Nicholas Ramirez on 11 July 2025, 16:27 > updated cpp files Reply by Behrouz NematiPour on 11 July 2025, 17:12 > RESOLVED Revision Comment by Behrouz NematiPour on 15 July 2025, 09:17 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22963 Put functions on top of the qml files after defining properties. Reply by Nicholas Ramirez on 15 July 2025, 10:33 > moved the funcitons Reply by Behrouz NematiPour on 21 July 2025, 18:54 > RESOLVED. Revision Comment by Behrouz NematiPour on 15 July 2025, 09:15 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22962 Please fix the typo and align the two functions. Reply by Nicholas Ramirez on 15 July 2025, 10:32 > good catch. Fixed and moved Reply by Behrouz NematiPour on 21 July 2025, 18:54 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml Revision Comment by Behrouz NematiPour on 11 July 2025, 16:07 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22940 Remove this block or set to empty for now. After aligning the code to make it easier to read, it appeared to me that it should not be correct. I would like you to remove the parts that are not fully implemented and have not been decided upon for FW, such as this one. {code} property string ufVolumeDescriptionText : isTreatmentPaused || vTDTreatmentStates.txDialysis ? "" : isUFRunning || isUFPaused ? qsTr("Isolated UF") : "" {code} Reply by Nicholas Ramirez on 11 July 2025, 16:27 > set to empty and added TODO Reply by Behrouz NematiPour on 11 July 2025, 17:18 > RESOLVED. Revision Comment by Behrouz NematiPour on 15 July 2025, 09:21 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22964 Please try to see if adding a space between the value and unit is necessary, or make it look more readable. Reply by Nicholas Ramirez on 15 July 2025, 10:32 > added Reply by Behrouz NematiPour on 21 July 2025, 19:05 > RESOLVED. Revision Comment by Behrouz NematiPour on 11 July 2025, 16:27 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22949 you can remove the !== "" Reply by Nicholas Ramirez on 14 July 2025, 08:10 > This whole component has now been removed Reply by Behrouz NematiPour on 15 July 2025, 09:26 > RESOLVED. ---------------------------------------- File: sources/view/hd/data/VTreatmentRanges.cpp Revision Comment by Behrouz NematiPour on 11 July 2025, 17:15 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22953 This is a duplicate. Please remove it. Reply by Nicholas Ramirez on 14 July 2025, 09:11 > updated and removed Reply by Behrouz NematiPour on 15 July 2025, 09:23 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/treatment/sections/TreatmentPressureComponent.qml Revision Comment by Behrouz NematiPour on 15 July 2025, 09:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1#c22961 Please make the _title, _value width as properties with default values of what you set here. Reply by Nicholas Ramirez on 15 July 2025, 10:32 > added to Variables Reply by Behrouz NematiPour on 21 July 2025, 18:53 > RESOLVED. --- ID: LEAHI-APPLICATION-LDT-1209-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1209-1 Title: LEAHI-APPLICATION-LDT-1209_Feature/Ldt 1209 Main Treatment Screen Statement of Objectives: State: Closed Summary: Author: Nicholas Ramirez Moderator: Nicholas Ramirez Reviewers: (5 active, 2 completed*) Tiffany Mejia (*) Behrouz NematiPour (*) Sean Nash Vinayakam Mani Michael Garthwaite Dara Navaei Daniel Ho