This is a list of all comments for LEAHI-APPLICATION-LDT-1516-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/dialogs/ConfirmDialog.qml Revision Comment by Nicholas Ramirez on 24 July 2025, 17:04 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23149 move the y change to the dialogs inside the stacks and revert the globla dialog y changes Reply by Nicholas Ramirez on 25 July 2025, 09:11 > updated to center the modalDialog and adjust the y on the > Treatmentadjustmentbase Reply by Behrouz NematiPour on 28 July 2025, 17:02 > resolved. ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentStack.qml Revision Comment by Behrouz NematiPour on 21 July 2025, 18:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c22998 Can it be LockDialog Dialog component? Reply by Nicholas Ramirez on 22 July 2025, 08:22 > Yes I created a LockDIalog componenet Reply by Behrouz NematiPour on 28 July 2025, 17:12 > resolved. Revision Comment by Nicholas Ramirez on 24 July 2025, 15:32 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23147 test with simulator Reply by Nicholas Ramirez on 25 July 2025, 09:11 > tested with the simulator and the header menu does hide when > in blood prime Reply by Behrouz NematiPour on 28 July 2025, 17:08 > resolved. ---------------------------------------- File: sources/gui/qml/components/HeaderBar.qml Revision Comment by Stephen Quong on 29 July 2025, 08:55 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23227 Default for spacing is 0, so this can be removed. Reply by Nicholas Ramirez on 29 July 2025, 09:35 > removed Reply by Stephen Quong on 29 July 2025, 10:37 > RESOLVED Revision Comment by Stephen Quong on 29 July 2025, 09:04 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23228 Can this variable be referenced to set the anchors.rightMargin below and for the extraSpace properties in all the child IconButtons? Reply by Nicholas Ramirez on 29 July 2025, 09:35 > yes updated Reply by Stephen Quong on 29 July 2025, 10:37 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/MainMenu.qml Revision Comment by Behrouz NematiPour on 24 July 2025, 14:50 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23141 please update to "* -1" Reply by Nicholas Ramirez on 25 July 2025, 09:14 > updated Reply by Behrouz NematiPour on 28 July 2025, 16:50 > RESOLVED. Revision Comment by Stephen Quong on 29 July 2025, 10:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23237 Remove line since effective code is commented out. Reply by Nicholas Ramirez on 29 July 2025, 10:45 > this still does the affect. I believe if you leave the > property animation empty it will animate all changes of > whatever Behavior is on. Refer > https://doc.qt.io/archives/qt-5.15/qml-qtquick-propertyanimation.html Reply by Behrouz NematiPour on 29 July 2025, 10:46 > [~squong] > I belive it is still effective, > Isn't it [~nramirez] ? Reply by Stephen Quong on 29 July 2025, 10:58 > Sorry, yes you are correct, it is just using the defaults. > Should the commented portion be removed though? Reply by Nicholas Ramirez on 29 July 2025, 11:06 > i removed the comment to be more clear Reply by Stephen Quong on 29 July 2025, 11:18 > RESOLVED Revision Comment by Stephen Quong on 29 July 2025, 10:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23240 Generally, any anchoring/positioning properties for the top level item should be set in the parent object where this object is being instantiated since any changes to these properties in the parent will be overridden here and it may not be obvious that it is happening. Reply by Nicholas Ramirez on 29 July 2025, 11:02 > yes i agree makes more sense that way of whats going on.. I > moved this to where they are being instantiated Reply by Stephen Quong on 29 July 2025, 11:06 > RESOLVED ---------------------------------------- File: sources/gui/qml/main.qml Revision Comment by Nicholas Ramirez on 24 July 2025, 15:10 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23145 remove visible key Reply by Nicholas Ramirez on 25 July 2025, 09:13 > removed and updated to create the all the menu models inside > of MainMenu.qml and set the models when needed Reply by Behrouz NematiPour on 28 July 2025, 17:12 > resolved. ---------------------------------------- File: sources/gui/qml/pages/MainStack.qml Revision Comment by Behrouz NematiPour on 21 July 2025, 18:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c22995 Please use * -1, to make it clear. Reply by Nicholas Ramirez on 22 July 2025, 08:22 > updated Reply by Nicholas Ramirez on 24 July 2025, 15:32 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/TreatmentFlowBase.qml Revision Comment by Nicholas Ramirez on 24 July 2025, 15:23 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23146 look into how many pages need to add topMargin instead of anchoring headerbar Reply by Nicholas Ramirez on 25 July 2025, 09:12 > as discussed after the meeting yesterday this was not the > most practical way so updated as we discussed to not change > the main dialogs and adjsut the stack dialogs Reply by Behrouz NematiPour on 28 July 2025, 17:09 > resolved. ---------------------------------------- File: sources/gui/qml/pages/treatment/TreatmentHome.qml Revision Comment by Nicholas Ramirez on 24 July 2025, 15:08 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23143 rename to updateMenu and move to main.qml where its being instantiated Reply by Nicholas Ramirez on 25 July 2025, 09:14 > removed and updated to create the all the menu models inside > of MainMenu.qml and set the models when needed Reply by Behrouz NematiPour on 28 July 2025, 17:05 > resolved. Revision Comment by Nicholas Ramirez on 24 July 2025, 15:10 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23144 make visible always and remove visible key Reply by Nicholas Ramirez on 25 July 2025, 09:14 > removed and updated to create the all the menu models inside > of MainMenu.qml and set the models when needed Reply by Behrouz NematiPour on 28 July 2025, 17:06 > resolved. ---------------------------------------- File: SDDs/HeaderBar/images/Thumbs.db Revision Comment by Stephen Quong on 29 July 2025, 08:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1#c23226 Remove this Windows hidden file. Reply by Behrouz NematiPour on 29 July 2025, 09:29 > Great catch, > Generally, please do NOT use: > {code} > $ git add . > {code} > for your commits, please review your changes prior to > committing. Reply by Nicholas Ramirez on 29 July 2025, 09:30 > removed file Reply by Stephen Quong on 29 July 2025, 10:38 > RESOLVED --- ID: LEAHI-APPLICATION-LDT-1516-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1516-1 Title: LEAHI-APPLICATION-LDT-1516_Feature/Ldt 1516 Headerbar Component Statement of Objectives: State: Closed Summary: Author: Nicholas Ramirez Moderator: Nicholas Ramirez Reviewers: (6 active, 2 completed*) Behrouz NematiPour (*) Stephen Quong (*) Sean Nash Tiffany Mejia Vinayakam Mani Michael Garthwaite Dara Navaei Daniel Ho