This is a list of all comments for LEAHI-APPLICATION-LDT-1636-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/dialogs/headerbar/InformationDialog.qml
Revision Comment by Stephen Quong on 13 August 2025, 15:56 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23759

  Remove unneeded semicolons.

  Reply by Nicholas Ramirez on 15 August 2025, 11:06
  > updated

    Reply by Stephen Quong on 15 August 2025, 12:14
    > RESOLVED

Revision Comment by Behrouz NematiPour on 13 August 2025, 14:32 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23753

  Have you tested the race condition here?
  Is the _repeater initialized before the property being
  initialized?
  How do you make sure we do not have a race condition?

  Reply by Nicholas Ramirez on 14 August 2025, 13:52
  > this has been removed

    Reply by Behrouz NematiPour on 14 August 2025, 19:29
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 15 August 2025, 17:05 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23782

  To be consistent with the other qml files, always move this
  onComplete to the end of the file.

  Reply by Nicholas Ramirez on 15 August 2025, 17:15
  > i moved it and renamed the files.

    Reply by Behrouz NematiPour on 15 August 2025, 17:15
    > RESOLVED

Revision Comment by Behrouz NematiPour on 14 August 2025, 19:31 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23770

  Please make this URL a property on top of the Dialog.

  Reply by Nicholas Ramirez on 15 August 2025, 10:54
  > updated

    Reply by Behrouz NematiPour on 18 August 2025, 09:29
    > RESOLVED

Revision Comment by Behrouz NematiPour on 14 August 2025, 19:36 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23771

  These are not dynamic texts, and calculating the width is not
  necessary.
  Please look at the implemented UI and set the width of each
  column as a constant value.
  You can then also delete textMetrics.
  Please note that it should have started with '_' if we were
  going to keep it.
  
  Generally, please avoid these types of calculations.

  Reply by Nicholas Ramirez on 15 August 2025, 10:55
  > removed calculation and hard coded column widths

    Reply by Behrouz NematiPour on 15 August 2025, 17:11
    > RESOLVED

Revision Comment by Behrouz NematiPour on 14 August 2025, 19:44 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23772

  Make each of these, as properties with constant values.
   - _rightColumnWidth
   - _leftColumnWidth
   - _columnSpacing

  Reply by Nicholas Ramirez on 15 August 2025, 10:55
  > updated

    Reply by Behrouz NematiPour on 15 August 2025, 17:11
    > RESOLVED

----------------------------------------
File: sources/gui/qml/main.qml
Revision Comment by Behrouz NematiPour on 15 August 2025, 17:20 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23788

  Thanks for updating the names.
  Please make the object name match the Component name.
  While you are doing that, could you also please remove the
  Dialog from the new name:
  {code}
  HeaderbarWiFi         { id: _headerbarWifi                  }
  HeaderbarInformation  { id: _headerbarInformation           }
  {code}

  Reply by Nicholas Ramirez on 15 August 2025, 17:34
  > updated naming

    Reply by Behrouz NematiPour on 18 August 2025, 09:28
    > RESOLVED

----------------------------------------
File: SDDs/Information_popup.puml
Revision Comment by Behrouz NematiPour on 14 August 2025, 19:56 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1#c23773

  We should add a DSP for display the information to the user.
  everytihg start from user but we do not have a response comming
  back to the user.

  Reply by Nicholas Ramirez on 15 August 2025, 11:05
  > updated

    Reply by Behrouz NematiPour on 15 August 2025, 17:10
    > RESOLVED


---

ID: LEAHI-APPLICATION-LDT-1636-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1636-1

Title: LDT-1636 - Feature/LDT-1636 - Headerbar - Information
Statement of Objectives:


State: Closed

Summary: 

Author: Nicholas Ramirez
Moderator: Nicholas Ramirez
Reviewers: (6 active, 2 completed*)
     Behrouz NematiPour   (*)
     Stephen Quong   (*)
     Sean Nash
     Tiffany Mejia
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Daniel Ho