This is a list of all comments for LEAHI-APPLICATION-LDT-1730-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml
Revision Comment by Stephen Quong on 24 July 2025, 14:04 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1730-1#c23138

  'val' and 'max' are being set differently than the previous
  version.

  Reply by Nicholas Ramirez on 24 July 2025, 14:06
  > good catch. pushed an update

    Reply by Stephen Quong on 24 July 2025, 17:24
    > RESOLVED

----------------------------------------
File: sources/view/td/data/treatment/VTreatmentUltrafiltrationData.h
Revision Comment by Stephen Quong on 24 July 2025, 10:35 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1730-1#c23130

  'minimum' is also referenced in:
  SDDs/Main_Treatment/FinalDiagram.dot

  Reply by Nicholas Ramirez on 24 July 2025, 10:43
  > regenerated this  file so it should be updated

    Reply by Stephen Quong on 24 July 2025, 14:06
    > RESOLVED

Revision Comment by Stephen Quong on 24 July 2025, 10:33 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1730-1#c23129

  'maximum' is also referenced in:
  SDDs/Main_Treatment/FinalDiagram.dot
  sources/gui/qml/pages/treatment/TreatmentUltrafiltrationItem.qml
  sources/gui/qml/pages/treatment/TreatmentStack.qml
  sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml

  Reply by Nicholas Ramirez on 24 July 2025, 10:42
  > Good catch. I have those updated now

  Reply by Behrouz NematiPour on 24 July 2025, 11:05
  > Thank you [~squong]
  > That is a great catch.
  > After your comment, I dug a little deeper.
  > These two properties are actually defined as global
  > properties/variables in this view and will get
  > updated/adjusted by FW with other messages.
  > Although we do not use them for now, as they will change in
  > pre-treatment and with the "Ultrafiltration Edit", we should
  > keep them for later use.
  > 
  > [~nramirez]
  > Please revert all changes to the minimum and maximum values.
  > 
  > I will also same comment in the following bug to address the
  > System Engineers' bug report.
  > https://diality.atlassian.net/browse/LDT-1730?focusedCommentId=75775

    Reply by Nicholas Ramirez on 24 July 2025, 13:53
    > i reverted the min/max changes

      Reply by Stephen Quong on 24 July 2025, 14:56
      > RESOLVED


---

ID: LEAHI-APPLICATION-LDT-1730-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1730-1

Title: LEAHI-APPLICATION-LDT-1730_Bugfix/Ldt 1730 UI Main TX Screen Ultrafiltration Details
Statement of Objectives:


State: Closed

Summary: 

Author: Nicholas Ramirez
Moderator: Nicholas Ramirez
Reviewers: (6 active, 2 completed*)
     Behrouz NematiPour   (*)
     Stephen Quong   (*)
     Sean Nash
     Tiffany Mejia
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Daniel Ho