This is a list of all comments for LEAHI-APPLICATION-LDT-1788-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/dialogs/NotificationDialog.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 11:26 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23518 As we talked, if you have time to modify this and use the QAbstractListModel in C++ and all those beginReset... to leave the model management in C++ and notify the qml, instead of QML doing it. Reply by Nicholas Ramirez on 05 August 2025, 09:11 > done Reply by Behrouz NematiPour on 13 August 2025, 09:52 > RESOLVED. Revision Comment by Stephen Quong on 01 August 2025, 12:10 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23365 Remove semicolon. Reply by Nicholas Ramirez on 01 August 2025, 14:38 > removed Reply by Stephen Quong on 01 August 2025, 15:31 > RESOLVED Revision Comment by Behrouz NematiPour on 04 August 2025, 10:28 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23506 Please remove gradients. Reply by Nicholas Ramirez on 05 August 2025, 09:12 > removed the gradient in the alarm dialog Reply by Behrouz NematiPour on 12 August 2025, 19:21 > RESOLVED. Revision Comment by Stephen Quong on 01 August 2025, 12:11 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23366 Align spacing after colon with other properties. Reply by Nicholas Ramirez on 01 August 2025, 14:38 > aligned Reply by Stephen Quong on 01 August 2025, 15:32 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 12:12 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23367 Align colon? Reply by Nicholas Ramirez on 01 August 2025, 14:37 > aligned Reply by Stephen Quong on 01 August 2025, 15:33 > RESOLVED Revision Comment by Nicholas Ramirez on 13 August 2025, 10:40 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23713 remove me Reply by Behrouz NematiPour on 13 August 2025, 10:49 > RESOLVED. Reply by Nicholas Ramirez on 13 August 2025, 10:51 > you have been removed Reply by Behrouz NematiPour on 13 August 2025, 13:03 > RESOLVED. Revision Comment by Stephen Quong on 01 August 2025, 12:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23368 Align colons. Reply by Nicholas Ramirez on 01 August 2025, 14:39 > aligned Reply by Stephen Quong on 01 August 2025, 15:33 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 12:16 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23369 Use attached property isCurrentItem? Reply by Nicholas Ramirez on 01 August 2025, 14:38 > can not use that here. This clicked assigned the currentIndex > property to the delegate index. This if statement is just to > do it once if already clicked on. Reply by Stephen Quong on 01 August 2025, 15:34 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/AlarmButtonRow.qml Revision Comment by Stephen Quong on 01 August 2025, 12:00 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23347 If this property is not being used, then can it be eliminated for now? Reply by Nicholas Ramirez on 01 August 2025, 14:36 > yes removed Reply by Stephen Quong on 01 August 2025, 15:28 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 11:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23339 Misspelling (lsitVisible)? Reply by Nicholas Ramirez on 01 August 2025, 14:36 > removed it Reply by Stephen Quong on 01 August 2025, 15:30 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 12:01 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23349 If this property is not being used, then can it be eliminated for now? Reply by Nicholas Ramirez on 01 August 2025, 14:36 > yes removed Reply by Stephen Quong on 01 August 2025, 15:29 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 12:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23354 Group this with the other properties above. Reply by Nicholas Ramirez on 01 August 2025, 14:36 > moved above Reply by Stephen Quong on 01 August 2025, 15:30 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 12:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23356 Doesn't look like this is being used externally or changed, can this be declared readonly? Reply by Nicholas Ramirez on 01 August 2025, 14:36 > only here so updated to readonly Reply by Stephen Quong on 01 August 2025, 15:30 > RESOLVED Revision Comment by Behrouz NematiPour on 04 August 2025, 09:36 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23485 Make the backgroungColor a function, or a read-only property(s), to use the same for all and be consistent. Reply by Nicholas Ramirez on 05 August 2025, 09:11 > made this a function Reply by Behrouz NematiPour on 12 August 2025, 18:53 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/NotificationBar.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 10:09 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23496 Please remove the gradient. It is not aligned with the text ( text is left-aligned, and the gradient is centered), and it also serves no purpose. Reply by Nicholas Ramirez on 05 August 2025, 09:40 > i removed the dialog alarm one that the text is left aligned. > If you agree i would like to keep the bottom bar alarmbar one > as the text is centered Reply by Behrouz NematiPour on 12 August 2025, 19:01 > I agree, let's keep it, since the text is centered too. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 10:14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23500 please if _root.enableMute = false, do nothing. I think if we do the _root.clicked(), that will cause development confusion, which means the button is not disabled, it does something that may not be actually related. Reply by Nicholas Ramirez on 05 August 2025, 09:11 > removed Reply by Behrouz NematiPour on 12 August 2025, 19:10 > RESOLVED. ---------------------------------------- File: sources/gui/qml/dialogs/AlarmListDialog.qml Revision Comment by Stephen Quong on 01 August 2025, 11:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23336 Does this need to be a Flickable if there are only going to be 10 items max in it? If the Flickable is not needed, can this item be eliminated and just have the contained TouchGrid take its place? Reply by Nicholas Ramirez on 01 August 2025, 14:37 > no you are right.. removed extra container component Reply by Stephen Quong on 01 August 2025, 16:31 > RESOLVED ---------------------------------------- File: sources/gui/qml/globals/Fonts.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 13:42 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23524 Please fix the typo. Reply by Nicholas Ramirez on 05 August 2025, 09:10 > fixed Reply by Behrouz NematiPour on 12 August 2025, 19:27 > RESOLVED. ---------------------------------------- File: sources/gui/qml/globals/Variables.qml Revision Comment by Behrouz NematiPour on 04 August 2025, 13:43 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23525 the alarmDialogHeight should be the application height minus the HeaderBar.hight and MainMenu(bottom menu).height, if you would like a minimumgap*2 to get a little smaller to avoid exact overlap. So we are using as much as we can but not covering the top, bottom menus. and we can have the same left, right margin. Reply by Nicholas Ramirez on 05 August 2025, 09:43 > i removed and left the default dialogWidth and dialogHeight Reply by Behrouz NematiPour on 12 August 2025, 19:28 > RESOLVED. ---------------------------------------- File: images/bell-off.png Revision Comment by Behrouz NematiPour on 12 August 2025, 20:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23670 That is fine for now, but I strongly believe that since our design is mostly with outlined images, we need to be consistent and keep all the images the same. Please note this until we discuss it later. Reply by Nicholas Ramirez on 13 August 2025, 09:04 > acknowledged Reply by Behrouz NematiPour on 13 August 2025, 09:08 > RESOLVED. ---------------------------------------- File: images/bell-on.png Revision Comment by Behrouz NematiPour on 12 August 2025, 20:21 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23671 http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-1788-1#CFR-69529 Reply by Nicholas Ramirez on 13 August 2025, 09:04 > acknowledged Reply by Behrouz NematiPour on 13 August 2025, 09:07 > RESOLVED. ---------------------------------------- File: images/help.png Revision Comment by Behrouz NematiPour on 12 August 2025, 20:21 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23672 http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-1788-1#CFR-69529 Reply by Nicholas Ramirez on 13 August 2025, 09:04 > acknowledged Reply by Behrouz NematiPour on 13 August 2025, 09:07 > Thanks > RESOLVED. ---------------------------------------- File: sources/storage/StorageGlobals.cpp Revision Comment by Stephen Quong on 01 August 2025, 12:23 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23370 If %1 is meant to be a directory, then change string to "%1/Alarms/". Reply by Nicholas Ramirez on 01 August 2025, 14:28 > the way this and "Settings_Category_InstructionsImagesLoc" is > being used as an arguement for Settings_Path_Name which > already has the "/". For ex.. > "/home/denali/Public/luis/application/config/configurations/" Reply by Stephen Quong on 01 August 2025, 15:10 > It's ok if the final string has multiple forward slashes > concatenated together, the path will still be interpreted > properly. On the off chance that a path being prepended > does not happen to have the ending slash, then adding it > here will catch that. Also, it makes it clear that the > substituted string is meant to be a full path. Reply by Nicholas Ramirez on 01 August 2025, 16:09 > Okay good to know. Added the slash Reply by Stephen Quong on 01 August 2025, 16:31 > RESOLVED Revision Comment by Behrouz NematiPour on 04 August 2025, 16:17 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23529 Please align the semi-colons ( ; ), colons ( : ) , and dots ( . ) (when/where)ever you see them not aligned with the rest. Reply by Nicholas Ramirez on 05 August 2025, 09:12 > fixed Reply by Behrouz NematiPour on 12 August 2025, 19:49 > RESOLVED. ---------------------------------------- File: sources/view/hd/alarm/VAlarmStatus.cpp Revision Comment by Nicholas Ramirez on 13 August 2025, 10:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23718 revert Reply by Nicholas Ramirez on 13 August 2025, 11:32 > removed Reply by Behrouz NematiPour on 13 August 2025, 13:00 > RESOLVED. Revision Comment by Stephen Quong on 01 August 2025, 12:27 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23378 Declare as 'const QString'. Reply by Nicholas Ramirez on 01 August 2025, 14:39 > updated Reply by Stephen Quong on 01 August 2025, 15:27 > RESOLVED Revision Comment by Nicholas Ramirez on 13 August 2025, 10:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23719 revert this too Reply by Nicholas Ramirez on 13 August 2025, 11:32 > updated to parse and do nothing Reply by Behrouz NematiPour on 13 August 2025, 13:00 > RESOLVED. Revision Comment by Stephen Quong on 01 August 2025, 12:28 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23380 Declare as 'const QString'. Reply by Nicholas Ramirez on 01 August 2025, 14:39 > updated Reply by Stephen Quong on 01 August 2025, 15:26 > RESOLVED Revision Comment by Stephen Quong on 01 August 2025, 12:29 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23381 If defaultImagePath is only used here, then might be better to just construct the string here instead of declare and set the defaultImagePath variable above. Reply by Nicholas Ramirez on 01 August 2025, 14:40 > moved here Reply by Stephen Quong on 01 August 2025, 16:03 > Remove the defaultImagePath variable and put the > QStringLiteral into the false case of the ternary so that > if imagePath exists, then the string construction will > never be executed. Reply by Nicholas Ramirez on 01 August 2025, 16:10 > removed and just put the string inside the ternary Reply by Stephen Quong on 01 August 2025, 16:32 > RESOLVED Revision Comment by Behrouz NematiPour on 12 August 2025, 20:17 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23669 I have heard that we may not have an image for all the alarms; therefore, it is possible to have a blank image, and the default image may not be appropriate. Please modify the code not to use any image when none is assigned for that ID. Please do not use any empty image or white background image. (just no image at all) Reply by Nicholas Ramirez on 13 August 2025, 09:04 > updated to just show nothing if the image is not needed or > does not exist Reply by Behrouz NematiPour on 13 August 2025, 09:08 > Thanks > RESOLVED. ---------------------------------------- File: sources/view/hd/alarm/VAlarmStatus.h Revision Comment by Stephen Quong on 01 August 2025, 12:27 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23376 Declare as 'const QString'. Reply by Nicholas Ramirez on 01 August 2025, 14:40 > updated Reply by Stephen Quong on 01 August 2025, 15:22 > RESOLVED Revision Comment by Behrouz NematiPour on 12 August 2025, 19:56 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23667 Please avoid using a pointer at all costs. Reply by Nicholas Ramirez on 13 August 2025, 08:52 > I believe this does need to be a pointer exposing it to QML > because it is derived from QAbstractListModel we should > expose a pointer to the actual model. Ff we pass it by value > it will get some kind of deep copy of the model not the > actual model. So the QML listview will not update when the > _instructionsList changes Reply by Behrouz NematiPour on 13 August 2025, 10:47 > For now we can use the pointer, and we will investigate on > this. > RESOLVED. Revision Comment by Behrouz NematiPour on 12 August 2025, 19:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23668 http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-1788-1#CFR-69642 Reply by Nicholas Ramirez on 13 August 2025, 08:56 > same reason as above Reply by Behrouz NematiPour on 13 August 2025, 10:48 > For now we can use the pointer, and we will investigate on > this. > RESOLVED. ---------------------------------------- File: sources/view/hd/alarm/VAlarmInstructionsModel.cpp Revision Comment by Behrouz NematiPour on 04 August 2025, 18:02 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23534 Please do not use == false or == true for an already boolean value/function. just use: {code} if ( ! vIndex.isValid() || vIndex.row() < 0 || vIndex.row() >= rowCount() ) {code} Reply by Nicholas Ramirez on 05 August 2025, 09:07 > updated Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 18:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23535 Use the checks as check blocks, and avoid if, elses. {code} if ( ! check1 ) { return; } if ( ! check2 ) { return; } // the pass block .... {code} Reply by Nicholas Ramirez on 05 August 2025, 09:07 > updated Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 18:08 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23536 What is the vIndex.column() for? Reply by Nicholas Ramirez on 05 August 2025, 09:06 > this shouldnt be over 0 so I removed Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 18:10 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23537 Use a simple switch case, without a default case on the role enum. Reply by Nicholas Ramirez on 05 August 2025, 09:07 > updated Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 17:00 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23530 Please use emit everywhere to be consistent with the rest of the code. Reply by Nicholas Ramirez on 05 August 2025, 09:06 > updated Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 17:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23533 Why do we need appendData? When each alarm ID changes, the model needs to be refreshed entirely. Reply by Nicholas Ramirez on 05 August 2025, 09:08 > i use it in VAlarmStatus::onActionReceive.. when we get a new > alarm i clear the model and append the new steps/ images Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. Revision Comment by Behrouz NematiPour on 04 August 2025, 17:06 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23531 Please do not use any std code, and use Qt only. If I recall correctly on this function behavior, you should be able to use the qBound(lowerBound, value, upperBound); And also, do not use auto for basic types. The auto is generally used in our coding for long iteration template types and lambdas. Reply by Nicholas Ramirez on 05 August 2025, 09:13 > updated to use qBound Reply by Behrouz NematiPour on 13 August 2025, 09:43 > File Renamed and logic updated. > RESOLVED. ---------------------------------------- File: sources/model/MListModel.cpp Revision Comment by Stephen Quong on 13 August 2025, 13:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23734 Declare variables using 'auto' and 'const auto' where possible, especially where initializing the variable. Reply by Behrouz NematiPour on 13 August 2025, 13:42 > [~squong] > Please let's do that only for the long template-based > iterator types, and not for all the variables. > > And agree with using const and also & when applicable. Reply by Behrouz NematiPour on 13 August 2025, 15:09 > BN: RESOLVED Revision Comment by Stephen Quong on 13 August 2025, 13:40 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23738 Remove leading and trailing spaces in if conditionals to keep style consistent. Reply by Nicholas Ramirez on 13 August 2025, 14:23 > as discussed to add the space after the parenthesis. updated > all instances Reply by Stephen Quong on 13 August 2025, 16:11 > RESOLVED Revision Comment by Stephen Quong on 13 August 2025, 13:34 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23731 Change to match other beginning { style. Reply by Nicholas Ramirez on 13 August 2025, 14:23 > updated Reply by Stephen Quong on 13 August 2025, 16:11 > RESOLVED Revision Comment by Behrouz NematiPour on 12 August 2025, 19:41 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23664 Please test to see if the list is empty, the code crashes, or not. I have a feeling that if the list is empty (no role added), the find = 0 == end = 0 and then the line {code}_data[vIndex.row()][vRole]{code} will crash. Generally, do not directly try to get the value out of a function return value without first getting the function output, testing the size with the index(in your case, eRole), then getting the field at the index. So, please update as mentioned in the line above. Reply by Nicholas Ramirez on 13 August 2025, 09:03 > added more check blocks Reply by Behrouz NematiPour on 13 August 2025, 09:29 > RESOLVED Revision Comment by Behrouz NematiPour on 13 August 2025, 09:28 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23690 [Same here for the lOut in this comment|http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-1788-1#c23664] Reply by Nicholas Ramirez on 13 August 2025, 10:05 > updated this method to use lOut Reply by Behrouz NematiPour on 13 August 2025, 10:16 > RESOLVED. Revision Comment by Behrouz NematiPour on 12 August 2025, 19:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23665 Same here. http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-1788-1#CFR-69792 This is not safe. First, check the list length, and also first get its value in a variable, test it, then use it. Reply by Nicholas Ramirez on 13 August 2025, 09:03 > added more check blocks Reply by Behrouz NematiPour on 13 August 2025, 09:17 > RESOLVED. Revision Comment by Behrouz NematiPour on 13 August 2025, 09:11 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23685 Should you continue if the roleNames are empty? Reply by Nicholas Ramirez on 13 August 2025, 09:20 > yea updated to your suggestion Reply by Behrouz NematiPour on 13 August 2025, 10:20 > RESOLVED. Revision Comment by Behrouz NematiPour on 13 August 2025, 09:11 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23686 Should you continue if the value is empty? I recommend being consistent and more flexible: 1 - to move the {code}QVariantMap map;{code} to the top of the function. 2 - add the lOut just before the {code} lOut: return map; {code} 3 - on each check fail: {code}goto lOut;{code} Reply by Nicholas Ramirez on 13 August 2025, 09:20 > updated to your suggestion Reply by Behrouz NematiPour on 13 August 2025, 09:39 > Thanks. > Please do items 1 and 3 for the first two checks, too. Reply by Nicholas Ramirez on 13 August 2025, 10:06 > updated Reply by Behrouz NematiPour on 13 August 2025, 10:20 > RESOLVED. Revision Comment by Stephen Quong on 13 August 2025, 13:33 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23730 Change to match above beginning { style. Reply by Nicholas Ramirez on 13 August 2025, 14:24 > updated Reply by Stephen Quong on 13 August 2025, 16:11 > RESOLVED Revision Comment by Stephen Quong on 13 August 2025, 13:34 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1#c23732 Change to match other beginning { style. Reply by Behrouz NematiPour on 13 August 2025, 13:45 > I agree with this comment, to make the code fit in a shorter > vertical area. > Please use the Bjarne Stroustrup everywhere and be > consistent: > {code} > if () { > } > else { > } > {code} Reply by Nicholas Ramirez on 13 August 2025, 14:24 > updated Reply by Behrouz NematiPour on 13 August 2025, 15:07 > BN: RESOLVED --- ID: LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Title: LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design Statement of Objectives: State: Closed Summary: Author: Nicholas Ramirez Moderator: Nicholas Ramirez Reviewers: (6 active, 2 completed*) Behrouz NematiPour (*) Stephen Quong (*) Sean Nash Tiffany Mejia Vinayakam Mani Michael Garthwaite Dara Navaei Daniel Ho