This is a list of all comments for LEAHI-APPLICATION-LDT-2071-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
Revision Comment by Behrouz NematiPour on 29 August 2025, 13:48 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c23987

  --isIdle || isWaitPump--
  --just to be more clear.--
  
  isIdle :start
  isStarted : stop
  --else: start--
  
  disable the button otherwise.

  Reply by Nicholas Ramirez on 29 August 2025, 13:57
  > updated

    Reply by Behrouz NematiPour on 29 August 2025, 14:43
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 29 August 2025, 14:01 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c23990

  Please move the text styling <i> out of translation.

  Reply by Nicholas Ramirez on 29 August 2025, 14:30
  > moved outside of translation

Revision Comment by Behrouz NematiPour on 29 August 2025, 14:16 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c23994

  We need to find a way to notify the user of rejection.
  In the current design, I do not see any room to display the
  rejection reason message.
  We may need to consider a dialog that pops up, displaying only
  the rejection reason for the current response and a close
  button on top (right/left).

  Reply by Nicholas Ramirez on 29 August 2025, 14:34
  > We should ask caryn on how we can display these and then I
  > can update all these commented out lines in all the
  > components for the main treatment screen

----------------------------------------
File: sources/gui/GuiGlobals.h
Revision Comment by Behrouz NematiPour on 03 September 2025, 14:57 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c24031

  These two need to @CAPIZED (set last byte to 0F) to avoid
  duplication.

  Reply by Nicholas Ramirez on 03 September 2025, 16:00
  > updated

    Reply by Behrouz NematiPour on 03 September 2025, 16:04
    > RESOLVED

----------------------------------------
File: sources/model/td/adjustment/treatment/MTreatmentAdjustSalineResponse.h
Revision Comment by Behrouz NematiPour on 29 August 2025, 11:24 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c23980

  Update to TD

  Reply by Nicholas Ramirez on 29 August 2025, 11:39
  > updated here and in MTreatmentAdjustRequests.h

    Reply by Behrouz NematiPour on 29 August 2025, 14:43
    > RESOLVED.

----------------------------------------
File: leahi_dialin/common/ui_defs.py
Revision Comment by Behrouz NematiPour on 29 August 2025, 14:41 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c23997

  Can you remind me where these are used?
  We already have the hex version defined in msg_ids.py.

  Reply by Nicholas Ramirez on 29 August 2025, 15:21
  > removed.. tested and still works

    Reply by Behrouz NematiPour on 29 August 2025, 15:39
    > Thanks!
    > Resolved.

----------------------------------------
File: sources/model/hd/adjustment/treatment/MTreatmentAdjustRequests.h
Revision Comment by Behrouz NematiPour on 03 September 2025, 14:43 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1#c24029

  Request: 0x5F

  Reply by Nicholas Ramirez on 03 September 2025, 15:59
  > updated

    Reply by Behrouz NematiPour on 03 September 2025, 16:04
    > RESOLVED.


---

ID: LEAHI-APPLICATION-LDT-2071-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2071-1

Title: LDT-2071: Solution Infusion - SW - 01 - R&I - application-dialin
Statement of Objectives:


State: Closed

Summary: 

Author: Nicholas Ramirez
Moderator: Nicholas Ramirez
Reviewers: (8 active, 2 completed*)
     Behrouz NematiPour   (*)
     Stephen Quong   (*)
     Sean Nash
     Tiffany Mejia
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Raghu Kallala
     Dara Navaei
     Daniel Ho