This is a list of all comments for LEAHI-APPLICATION-LDT-2160-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/components/BaseComboBox.qml Revision Comment by Nicholas Ramirez on 05 September 2025, 15:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24088 use Variable for dashes Reply by Nicholas Ramirez on 08 September 2025, 11:06 > updated Reply by Stephen Quong on 12 September 2025, 10:29 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 15:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24087 add () Reply by Nicholas Ramirez on 08 September 2025, 11:06 > fixed Reply by Stephen Quong on 12 September 2025, 10:29 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/ModalDialog.qml Revision Comment by Nicholas Ramirez on 05 September 2025, 15:44 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24086 remove Image componenet Reply by Nicholas Ramirez on 08 September 2025, 11:06 > removed from existance Reply by Stephen Quong on 12 September 2025, 10:29 > RESOLVED ---------------------------------------- File: sources/gui/qml/components/ValueControl.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 12:36 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24055 The name of the component is not clear. I think we could use the same name as before, "SliderCreateTreatment.qml" Reply by Nicholas Ramirez on 05 September 2025, 13:27 > What about something like "ValueAdjuster"?? this component is > not only a slider. Its the value being displayed in the > center with the left/right arrows to adjust that value with > the hidden slider behavior. Reply by Nicholas Ramirez on 08 September 2025, 11:03 > file named to ValueAdjuster Reply by Stephen Quong on 12 September 2025, 10:30 > RESOLVED Revision Comment by Behrouz NematiPour on 05 September 2025, 12:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24056 Could you please also add the horizontal slider line(very thin/narrow/1 or 2 pixel height)? You already have only the indicator/handler, but the line that shows the allowable moving min, max would be very helpful. Just the line without any numbers or any extra info. Reply by Nicholas Ramirez on 05 September 2025, 14:23 > added Reply by Behrouz NematiPour on 15 September 2025, 15:54 > RESOLVED Revision Comment by Behrouz NematiPour on 05 September 2025, 12:42 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24057 Same here. Use multi-line assignment. Reply by Nicholas Ramirez on 05 September 2025, 14:02 > updated and separated Reply by Behrouz NematiPour on 15 September 2025, 15:52 > RESOLVED Revision Comment by Behrouz NematiPour on 05 September 2025, 11:52 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24054 Please do not use multi-assignments, and separate them into multiple lines. Reply by Nicholas Ramirez on 05 September 2025, 14:03 > updated and separated Reply by Behrouz NematiPour on 15 September 2025, 15:52 > RESOLVED Revision Comment by Stephen Quong on 27 August 2025, 14:41 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23918 Declare raw using let instead of var. Reply by Nicholas Ramirez on 27 August 2025, 16:08 > updated Reply by Stephen Quong on 27 August 2025, 16:10 > RESOLVED Revision Comment by Stephen Quong on 27 August 2025, 14:42 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23919 Declare stepped using let instead of var. Reply by Nicholas Ramirez on 27 August 2025, 16:08 > updated Reply by Stephen Quong on 27 August 2025, 16:11 > RESOLVED Revision Comment by Stephen Quong on 27 August 2025, 14:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23920 Can you use MouseArea pressAndHold and pressAndHoldInterval instead of this timer? (https://doc.qt.io/archives/qt-5.15/qml-qtquick-mousearea.html#pressAndHold-signal) Reply by Nicholas Ramirez on 27 August 2025, 16:08 > yes updated and removed timer Reply by Stephen Quong on 27 August 2025, 16:12 > RESOLVED ---------------------------------------- File: sources/gui/qml/dialogs/AcidConcentrateAdjustment.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 11:44 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24051 Please use your newly defined units in the Variables for the K and Ca. Reply by Nicholas Ramirez on 05 September 2025, 14:04 > updated Reply by Behrouz NematiPour on 12 September 2025, 15:29 > RESOLVED. Revision Comment by Behrouz NematiPour on 05 September 2025, 11:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24052 Move the maximum, minimum, and resolution values for both potassium and calcium, as well as the comments in Variables.qml for now, but leave the //TODO comments here. Reply by Nicholas Ramirez on 05 September 2025, 14:04 > added variables Reply by Behrouz NematiPour on 15 September 2025, 15:55 > RESOLVED ---------------------------------------- File: sources/gui/qml/dialogs/diagnostics/DiagnosticsDialog.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 11:49 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24053 Please remove this gradient. Reply by Nicholas Ramirez on 05 September 2025, 14:03 > removed Reply by Stephen Quong on 12 September 2025, 10:32 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/MainStack.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 11:28 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24048 As we talked, there is only one screen for this state "for now". Since this aligns with the TD Op_Mode states, I believe it is more consistent and future-proof to keep the stack, although it is only one screen, "for now". So, please revert the stack and remove the unused screen, leaving the PreTreatmentCreate.qml. This way, if we need any additional screens later, we have the foundation in place. Reply by Nicholas Ramirez on 05 September 2025, 14:04 > reverted and kept the stack Reply by Behrouz NematiPour on 15 September 2025, 15:56 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/TreatmentFlowBase.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 11:24 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24047 Why did this change? It may affect other screens inheriting this. Reply by Nicholas Ramirez on 05 September 2025, 13:19 > changed per the updated design the title is left aligned. The > other screens i do not think we have updated for the new > design yet (DisinfectBase, EndTratmentBase, > PostTreatmentBase, PreTreatmentBase) Reply by Nicholas Ramirez on 05 September 2025, 14:51 > fix this it shouldnt > > left : parent.left Reply by Nicholas Ramirez on 05 September 2025, 15:24 > revert to original Reply by Nicholas Ramirez on 08 September 2025, 11:05 > fixed Reply by Behrouz NematiPour on 15 September 2025, 15:56 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 11:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24050 Is there a reason we cannot merge the two PreTreatmentCreate.qml and PreTreatmentCreateContent.qml in one PreTreatmentCreate.qml file? Reply by Nicholas Ramirez on 05 September 2025, 13:43 > keeping PreTreatmentCreateContent.qml separate so I can later > use that when populating the headerbar prescription Rx popup. Reply by Behrouz NematiPour on 15 September 2025, 15:14 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateContent.qml Revision Comment by Nicholas Ramirez on 05 September 2025, 15:32 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24082 update to clear after validation fail when you re edit Reply by Nicholas Ramirez on 08 September 2025, 11:04 > added this Reply by Behrouz NematiPour on 15 September 2025, 15:38 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 15:11 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24079 Make width of content as wide as pposible. takes in 64 characters Reply by Nicholas Ramirez on 08 September 2025, 11:04 > updated to use as much space as possible Reply by Behrouz NematiPour on 15 September 2025, 15:15 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 15:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24080 add dashes to Variables and update everytwhere Reply by Nicholas Ramirez on 08 September 2025, 11:04 > updated Reply by Behrouz NematiPour on 15 September 2025, 15:39 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 14:48 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24076 set to _heparinStopTimeControl not set when this is changed Reply by Nicholas Ramirez on 08 September 2025, 11:07 > updated to clear hepartinStop TIme Reply by Behrouz NematiPour on 15 September 2025, 15:39 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 16:01 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24089 look into previous design for behavior when this is enabled what gets disabled. Reply by Nicholas Ramirez on 08 September 2025, 11:06 > added prvious behavior Reply by Behrouz NematiPour on 15 September 2025, 15:36 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 16:02 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24090 Look into how to turn off when value is set Reply by Nicholas Ramirez on 05 September 2025, 16:06 > keep slider behavior the same min to max. When min value > enabled left arrow and when pressed then set to "OFF" Reply by Behrouz NematiPour on 15 September 2025, 15:20 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 16:02 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24091 set "OFF" when value is 0 Reply by Nicholas Ramirez on 08 September 2025, 11:04 > updated Reply by Behrouz NematiPour on 15 September 2025, 15:35 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 16:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24092 when value changed when value is less than minimum set to minimum Reply by Nicholas Ramirez on 08 September 2025, 11:02 > updated for this behavior Reply by Behrouz NematiPour on 15 September 2025, 15:20 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 15:06 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24078 "Tx Code: " Reply by Nicholas Ramirez on 08 September 2025, 11:04 > fixed Reply by Behrouz NematiPour on 15 September 2025, 15:15 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateItem.qml Revision Comment by Behrouz NematiPour on 05 September 2025, 11:36 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24049 Please move this file into the Compound folder. Reply by Nicholas Ramirez on 05 September 2025, 14:04 > moved .. maybe a rename too?? Reply by Nicholas Ramirez on 08 September 2025, 11:14 > renamed to LabelUnitContainer Reply by Behrouz NematiPour on 15 September 2025, 15:55 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml Revision Comment by Nicholas Ramirez on 05 September 2025, 15:40 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24084 revert back to null Reply by Nicholas Ramirez on 08 September 2025, 11:04 > reverted Reply by Behrouz NematiPour on 15 September 2025, 15:37 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 15:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24083 keep this and push page( _pretreatmentCreate )} Reply by Nicholas Ramirez on 08 September 2025, 11:04 > added this back in Reply by Behrouz NematiPour on 15 September 2025, 15:24 > RESOLVED ---------------------------------------- File: sources/view/hd/data/VTreatmentRanges.cpp Revision Comment by Behrouz NematiPour on 05 September 2025, 10:43 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24044 I believe it has been decided to add only one, and if edited, edit the one that has been added, for the active treatment. This will be cleared for the next treatment and reset to the original settings. We already have the acidConcentrateOptions property as the view list of AcidTypes, and it should be used for the model on screen. We do not need to modify the original set configuration values in _Settings. Therefore, please remove any modifications to the _Settings class, content. 1) Add a new property for the new acidType 2) When the confirm button on the acidType is touched 2.1) Check if the acidType is unique; otherwise, notify the user and stay on the screen until the user adds a new type or just closes the dialog. 2.2) Remove the item with the acidType value from the acidConcentrateOptions list 2.3) Update the acidType property. 2.4) Add the acidType to the acidConcentrateOptions at the bottom (or top, whichever makes more sense, but always do the same). 3) For the next treatment 3.1) Just do step 2.2 to revert the acidConcentrateOptions to its original 3.2) Clear the acidType property. Please let me know if I've missed anything. Reply by Nicholas Ramirez on 05 September 2025, 14:05 > updated Reply by Behrouz NematiPour on 15 September 2025, 15:29 > RESOLVED Revision Comment by Stephen Quong on 27 August 2025, 16:19 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23931 Declare const, if possible. Reply by Nicholas Ramirez on 27 August 2025, 16:30 > updated Reply by Stephen Quong on 27 August 2025, 16:34 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 14:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24073 notify user its a duplicate and do not close popup Reply by Nicholas Ramirez on 08 September 2025, 11:05 > added this Reply by Behrouz NematiPour on 15 September 2025, 15:51 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 14:45 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24074 try and look into removeOne https://doc.qt.io/qt-6/qlist.html#removeOne remove by _acidConcentrate not position Reply by Nicholas Ramirez on 08 September 2025, 11:05 > updated Reply by Behrouz NematiPour on 15 September 2025, 15:40 > RESOLVED Revision Comment by Nicholas Ramirez on 05 September 2025, 14:46 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24075 same as above Reply by Nicholas Ramirez on 08 September 2025, 11:05 > updated Reply by Behrouz NematiPour on 15 September 2025, 15:39 > RESOLVED Revision Comment by Stephen Quong on 27 August 2025, 16:15 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23929 Declare mCategory and size const, if possible. Reply by Nicholas Ramirez on 27 August 2025, 16:30 > updated Reply by Stephen Quong on 27 August 2025, 16:34 > RESOLVED Revision Comment by Behrouz NematiPour on 05 September 2025, 11:12 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24045 These were removed to ensure the check on the Heparin stop time matches the Treatment Duration. Please comment these and a comment with the text above. I believe I have already removed those mapping values from the configurations and set them in the Create Rx QML to match the Treatment Duration. Please ensure it aligns with the previous checks from the old design/implementation. Reply by Nicholas Ramirez on 05 September 2025, 14:05 > removed and added comment. Updated behavior to match as > before. Thanks for catching that i didnt notice this once was > a bit different Reply by Behrouz NematiPour on 15 September 2025, 15:29 > RESOLVED ---------------------------------------- File: sources/view/hd/data/VTreatmentRanges.h Revision Comment by Stephen Quong on 27 August 2025, 16:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23932 It may be more efficient to pass the bool by const value instead of const reference. Reply by Nicholas Ramirez on 27 August 2025, 16:30 > updated Reply by Stephen Quong on 27 August 2025, 16:34 > RESOLVED ---------------------------------------- File: sources/model/settings/MSettings.cpp Revision Comment by Stephen Quong on 27 August 2025, 16:13 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c23928 Can keyValue and index be declared const? Reply by Nicholas Ramirez on 27 August 2025, 16:30 > updated Reply by Stephen Quong on 27 August 2025, 16:34 > RESOLVED ---------------------------------------- File: sources/model/settings/MSettings.h Revision Comment by Behrouz NematiPour on 05 September 2025, 11:16 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24046 Please remove this, as has been explained in the following comment: http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-2160-1#CFR-70239 Reply by Nicholas Ramirez on 05 September 2025, 14:06 > removed Reply by Behrouz NematiPour on 15 September 2025, 15:28 > RESOLVED ---------------------------------------- File: sources/gui/qml/compounds/PreTreatmentCreateItem.qml Revision Comment by Nicholas Ramirez on 05 September 2025, 15:42 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24085 add () Reply by Nicholas Ramirez on 08 September 2025, 11:03 > added Reply by Behrouz NematiPour on 15 September 2025, 15:36 > RESOLVED ---------------------------------------- File: SDDs/Create_Rx/Final_Diagram.png Revision Comment by Behrouz NematiPour on 10 September 2025, 10:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1#c24200 This image is not viewable. Seems like a broken image? Reply by Nicholas Ramirez on 10 September 2025, 13:34 > This may just be a crucible thing Reply by Behrouz NematiPour on 15 September 2025, 15:35 > RESOLVED --- ID: LEAHI-APPLICATION-LDT-2160-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2160-1 Title: LDT-2160 - Treatment Parameters (New Create Rx) - R&I - [Application] Statement of Objectives: State: Closed Summary: Author: Nicholas Ramirez Moderator: Nicholas Ramirez Reviewers: (7 active, 2 completed*) Behrouz NematiPour (*) Stephen Quong (*) Sean Nash Tiffany Mejia Vinayakam Mani Michael Garthwaite Raghu Kallala Dara Navaei Daniel Ho