This is a list of all comments for LEAHI-APPLICATION-LDT-2727-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/components/HeaderBar.qml Revision Comment by Behrouz NematiPour on 12 November 2025, 14:12 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25084 Please define in Fonts.qml or top of this qml if only used here. Also @55, @78, @90, .... . Reply by Nicholas Ramirez on 13 November 2025, 11:17 > updated and added to fonts ---------------------------------------- File: sources/gui/qml/pages/settings/SettingsBase.qml Revision Comment by Behrouz NematiPour on 12 November 2025, 18:04 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25118 Why exposed? Shouldn't the SettingsBase decide where the children must anchor, or locate? Reply by Nicholas Ramirez on 13 November 2025, 11:18 > the content for each page is now set to this container which > will handle the margins for the container so all componenets > using the SettingsBase will have the same margins and I do > not have to specify them left, right, bottom in each of > them.. I have done the same thing for other components that > act as a container Revision Comment by Behrouz NematiPour on 12 November 2025, 18:01 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25117 Every time you use " * someValue ", please add a comment explaining why. @100, @101, @102 as well. Reply by Nicholas Ramirez on 13 November 2025, 11:19 > added ---------------------------------------- File: sources/gui/qml/pages/settings/SettingsDateTime.qml Revision Comment by Behrouz NematiPour on 12 November 2025, 18:12 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25119 For signals and slots as we tlaked use blocks of {code} onSomething: { aFunctionCall() } {code} Unless there are multiple similar calls that need alignment in one line. Reply by Nicholas Ramirez on 13 November 2025, 11:19 > updated ---------------------------------------- File: sources/gui/qml/pages/settings/SettingsHome.qml Revision Comment by Behrouz NematiPour on 12 November 2025, 18:18 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25121 IMPORTANT!!! Please test this on the device. Reply by Nicholas Ramirez on 13 November 2025, 11:09 > This works. A few other qml files use this version of the > import Revision Comment by Behrouz NematiPour on 12 November 2025, 18:19 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25122 why the rowcount is real? Reply by Nicholas Ramirez on 13 November 2025, 11:13 > changed to int Revision Comment by Behrouz NematiPour on 12 November 2025, 18:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25123 Why did the logic change? The order should be to fill in the first column, then go to the next, and it should not be by row. Reply by Nicholas Ramirez on 13 November 2025, 11:14 > updated logic so the grid view has an equal number of rows > depending on the total number of visible items. > > Before row count was hard coded to 6 so if there was ex. 8 > items the left column would show 6 and the right 2.. Updated > so the gridview will look as even as possible. > > I hard coded the column to 2 columns since the design has 2 > columns and added logic to the row count to make the 2 > columns equal ---------------------------------------- File: sources/gui/qml/compounds/LabelUnitContainer.qml Revision Comment by Behrouz NematiPour on 12 November 2025, 14:17 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25085 Fonts.qml Reply by Nicholas Ramirez on 13 November 2025, 11:17 > updated ---------------------------------------- File: sources/bluetooth/BluetoothInterface.cpp Revision Comment by Behrouz NematiPour on 12 November 2025, 10:35 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25070 Why do we need to remove this? Reply by Nicholas Ramirez on 12 November 2025, 12:15 > i do not remember why i commented this out.. but added back > in ---------------------------------------- File: sources/device/DeviceView.cpp Revision Comment by Behrouz NematiPour on 10 December 2025, 13:44 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25685 No Action For Now: Same for the vError param: https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#CFR-76762 Reply by Nicholas Ramirez on 10 December 2025, 15:07 > okay acknowledged ---------------------------------------- File: sources/device/DeviceController.cpp Revision Comment by Behrouz NematiPour on 10 December 2025, 13:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25684 No Action For Now: Please always use mError, since it is local to the script function, to be consistent with the rest. Also, usually it is a number, not a bool. It is fine for now, but later we should create a decorator to cover these types of similarities. Reply by Nicholas Ramirez on 10 December 2025, 15:07 > okay will do ---------------------------------------- File: sources/gui/qml/dialogs/ConfirmDialog.qml Revision Comment by Behrouz NematiPour on 12 November 2025, 14:34 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25086 why "-3"? Please put a comment like line @58. Reply by Nicholas Ramirez on 13 November 2025, 11:17 > added comment ---------------------------------------- File: sources/view/settings/VDateTime.cpp Revision Comment by Behrouz NematiPour on 12 November 2025, 16:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25112 These two lines can be moved to the geteopochUTC. Reply by Nicholas Ramirez on 13 November 2025, 11:20 > updated Revision Comment by Behrouz NematiPour on 12 November 2025, 15:31 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25101 The view classes are QObject, and they already have an internal timer that you can start and use in the timer event. Therefore, this block of code needs to be moved to the timerEvent. I have created a story as an enhancement to the date and time for the following: # Since the SW Board is the only reference for the clock, we now need to send the date and time to both the TD and DD every second as a broadcast message ** That message should be on a general channel so both get it instead of two separate messages. ** If SW won't update the TD every second, and with a different epoch, TD will raise an alarm *** We only need to know, but SW does not need to do anything about it *** The Alarm infrastructure will automatically handle it *** If disconnected, TD will play the alarm sound and turn on the alarm light. # While we are sending the epoch as broadcast every second, and TD will raise an alarm if we don't, we need to get rid of the two requests, response messages, and send that epoch every second broadcast. # As has been mentioned above, we need to update the disabled date and time on NTP ** When switched to NO NTP, stop updating. # A timezone needs to be added to the Date and time screen, since we already have NTP, so that we can update by timezone. # Another comment: don't the datetime conversion, 'toString' function is slow, and that we can pass integer values instead, since we are going to use it every second? [LDT-2909: Service - SW - 01 - Enhancement - FW epoch Broadcast, TimeZone - R&I|https://diality.atlassian.net/browse/LDT-2909] [LDT-2923: Service - SW - 02 - Enhancement - FW epoch Broadcast, TimeZone - Q&R|https://diality.atlassian.net/browse/LDT-2923] Reply by Nicholas Ramirez on 13 November 2025, 08:41 > 👍 Will do all these in the enhancement story Revision Comment by Behrouz NematiPour on 12 November 2025, 16:54 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25111 Please make vDateTime optional; if not set, return the current datetime epoch. It is better to use the 'timeEvent' (right now, onSetDateUIFinished). Reply by Nicholas Ramirez on 13 November 2025, 11:20 > updated Revision Comment by Behrouz NematiPour on 12 November 2025, 16:59 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25113 Can you help me understand why we did not use the DeviceController attribute to call the datetime set script? Or modify this function to use that design? Reply by Nicholas Ramirez on 13 November 2025, 11:20 > this was existing code.. Updated to use the DeviceController > and made updates accordingly. And Tested and still works ---------------------------------------- File: sources/view/settings/VDateTime.h Revision Comment by Behrouz NematiPour on 12 November 2025, 14:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25087 Align '_', and '=' please. Reply by Nicholas Ramirez on 13 November 2025, 11:21 > updated Revision Comment by Behrouz NematiPour on 12 November 2025, 14:58 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25089 Do not use the 'const &' on basic types (int, bool, char, ....). The result is even worse and is not worth it. But please still keep the alignment. Reply by Nicholas Ramirez on 13 November 2025, 11:21 > this method removed but updated elsewhere Revision Comment by Behrouz NematiPour on 12 November 2025, 15:04 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25097 Same as https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#CFR-76783 Reply by Nicholas Ramirez on 13 November 2025, 11:21 > updated ---------------------------------------- File: sources/canbus/MessageInterpreter.cpp Revision Comment by Behrouz NematiPour on 12 November 2025, 10:39 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25071 is this a typo? Reply by Nicholas Ramirez on 12 November 2025, 12:15 > yes typo and fixed ---------------------------------------- File: SDDs/Service.puml Revision Comment by Behrouz NematiPour on 12 November 2025, 09:35 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25067 Where in the design do you store the new password? Reply by Nicholas Ramirez on 12 November 2025, 12:11 > updated to store in file sysetm Revision Comment by Behrouz NematiPour on 12 November 2025, 09:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25068 Shouldn't it check the password from FS (Service.conf)? If so, FS interaction is missing. Reply by Nicholas Ramirez on 12 November 2025, 12:11 > updated Revision Comment by Behrouz NematiPour on 12 November 2025, 09:56 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25069 I do not see the script's exit code in the date_time_set.sh script. https://devapps.diality.us/cru/LEAHI-SW-SCRIPTS-LDT-2727-1#CFR-76860 Reply by Nicholas Ramirez on 12 November 2025, 12:12 > 😅 will add in the scripts repositor Revision Comment by Behrouz NematiPour on 12 November 2025, 09:33 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1#c25066 This should be FS (file system), not the OS, unless you run a script and it is being executed by bash/sh. Reply by Nicholas Ramirez on 12 November 2025, 12:11 > updated --- ID: LEAHI-APPLICATION-LDT-2727-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2727-1 Title: LEAHI-APPLICATION-LDT-2727_Service - SW - 01 - Service - R&I Statement of Objectives: State: Closed Summary: Author: Nicholas Ramirez Moderator: Nicholas Ramirez Reviewers: (4 active, 2 completed*) Behrouz NematiPour (*) Stephen Quong (*) Tiffany Mejia Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho