This is a list of all comments for LEAHI-APPLICATION-LDT-2957-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/components/HeaderBar.qml
Revision Comment by Behrouz NematiPour on 10 December 2025, 15:25 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25690

  statusColor is so general, but is bound to the
  heparinStatusColor.
  Please either change the status color to be heparin only or
  change the heparinStatus Color name to be more general.
  The latter is better.

  Reply by Nicholas Ramirez on 10 December 2025, 16:31
  > updated to statusColor

Revision Comment by Behrouz NematiPour on 10 December 2025, 15:26 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25691

  Please put comments for your division number.

  Reply by Nicholas Ramirez on 10 December 2025, 16:30
  > added

----------------------------------------
File: sources/gui/qml/globals/Variables.qml
Revision Comment by Behrouz NematiPour on 10 December 2025, 15:37 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25693

  We should use "min" for minutes and not "mins".
  Same for "hrs" => "hr".

  Reply by Nicholas Ramirez on 10 December 2025, 16:29
  > updated

----------------------------------------
File: sources/gui/qml/pages/treatment/TreatmentStack.qml
Revision Comment by Behrouz NematiPour on 10 December 2025, 15:53 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25697

  You no longer need this after you move the heparin screen from
  the sections folder.

  Reply by Nicholas Ramirez on 10 December 2025, 16:26
  > removed

Revision Comment by Behrouz NematiPour on 10 December 2025, 15:54 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25698

  Please use the mainTreatment screen as the default.
  If necessary, could you create a specific enum to clean up the
  stack (which I do not believe is needed.)

  Reply by Nicholas Ramirez on 10 December 2025, 16:46
  > pop(null) will unwind the stack and go back to main
  > treatment. I tested and added a comment in code as well

    Reply by Behrouz NematiPour on 10 December 2025, 16:50
    > Thank you .

----------------------------------------
File: sources/gui/qml/pages/treatment/sections/TreatmentHeparin.qml
Revision Comment by Behrouz NematiPour on 10 December 2025, 15:48 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25694

  Move this outside of the sections folder, since it is no longer
  a section and has its own dedicated screen.

  Reply by Nicholas Ramirez on 10 December 2025, 16:27
  > moved

Revision Comment by Behrouz NematiPour on 10 December 2025, 15:49 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25695

  We should add the qsTr()

  Reply by Nicholas Ramirez on 10 December 2025, 16:28
  > updated

Revision Comment by Behrouz NematiPour on 10 December 2025, 15:51 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25696

  Shouldn't ""Unfractionated 1000"" come from the configurations?

  Reply by Nicholas Ramirez on 10 December 2025, 16:27
  > yes good catch. updated

----------------------------------------
File: sources/view/hd/data/treatment/VTreatmentHeparinData.cpp
Revision Comment by Behrouz NematiPour on 10 December 2025, 15:59 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25699

  Please align.

  Reply by Nicholas Ramirez on 10 December 2025, 16:26
  > done

----------------------------------------
File: sources/gui/qml/components/IdleTimer.qml
Revision Comment by Behrouz NematiPour on 10 December 2025, 15:27 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25692

  What is this file used for?
  And please add a brief description for the file comment.

  Reply by Nicholas Ramirez on 10 December 2025, 16:30
  > used for the 1 min user activity timeout to move back to main
  > treatment from heparin.. Its a requirement LEAHI-PRS-666

    Reply by Behrouz NematiPour on 10 December 2025, 16:53
    > I believe any related view could have provided a timer
    > since they are inherited from QObject.
    > That is fine for now but consider using our C++ view codes
    > for such a thing.

      Reply by Behrouz NematiPour on 12 December 2025, 01:39
      > We will address this later on code modularizations.
      > RESOLVED.

----------------------------------------
File: sources/gui/qml/pages/treatment/TreatmentHeparin.qml
Revision Comment by Behrouz NematiPour on 12 December 2025, 01:42 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1#c25769

  It is a little bit concerning:
  Could you please test/describe the following scenarios:
   - What if we have more than one Heparin type supported?
   - What if none (incorrectly) has been defined in the
  configuration (do we get an index out of bounds)?


---

ID: LEAHI-APPLICATION-LDT-2957-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-2957-1

Title: LEAHI-APPLICATION-LDT-2957_Heparin - SW  - 01 - R&I
Statement of Objectives:


State: Review

Author: Nicholas Ramirez
Moderator: Nicholas Ramirez
Reviewers: (6 active, 0 completed*)
     Tiffany Mejia
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Behrouz NematiPour
     Daniel Ho
     Stephen Quong