This is a list of all comments for LEAHI-APPLICATION-LDT-627-1. Review Summary: No summary ---------------------------------------- File: sources/gui/qml/dialogs/DiagnosticsDialog.qml Revision Comment by Behrouz NematiPour on 29 June 2025, 20:49 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22528 align Reply by Behrouz NematiPour on 01 July 2025, 13:09 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 20:58 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22531 Is this value added in the Switches column intentionally? We should avoid doing this if that is intentional. Reply by Tiffany Mejia on 30 June 2025, 16:11 > Yes it was added intentionally per Seans requests Reply by Behrouz NematiPour on 30 June 2025, 17:25 > RESOLVED. Revision Comment by Behrouz NematiPour on 29 June 2025, 20:53 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22529 Did you also add the TDOpMode in diagnostics? Reply by Tiffany Mejia on 30 June 2025, 16:12 > No it was not added, plan was to add in DD story instead. Reply by Behrouz NematiPour on 30 June 2025, 17:26 > Thanks for reminding me. > RESOLVED. Revision Comment by Behrouz NematiPour on 29 June 2025, 20:54 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22530 Please ask the FW team (Sean) if they would like this to be a column with labels, similar to the other messages. If that helps, we may still have room on the TD page, and we have separated the subsystem messages. Reply by Tiffany Mejia on 30 June 2025, 21:31 > Confirmed this will be made vertical layout and separated. It > should fit given 4 messages are still to be added (air pump, > air bubbles, pressures, opmode) Reply by Behrouz NematiPour on 01 July 2025, 13:11 > RESOLVED ---------------------------------------- File: sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml Revision Comment by Behrouz NematiPour on 29 June 2025, 20:44 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22527 Is the current rate the same as the target rate? I think the target should be a fixed value that has not been reached, but the current rate is rising toward the target. Reply by Tiffany Mejia on 01 July 2025, 01:07 > There is only a target rate in the payload for now. We would > need to calculate this ourselves right now. to discuss with > FW Reply by Tiffany Mejia on 01 July 2025, 15:34 > [~snash] Reply by Behrouz NematiPour on 01 July 2025, 16:34 > Regarding the conversation we had with Sean, the > targetRate is the same as the CurrentRate. > RESOLVED ---------------------------------------- File: sources/canbus/MessageGlobals.h Revision Comment by Behrouz NematiPour on 16 June 2025, 13:19 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22196 Please align the length's comma. Reply by Tiffany Mejia on 23 June 2025, 14:36 > Fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:10 > RESOLVED ---------------------------------------- File: sources/gui/GuiGlobals.h Revision Comment by Behrouz NematiPour on 29 June 2025, 18:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22508 Update the decimal(17) Reply by Tiffany Mejia on 01 July 2025, 00:59 > fixed Reply by Behrouz NematiPour on 01 July 2025, 13:11 > RESOLVED ---------------------------------------- File: leahi_dialin/ui/dd_messaging.py Revision Comment by Behrouz NematiPour on 29 June 2025, 22:17 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22544 Please refactor the names to match the application's message naming for clarity. Reply by Behrouz NematiPour on 01 July 2025, 13:29 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 22:01 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22542 align ) Reply by Behrouz NematiPour on 01 July 2025, 13:29 > RESOLVED ---------------------------------------- File: leahi_dialin/ui/td_messaging.py Revision Comment by Behrouz NematiPour on 29 June 2025, 21:05 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22532 I think you removed the BloodPump and replaced it with BloodFlow in the application. This should match the application message naming? Reply by Behrouz NematiPour on 30 June 2025, 12:09 > After a quick discussion, let's keep the message ID enum in > the common dialin as 'bloodPump', but everywhere else, please > change it to 'bloodflow'. Reply by Behrouz NematiPour on 01 July 2025, 16:50 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:08 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22534 why this one is H6 not H4, which does not match the application. Reply by Tiffany Mejia on 30 June 2025, 10:36 > I forgot to adjust the application. H6 is correct for the > rotor hall state Reply by Behrouz NematiPour on 30 June 2025, 17:38 > put a comment in the mode. > Please refactor the field for the model and update it > wherever it has been used. > http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-627-1#CFR-68162 Reply by Behrouz NematiPour on 01 July 2025, 13:25 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:11 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22535 Any reason why this is implemented while there is no application-related message defined? Reply by Tiffany Mejia on 01 July 2025, 01:13 > removing for now and moving to other story Reply by Behrouz NematiPour on 01 July 2025, 16:51 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:34 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22536 What message is this API implementing? Why is the MESG_ID the same as the bubble? Reply by Tiffany Mejia on 01 July 2025, 01:13 > removing for now and moving to another story Reply by Behrouz NematiPour on 01 July 2025, 16:51 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:36 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22537 This must be unsigned. Reply by Tiffany Mejia on 01 July 2025, 01:13 > thanks, fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:26 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:36 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22538 unsigned. Reply by Behrouz NematiPour on 03 July 2025, 12:28 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22539 * Refactor to td_voltage. * Update the function document. Reply by Tiffany Mejia on 03 July 2025, 10:33 > fixed! Reply by Behrouz NematiPour on 03 July 2025, 12:26 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 21:48 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22541 flow(s) are U32 Reply by Tiffany Mejia on 03 July 2025, 10:33 > fixed Reply by Behrouz NematiPour on 03 July 2025, 12:25 > RESOLVED ---------------------------------------- File: leahi_dialin/common/msg_ids.py Revision Comment by Behrouz NematiPour on 29 June 2025, 21:07 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22533 Refactor this to BloodFlow to match the application message naming. Reply by Tiffany Mejia on 30 June 2025, 10:35 > This will be autogenerated with FW naming which is BloodPump. > It would need to be the reverse. Reply by Behrouz NematiPour on 01 July 2025, 13:28 > RESOLVED as we discussed. ---------------------------------------- File: leahi_dialin/ui/common.py Revision Comment by Behrouz NematiPour on 29 June 2025, 22:20 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22545 These values do not match the PRS Reply by Tiffany Mejia on 01 July 2025, 15:23 > These have been adjusted per PRS. Unsure the values for the > DEF/MAX items. If available let us discuss this Reply by Behrouz NematiPour on 01 July 2025, 16:15 > Please take a look at the leahi-sw.config repo. > git@bitbucket.org:diality-cloud/leahi-sw.config.git > All are updated and defined there per PRS. Reply by Tiffany Mejia on 03 July 2025, 10:34 > discussed that config values in repo dont match PRS > (252/253/269). Leaving as is. Reply by Behrouz NematiPour on 07 July 2025, 10:39 > RESOLVED. ---------------------------------------- File: sources/model/dd/adjustment/settings/MAdjustDDVersionsResponse.cpp Revision Comment by Behrouz NematiPour on 29 June 2025, 18:52 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22511 align . Reply by Tiffany Mejia on 01 July 2025, 16:16 > fixed Reply by Behrouz NematiPour on 01 July 2025, 16:37 > RESOLVED ---------------------------------------- File: sources/model/dd/adjustment/settings/MAdjustDDVersionsResponse.h Revision Comment by Behrouz NematiPour on 29 June 2025, 18:55 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22512 align Reply by Tiffany Mejia on 01 July 2025, 01:01 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:13 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 18:55 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22514 align ; Reply by Tiffany Mejia on 01 July 2025, 01:01 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:13 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 18:55 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22513 align Reply by Tiffany Mejia on 01 July 2025, 01:00 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:13 > RESOLVED ---------------------------------------- File: sources/model/dd/data/MDDGenDialysateData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 18:51 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22510 mIsDialGood and in class doc. Reply by Tiffany Mejia on 01 July 2025, 01:01 > fixed Reply by Behrouz NematiPour on 01 July 2025, 13:14 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 18:51 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22509 align ;} Reply by Tiffany Mejia on 01 July 2025, 16:16 > fixed Reply by Behrouz NematiPour on 01 July 2025, 16:38 > RESOLVED ---------------------------------------- File: sources/model/td/adjustment/settings/MAdjustTDVersionsResponse.h Revision Comment by Behrouz NematiPour on 29 June 2025, 18:57 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22515 align Reply by Tiffany Mejia on 01 July 2025, 01:02 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:19 > RESOLVED ---------------------------------------- File: sources/model/td/data/MTDBatteryData.cpp Revision Comment by Behrouz NematiPour on 29 June 2025, 19:32 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22521 incorrect assignment Reply by Tiffany Mejia on 01 July 2025, 01:05 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:23 > RESOLVED ---------------------------------------- File: sources/model/td/data/MTDSwitchesData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 19:28 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22520 align Reply by Tiffany Mejia on 01 July 2025, 01:05 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:23 > RESOLVED ---------------------------------------- File: sources/model/td/data/MTDVoltageData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 19:22 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22519 align: 01 instead of 1 Reply by Tiffany Mejia on 01 July 2025, 19:42 > fixed! Reply by Behrouz NematiPour on 03 July 2025, 12:28 > RESOLVED ---------------------------------------- File: sources/model/td/data/treatment/MTreatmentBloodFlowData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 19:10 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22518 naming does not match the excel? Reply by Tiffany Mejia on 30 June 2025, 22:26 > I cannot control Sean changing his mind on naming (it used to > match). Adjusted naming to match TD FW Reply by Behrouz NematiPour on 01 July 2025, 13:21 > I understand. > No problem then. > > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:38 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22596 According to this comment this need to be H6. http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-627-1#CFR-67994 Reply by Tiffany Mejia on 01 July 2025, 01:03 > fixed Reply by Behrouz NematiPour on 01 July 2025, 13:21 > RESOLVED Revision Comment by Behrouz NematiPour on 29 June 2025, 19:07 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22517 align ;} Reply by Tiffany Mejia on 01 July 2025, 01:03 > fixed Reply by Behrouz NematiPour on 01 July 2025, 13:21 > RESOLVED ---------------------------------------- File: sources/model/td/data/treatment/MTreatmentPressureOcclusionData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 19:03 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22516 The list does not match the Leahi Messages List parameters. Any specific reason? Reply by Tiffany Mejia on 01 July 2025, 01:04 > I got these directly from the TD code. the leahi message list > is not up to date Reply by Behrouz NematiPour on 01 July 2025, 13:22 > RESOLVED ---------------------------------------- File: sources/view/dd/data/VDDGenDialysateData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 19:41 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22522 This must be removed. Reply by Tiffany Mejia on 01 July 2025, 01:06 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:24 > RESOLVED ---------------------------------------- File: sources/view/td/data/VTDBatteryData.cpp Revision Comment by Behrouz NematiPour on 29 June 2025, 20:35 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22525 Please refactor to acPower. Reply by Tiffany Mejia on 01 July 2025, 01:06 > fixed! Reply by Behrouz NematiPour on 01 July 2025, 13:25 > RESOLVED ---------------------------------------- File: sources/view/td/data/treatment/VTreatmentBloodFlow.h Revision Comment by Behrouz NematiPour on 29 June 2025, 20:30 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22524 Please refactor rpm instead of rPM. Reply by Behrouz NematiPour on 01 July 2025, 13:24 > RESOLVED ---------------------------------------- File: sources/view/td/data/treatment/VTreatmentUltrafiltrationData.h Revision Comment by Behrouz NematiPour on 29 June 2025, 20:23 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1#c22523 Is there a specific reason for 0.600 being the default value? If this is coming from Denali, we should review the value; otherwise, it needs to be discussed, reviewed, and a comment added to clarify. Reply by Tiffany Mejia on 30 June 2025, 22:52 > Yes this value is from denali. I assume this is going to be > adjusted per the institutional record later on so left for > now. Reply by Behrouz NematiPour on 01 July 2025, 16:40 > Set it to 0.800 > RESOLVED Reply by Tiffany Mejia on 03 July 2025, 10:32 > fixed! --- ID: LEAHI-APPLICATION-LDT-627-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-627-1 Title: LDT-627 - Main Treatment Screen SW - Messaging Broadcast - Application & Dialin Statement of Objectives: State: Closed Summary: Author: Tiffany Mejia Moderator: Tiffany Mejia Reviewers: (6 active, 2 completed*) Nicholas Ramirez (*) Behrouz NematiPour (*) Sean Nash jpaguio Vinayakam Mani Michael Garthwaite Dara Navaei Daniel Ho