This is a list of all comments for LEAHI-APPLICATION-LDT-713-1.

Review Summary: No summary


----------------------------------------
File: leahi.pro.user
Revision Comment by Nicholas Ramirez on 13 June 2025, 08:26 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-713-1#c22187

  should this file be excluded in the repository and be in the
  gitignore as its QtCreator user specific?

  Reply by Behrouz NematiPour on 13 June 2025, 12:26
  > Good point.
  > I was going to inform everyone on the SW team (I've already
  > told Tiffany).
  > 
  > We need to keep a correct version of this file in the
  > repository since it includes the build and run parameters of
  > the project (weirdly, although it is project-specific,
  > everyone should use the same configuration and not a
  > user-specific one).
  > 
  > In the past, when I had unit tests in the project, we had to
  > keep changes in this file.
  > Recently, in the Leahi project, I have removed them.
  > Additionally, for the Leahi project, some build
  > configurations have been updated.
  > 
  > In this branch, I have updated the file for the Leahi
  > project, and we should no longer keep track of changes to
  > this file.
  > 
  > Therefore, from now on, after this branch is merged into
  > staging, please ignore any changes QtCreator makes to this
  > file.

    Reply by Nicholas Ramirez on 13 June 2025, 13:44
    > RESOLVED

----------------------------------------
File: sources/model/hd/alarm/MAlarmCleared.h
Revision Comment by Tiffany Mejia on 13 June 2025, 10:24 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-713-1#c22189

  SRC should be TD. Also why is it DPNDS and not 0x001?

  Reply by Behrouz NematiPour on 13 June 2025, 12:01
  > Thanks for catching that.
  > Any subsystem can send the AlarmCleared, and that is why the
  > Src is DPNDS (depends).
  > I changed the source to Any, and this is an Alarm Broadcast
  > message.

    Reply by Tiffany Mejia on 16 June 2025, 13:47
    > RESOLVED

----------------------------------------
File: sources/storage/StorageGlobals.cpp
Revision Comment by Nicholas Ramirez on 13 June 2025, 08:24 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-713-1#c22186

  fix spelling of "Location"

  Reply by Behrouz NematiPour on 13 June 2025, 13:39
  > Fixed

    Reply by Nicholas Ramirez on 13 June 2025, 13:43
    > RESOLVED

----------------------------------------
File: leahi_dialin/ui/td_messaging_alarms.py
Revision Comment by Tiffany Mejia on 13 June 2025, 09:57 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-713-1#c22188

  As a U16, this should be 'Short_to_bytearray'

  Reply by Behrouz NematiPour on 13 June 2025, 12:07
  > Thanks, Great catch.
  > Fixed.

    Reply by Tiffany Mejia on 16 June 2025, 13:46
    > RESOLVED


---

ID: LEAHI-APPLICATION-LDT-713-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-713-1

Title: Feature/LDT-713 - General Alarm Requirements - SW - Application & Dialin
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (6 active, 2 completed*)
     Nicholas Ramirez   (*)
     Tiffany Mejia   (*)
     Sean Nash
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Daniel Ho