This is a list of all comments for LEAHI-APPLICATION-LDT-907-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/GuiGlobals.h
Revision Comment by Behrouz NematiPour on 21 July 2025, 18:11 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22991

  Why did these change?

  Reply by Tiffany Mejia on 22 July 2025, 09:08
  > Started the ID changes for DD. I prefer changing all my
  > needed ID's and slowly creating to their M&V.

    Reply by Behrouz NematiPour on 22 July 2025, 14:06
    > RESOLVED

----------------------------------------
File: sources/gui/qml/dialogs/diagnostics/DiagnosticsBase.qml
Revision Comment by Nicholas Ramirez on 07 July 2025, 10:41 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22749

  user facing strings should be translated. Use
  qsTr("Information")

  Reply by Behrouz NematiPour on 07 July 2025, 12:22
  > Same comment for debugging tools.
  > http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-907-1#c22752

    Reply by Nicholas Ramirez on 08 July 2025, 08:28
    > RESOLVED

Revision Comment by Nicholas Ramirez on 07 July 2025, 10:41 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22750

  add ObjectName. The object name for id: _root is not needed
  just the child componenets

  Reply by Tiffany Mejia on 22 July 2025, 13:55
  > done!

    Reply by Nicholas Ramirez on 22 July 2025, 14:12
    > RESOLVED

Revision Comment by Nicholas Ramirez on 07 July 2025, 10:43 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22751

  Do not think this property is needed since the Label component
  already has this property set

  Reply by Tiffany Mejia on 22 July 2025, 13:57
  > done!

    Reply by Nicholas Ramirez on 22 July 2025, 14:12
    > RESOLVED

----------------------------------------
File: sources/gui/qml/dialogs/diagnostics/DiagnosticsDD.qml
Revision Comment by Nicholas Ramirez on 07 July 2025, 10:44 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22752

  translate string with qsTr()

  Reply by Behrouz NematiPour on 07 July 2025, 12:20
  > Good point.
  > However, *for debugging tools such as the Diagnostics screen
  > and Logging, please Do Not translate*.
  > Those are for our developers, and not only do they not have a
  > translation requirement, but also, if we translate them to
  > Japanese, then who will understand them?

    Reply by Nicholas Ramirez on 08 July 2025, 08:28
    > RESOLVED

----------------------------------------
File: sources/gui/qml/dialogs/diagnostics/DiagnosticsDialog.qml
Revision Comment by Nicholas Ramirez on 07 July 2025, 11:04 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22754

  Instead of having this extra Rect. Can we customize the parent
  Rect in CloseButton and make the parent Rect larger than the
  Image component inside and color the border to achieve the same
  desired look?

  Reply by Tiffany Mejia on 17 July 2025, 17:47
  > I see this component also being used in treatment adjustments
  > (which do not have the extra rectangle) so best to discuss if
  > we may make all the same or leave

  Reply by Behrouz NematiPour on 21 July 2025, 18:15
  > Please let's keep this as is for now.
  > Thanks.

    Reply by Nicholas Ramirez on 22 July 2025, 08:11
    > RESOLVED

----------------------------------------
File: sources/gui/qml/dialogs/diagnostics/DiagnosticsSwipe.qml
Revision Comment by Nicholas Ramirez on 07 July 2025, 10:47 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22753

  add id/object name

  Reply by Nicholas Ramirez on 22 July 2025, 14:17
  > RESOLVED

----------------------------------------
File: sources/model/MModel.h
Revision Comment by Behrouz NematiPour on 21 July 2025, 18:08 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22990

  Please align the Data words.

  Reply by Behrouz NematiPour on 22 July 2025, 14:06
  > RESOLVED

----------------------------------------
File: leahi_dialin/ui/dd_messaging.py
Revision Comment by Behrouz NematiPour on 21 July 2025, 17:55 
https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1#c22989

  Please add the message ID as well, from now on.
  Thanks.

  Reply by Tiffany Mejia on 22 July 2025, 09:24
  > done!

    Reply by Behrouz NematiPour on 22 July 2025, 14:07
    > RESOLVED


---

ID: LEAHI-APPLICATION-LDT-907-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-907-1

Title: LDT-907 - Main Treatment Screen - SW - Diagnostics Screen - Application & Dialin
Statement of Objectives:


State: Closed

Summary: 

Author: Tiffany Mejia
Moderator: Tiffany Mejia
Reviewers: (6 active, 2 completed*)
     Nicholas Ramirez   (*)
     Behrouz NematiPour   (*)
     Sean Nash
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Daniel Ho