This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-1196-6.

Review Summary: No summary

General Comment by jpaguio on 07 October 2025, 14:15 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6#c24537

  LDT-2198 was merged into this branch after being merged into
  staging_alpha. Branch will be killed and relevant code changes
  were reviewed appropriately.


----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.c
Revision Comment by Sean Nash on 30 September 2025, 09:45 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6#c24491

  Appears to be dialysate to dialyzer flow rate.

  Reply by jpaguio on 30 September 2025, 11:44
  > Done

Revision Comment by Vinayakam Mani on 30 September 2025, 09:20 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6#c24487

  Please use 0.0F (since its float variable).

  Reply by jpaguio on 30 September 2025, 11:44
  > Done

    Reply by Vinayakam Mani on 30 September 2025, 13:33
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Sean Nash on 30 September 2025, 09:40 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6#c24490

  Looking at the implementation of this function, it appears that
  this function is setting dialysateFlowRate to target rate only
  when delivering dialysate to the dialyzer and to zero in all
  other cases.  Consider changing variable name to something like
  dialysateToDialyzerFlowRate and updating function description
  in header to make this more clear.

  Reply by jpaguio on 30 September 2025, 11:45
  > Done

Revision Comment by Vinayakam Mani on 30 September 2025, 09:21 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6#c24488

  Check the current Gen dialysate sub state.

  Reply by jpaguio on 30 September 2025, 11:45
  > Done

Revision Comment by Sean Nash on 30 September 2025, 09:39 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6#c24489

  0.0F.

  Reply by jpaguio on 30 September 2025, 11:45
  > Done


---

ID: LEAHI-DD-FIRMWARE-LDT-1196-6 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1196-6

Title: LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate
Statement of Objectives:


State: Closed

Summary: 

Author: jpaguio
Moderator: jpaguio
Reviewers: (8 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Sean Nash
     Vinayakam Mani
     Michael Garthwaite
     Raghu Kallala
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho