This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-1473-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.c
Revision Comment by Sean Nash on 02 February 2026, 09:49 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1473-1#c26911

  What should trimmer heater be doing in these spent/bicarb
  chamber states?

  Reply by Vinayakam Mani on 04 February 2026, 15:32
  > For spent chamber fill, we don't know how low the liquid
  > level is ( in Chamber H) and hence decided not to turn on the
  > trimmer heater for safety reasons. For bicarb fill, the dry
  > bicart code should cover the actuators status. the current
  > bicarb chamber fill code here should be updated with the
  > newly implemented dry bi cart code changes.

    Reply by Sean Nash on 06 February 2026, 14:17
    > So shouldn't we stop trimmer heater here then?

----------------------------------------
File: TestSupport.h
Revision Comment by Sean Nash on 02 February 2026, 09:41 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1473-1#c26908

  I would think this would be enabled by default.

  Reply by Vinayakam Mani on 04 February 2026, 15:37
  > Since trimmer heater is enabled, no need of temp
  > compensation. only for testing purposes, temp compensation is
  > needed. Hence by default, temp compensation is disabled.

----------------------------------------
File: firmware/App/Controllers/ConcentratePumps.c
Revision Comment by Sean Nash on 02 February 2026, 13:55 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1473-1#c26920

  I think you can do this in 1 line of code using the RANGE macro
  in Common.h.

  Reply by Vinayakam Mani on 04 February 2026, 15:38
  > Done.

----------------------------------------
File: firmware/App/Controllers/BalancingChamber.c
Revision Comment by Sean Nash on 02 February 2026, 14:02 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1473-1#c26921

  Mis-spelled "Stabilized".

  Reply by Vinayakam Mani on 04 February 2026, 15:38
  > Done


---

ID: LEAHI-DD-FIRMWARE-LDT-1473-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1473-1

Title: LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
Statement of Objectives:


State: Review

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (15 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Varshini Nagabooshanam
     Raghu Kallala
     Daniel Ho
     Vendor - TEL - Sameer Poyil
     Zoltan Miskolci
     Vendor - TEL - Jashwant Gantyada
     Sean Nash
     Nicholas Ramirez
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Behrouz NematiPour
     Stephen Quong