This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-1773-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Valves.c
Revision Comment by Sean Nash on 16 October 2025, 09:35 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1773-2#c24664

  I think these should be initialized to zero in case there are
  unused bits that won't be set below.

Revision Comment by Sean Nash on 16 October 2025, 09:30 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1773-2#c24662

  Remove extra blank line.

Revision Comment by Sean Nash on 16 October 2025, 09:42 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1773-2#c24670

  I only see these configurations being set here in initialize
  function.  Is that all we need?  Is this configuration what we
  want for these valves in all states?
  
  I would recommend we combine these 3 fpga functions into one
  single function that takes all 3 params and updates all 3
  registers.

----------------------------------------
File: firmware/App/Services/FpgaDD.h
Revision Comment by Sean Nash on 16 October 2025, 09:26 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1773-2#c24657

  Remove extra blank line.

----------------------------------------
File: firmware/source/sys_main.c
Revision Comment by Sean Nash on 08 December 2025, 13:02 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1773-2#c25618

  Move up with other controllers.


---

ID: LEAHI-DD-FIRMWARE-LDT-1773-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1773-2

Title: LEAHI-DD-FIRMWARE-LDT-1773_IOFP- Power Budget and if we need to employ the strike and hold
Statement of Objectives:


State: Review

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (7 active, 0 completed*)
     Sean Nash
     jpaguio
     Vinayakam Mani
     Raghu Kallala
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho