This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-1925-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 20 January 2026, 14:08 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26466

  timeSinceP12Started?

  Reply by Raghu Kallala on 20 January 2026, 14:14
  > Updated

Revision Comment by Sean Nash on 20 January 2026, 09:46 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26445

  For init functions, I think it's ok (and cleaner) to just say
  we initialize ALL unit variables.

  Reply by Raghu Kallala on 20 January 2026, 13:43
  > Updated

Revision Comment by Sean Nash on 20 January 2026, 09:58 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26452

  Why are we setting timer for pressure and PWM controls?  Isn't
  it only applicable in flow control?
  And why aren't we resetting exempt flag in same place as timer?

  Reply by Raghu Kallala on 20 January 2026, 13:42
  > Fixed

Revision Comment by Sean Nash on 20 January 2026, 14:12 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26467

  TRUE if low flow alarm is exempt, FALSE if not.

  Reply by Raghu Kallala on 20 January 2026, 14:14
  > Fixed

Revision Comment by Sean Nash on 20 January 2026, 09:56 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26450

  I think timer should be internal (private) to this unit.

  Reply by Raghu Kallala on 20 January 2026, 13:42
  > Changed the implementation

Revision Comment by Sean Nash on 20 January 2026, 09:57 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26451

  I think this function should return TRUE if exempt (we are in
  first 10 seconds of flow control from off state).  All criteria
  checked here in this function.

  Reply by Raghu Kallala on 20 January 2026, 13:42
  > Updated

----------------------------------------
File: firmware/App/Controllers/ROPump.h
Revision Comment by Sean Nash on 20 January 2026, 14:06 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26464

  Should we rename this function to "isROPumpLowflowAlarmExempt"?
  The current name makes me think it will set the alarm to be
  exempt.

  Reply by Raghu Kallala on 20 January 2026, 14:14
  > Updated

----------------------------------------
File: firmware/App/Monitors/WaterQualityMonitor.c
Revision Comment by Sean Nash on 20 January 2026, 09:52 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26447

  I think timeout should be handled inside ROPump unit.  From
  here, we should just call one function that tells us whether
  alarm should be exempt or not.

  Reply by Raghu Kallala on 20 January 2026, 13:43
  > Fixed

Revision Comment by Sean Nash on 20 January 2026, 09:54 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26449

  We need to be calling the isPersistentAlarm function regardless
  of exemption, but only triggering the alarm if persistent alarm
  function returns TRUE and exemption is FALSE.

  Reply by Raghu Kallala on 20 January 2026, 13:43
  > Updated to use isPersistentAlarmTriggered

----------------------------------------
File: firmware/App/Modes/FPModes/StateFlushPermeate.c
Revision Comment by Sean Nash on 20 January 2026, 14:07 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1#c26465

  Should we have a comment for this one too?

  Reply by Raghu Kallala on 20 January 2026, 14:14
  > Added


---

ID: LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1

Title: LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup
Statement of Objectives:


State: Closed

Summary: 

Author: Raghu Kallala
Moderator: Raghu Kallala
Reviewers: (8 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Vendor - TEL - Jashwant Gantyada
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Varshini Nagabooshanam
     Vinayakam Mani
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho
     Vendor - TEL - Sameer Poyil