This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2004-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Drivers/ConductivitySensors.c Revision Comment by Sean Nash on 04 November 2025, 10:07 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24988 Do we need to include Teensy driver here? Revision Comment by Sean Nash on 04 November 2025, 10:07 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24989 Should this be in the Teensy driver? Why is it here? ---------------------------------------- File: firmware/App/Drivers/ConductivityTeensy.c Revision Comment by Sean Nash on 04 November 2025, 09:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24982 Add a Private Definitions banner between includes and private definitions. Revision Comment by Sean Nash on 04 November 2025, 10:02 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24985 We typically initialize variables in the init function and not in declaration. Revision Comment by Sean Nash on 21 November 2025, 09:58 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25236 Add comment to right. Revision Comment by Sean Nash on 04 November 2025, 10:03 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24986 Remove extra blank line. Revision Comment by Sean Nash on 21 November 2025, 09:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25237 Remove extra blank line. Revision Comment by Sean Nash on 21 November 2025, 10:00 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25239 Seems like eePromDataTX is an output, not an input. Revision Comment by Sean Nash on 21 November 2025, 10:02 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25242 If no parameters, just don't have any param lines (don't say none). Revision Comment by Sean Nash on 21 November 2025, 10:00 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25238 Remove extra blank line. Revision Comment by Sean Nash on 21 November 2025, 10:01 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25240 measurementSettingsTX is an output. Revision Comment by Sean Nash on 21 November 2025, 10:01 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25241 No param, so remove this line. Revision Comment by Vinayakam Mani on 12 November 2025, 16:49 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25109 Remove extra line. Revision Comment by Sean Nash on 01 December 2025, 21:23 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25361 For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (commands in this case). Revision Comment by Sean Nash on 01 December 2025, 21:25 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25362 All cases seem a little off on indents, especially this one. Revision Comment by Sean Nash on 01 December 2025, 21:26 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25363 Why two output lines? Revision Comment by Vinayakam Mani on 12 November 2025, 17:16 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25114 error count or reading temperature? Revision Comment by Sean Nash on 05 November 2025, 14:54 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24995 Why string and I don't see string being sent anywhere. Revision Comment by Sean Nash on 05 November 2025, 14:53 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24994 Why string and I don't see this string being sent anywhere. Revision Comment by Sean Nash on 05 November 2025, 14:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24993 Why string? Revision Comment by Sean Nash on 05 November 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24991 Why are we sending Teensy board a string command? I thought we changed Teensy interface to be binary. Revision Comment by Sean Nash on 05 November 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24992 Why string? Revision Comment by Sean Nash on 21 November 2025, 10:05 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25243 Use a #define instead of 1000. Revision Comment by Sean Nash on 21 November 2025, 10:05 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25244 Fix indent. Revision Comment by Sean Nash on 21 November 2025, 10:06 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25245 No overrides? ---------------------------------------- File: firmware/App/Monitors/Conductivity.c Revision Comment by Sean Nash on 04 November 2025, 09:50 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24978 Where are we including the conductivity driver? Expecting a build switch (#ifdef) that selects which driver we are including. Revision Comment by Sean Nash on 04 November 2025, 10:05 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24987 Is the "readConductivitySensors()" call above for the FPGA based driver we will have later? Should we only do one or the other based on build switch? ---------------------------------------- File: firmware/App/Drivers/ConductivityTeensy.h Revision Comment by Sean Nash on 21 November 2025, 09:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25226 Use /// here so doxygen will pick it up. Revision Comment by Sean Nash on 21 November 2025, 09:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25227 /// Revision Comment by Vinayakam Mani on 12 November 2025, 15:53 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25105 UNINITIALIZED? Revision Comment by Sean Nash on 21 November 2025, 09:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25228 /// Revision Comment by Vinayakam Mani on 12 November 2025, 15:51 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25104 space b/w '}' and 'Conductivity'. seen other places too in the file, please check and update. Revision Comment by Sean Nash on 21 November 2025, 09:56 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25229 Add space between } and type name. Revision Comment by Sean Nash on 21 November 2025, 09:56 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25230 /// Revision Comment by Vinayakam Mani on 12 November 2025, 15:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25106 Align the comments in fixed indentation throughout the file. Revision Comment by Vinayakam Mani on 12 November 2025, 16:36 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25108 Add the comments for coefficients. bring a top-level comment explaining the formula where these coefficients are being used. Revision Comment by Sean Nash on 21 November 2025, 09:56 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25231 Add space between } and type name. Revision Comment by Sean Nash on 21 November 2025, 09:56 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25232 /// Revision Comment by Sean Nash on 04 November 2025, 09:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24981 No need to pop here if there are more structures below to pack. Put all packed structures between a single set of pragma pack push/pop. Revision Comment by Sean Nash on 21 November 2025, 09:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25233 Add space between } and type name. Revision Comment by Sean Nash on 21 November 2025, 09:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25234 /// ---------------------------------------- File: firmware/App/Services/Interrupts.c Revision Comment by Sean Nash on 13 November 2025, 12:50 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25149 Put in #ifdef. Revision Comment by Sean Nash on 04 November 2025, 09:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24979 Put these 2 cases in a #ifdef USE_TEENSY_CONDUCTIVITY build switch so only included in build if we're using the Teensy board. Revision Comment by Sean Nash on 04 November 2025, 09:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c24980 Do we need to add any functions to Comm.c? ---------------------------------------- File: firmware/App/Modes/ModeGenDialysate.c Revision Comment by Sean Nash on 21 November 2025, 10:07 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1#c25246 Should we be calling get function in monitor instead of driver here? --- ID: LEAHI-DD-FIRMWARE-LDT-2004-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-1 Title: LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD Statement of Objectives: State: Review Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (9 active, 0 completed*) Vendor - TEL - Jashwant Gantyada Vendor - TEL - Arpita Srivastava Vendor - TEL - Varshini Nagabooshanam Sean Nash Vinayakam Mani Raghu Kallala Dara Navaei Daniel Ho Vendor - TEL - Sameer Poyil