This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2004-3. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/DryBiCart.c Revision Comment by Sean Nash on 21 November 2025, 08:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25217 Align comments. Reply by Vinayakam Mani on 08 December 2025, 14:40 > Done. Revision Comment by Sean Nash on 21 November 2025, 08:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25218 Align comments. Reply by Vinayakam Mani on 08 December 2025, 14:40 > Done Revision Comment by Sean Nash on 21 November 2025, 09:00 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25219 Add spaces around void. Reply by Vinayakam Mani on 08 December 2025, 14:40 > Done Revision Comment by Sean Nash on 21 November 2025, 09:04 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25220 We can abbreviate things in function and variable names, but in descriptive text we should write things out in complete words as this text goes into SDD document. Reply by Vinayakam Mani on 08 December 2025, 14:41 > Done. Revision Comment by Sean Nash on 21 November 2025, 09:06 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25221 Can't we just do all of this in the start state? Reply by Vinayakam Mani on 08 December 2025, 14:41 > I would prefer to keep it here, as the start state > (DRY_BICART_START_STATE) is always executed when the fill > bicart flag (dryBiCartFillRequested) is not set. There are > other execs, say fill chamber (execBicarbChamberFillMode) > mode controls D80 in its sub states. So, not two execs > controlling same valve. Once we identified where all modes > using these execs, will come up with signals to avoid such > scenarios. ---------------------------------------- File: firmware/App/Controllers/DryBiCart.h Revision Comment by Sean Nash on 21 November 2025, 08:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25214 bicart? Can we spell this out since this will be main description of this unit in SDD? Assuming bicart = dry bicarbonate cartridge? Also, this unit appears to control bicarb chamber - not just cartridge - so we should mention that here. Reply by Vinayakam Mani on 08 December 2025, 14:48 > Done. Revision Comment by Sean Nash on 21 November 2025, 08:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25215 Remove extra blank line. Reply by Vinayakam Mani on 08 December 2025, 14:48 > Done. Revision Comment by Sean Nash on 21 November 2025, 08:58 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25216 Remove extra space before void. Align comments. Reply by Vinayakam Mani on 08 December 2025, 14:48 > Done. ---------------------------------------- File: firmware/App/Controllers/BalancingChamber.c Revision Comment by Vendor - TEL - Sameer Poyil on 08 December 2025, 18:50 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25643 comment should start with capital letter Revision Comment by Vendor - TEL - Sameer Poyil on 08 December 2025, 18:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25644 Mixing static and public function , let public function comes on top ---------------------------------------- File: firmware/App/Services/Messaging.c Revision Comment by Sean Nash on 11 December 2025, 13:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25749 Remove extra spaces between { and msg name. ---------------------------------------- File: firmware/App/Tasks/TaskGeneral.c Revision Comment by Sean Nash on 11 December 2025, 13:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25748 Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec). ---------------------------------------- File: DDDefs.h Revision Comment by Sean Nash on 11 December 2025, 13:56 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25747 Do these belong in the spent chamber fill group? Revision Comment by Sean Nash on 21 November 2025, 08:54 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25213 Remove extra blank line. Reply by Vinayakam Mani on 08 December 2025, 14:50 > Done. ---------------------------------------- File: firmware/App/Modes/ModeGenDialysate.c Revision Comment by Sean Nash on 21 November 2025, 09:10 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25222 Should D64 also be in the #ifndef below? The DryBiCart state machine controls this valve too. Revision Comment by Vendor - TEL - Sameer Poyil on 08 December 2025, 19:02 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25647 Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ? Revision Comment by Sean Nash on 21 November 2025, 09:13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25224 Why not D64 in this case? Revision Comment by Sean Nash on 21 November 2025, 09:14 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25225 Why does this case manage so many more valves than other cases? Reply by Vinayakam Mani on 08 December 2025, 14:51 > These set of valves defined as per system architecture (to > make sure all valves initialized as expected). Reply by Sean Nash on 09 December 2025, 10:27 > Shouldn't EVERY state set ALL valves? ---------------------------------------- File: firmware/App/Controllers/DialysatePumps.h Revision Comment by Vendor - TEL - Sameer Poyil on 08 December 2025, 18:53 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25645 Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code? ---------------------------------------- File: firmware/App/Modes/FPModes/FPOperationModes.c Revision Comment by Sean Nash on 04 December 2025, 11:27 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25521 Remove extra blank line. Revision Comment by Sean Nash on 04 December 2025, 11:37 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25522 Why FP? I don't see FP prefixed s/w faults in the enum. ---------------------------------------- File: firmware/App/Controllers/Valves.c Revision Comment by Vendor - TEL - Sameer Poyil on 08 December 2025, 19:00 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25646 Let public function on top ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by Sean Nash on 11 December 2025, 14:00 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3#c25750 Is this temporary? If so, put a TODO to remove later. --- ID: LEAHI-DD-FIRMWARE-LDT-2004-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3 Title: LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD Statement of Objectives: State: Review Author: Vinayakam Mani Moderator: Vinayakam Mani Reviewers: (10 active, 0 completed*) Vendor - TEL - Arpita Srivastava Vendor - TEL - Jashwant Gantyada Vendor - TEL - Varshini Nagabooshanam Sean Nash Michael Garthwaite Raghu Kallala Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho Vendor - TEL - Sameer Poyil