This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2004-4.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/FpgaDD.c
Revision Comment by Sean Nash on 03 February 2026, 16:56 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27005

  I believe conductivity and temperature data will be F32s.

Revision Comment by Sean Nash on 03 February 2026, 17:27 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27020

  I think cal data and count should be retrieved by same function
  and possibly needs some interrupt protection to ensure data and
  count stick together.  If these functions are called from
  general task, we could have situation where data is retrieved,
  then priority task updates fpga, and then counter is retrieved
  with wrong (incremented) counter.
  If these two functions are being called from a driver that is
  executed in priority task, then we don't need to worry about
  this situation, but still ought to add a constraint/warning
  comment in function headers noting that these functions should
  only be called from priority task.

----------------------------------------
File: firmware/App/Drivers/ConductivitySensors.h
Revision Comment by Sean Nash on 03 February 2026, 17:02 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27010

  Add a blank line after public defs banner.
  Add a dox comment to the right.
  I believe they reserve space for 12 bytes, not 10.
  Not really for calibration - it's for s/n and versions.

Revision Comment by Sean Nash on 03 February 2026, 17:05 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27011

  enums need a top level dox comment.

Revision Comment by Sean Nash on 03 February 2026, 17:05 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27012

  Structures need a top level dox comment.

Revision Comment by Sean Nash on 03 February 2026, 17:06 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27013

  Are these really going to be different types?  I assumed they
  would all be floats.

Revision Comment by Sean Nash on 03 February 2026, 17:09 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27014

  Do we need to say Value?

Revision Comment by Sean Nash on 03 February 2026, 17:13 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27015

  General Dialin question - does it make sense to override
  temperatures at driver level where they are spread out over
  several drivers?  I would think overriding at monitor level
  would be simpler where they are all in one place and could be
  indexed by enum with single command.

Revision Comment by Sean Nash on 03 February 2026, 17:15 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27016

  Do FP sensors have to be treated separately?  I realize there
  needs to be separate messages as they will be coming from
  different Dialin classes, but can't we handle both messages
  with same function (assuming shared enum to index)?

Revision Comment by Sean Nash on 03 February 2026, 17:16 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27017

  I think Dialin will need get (or UI proxy) commands to have us
  send cal, s/n, and versions.

----------------------------------------
File: firmware/App/DDCommon.h
Revision Comment by Sean Nash on 03 February 2026, 16:51 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4#c27004

  Do we not need this anymore?  I still see it in code all over
  the place and I don't think we're done w/ Teensy until Beta 1.9
  units are obsolete.


---

ID: LEAHI-DD-FIRMWARE-LDT-2004-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-4

Title: LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Statement of Objectives:


State: Review

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (15 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Varshini Nagabooshanam
     Raghu Kallala
     Daniel Ho
     Vendor - TEL - Sameer Poyil
     Zoltan Miskolci
     Vendor - TEL - Jashwant Gantyada
     Sean Nash
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Behrouz NematiPour
     Stephen Quong