This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2030-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Drivers/BloodLeakDriver.c Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:56 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25276 copy right missing Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:03 > fixed. thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25277 order of include file is not proper Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:03 > fixed. thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25278 Please arrange it in alphabetical order Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:04 > fixed. thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 05 December 2025, 08:48 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25573 Do not mix static and public function, let all public function on top and static bottom, except override and test functions Reply by Vendor - TEL - Jashwant Gantyada on 11 December 2025, 10:15 > Changed. Thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 10 December 2025, 19:49 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25712 Please bring public functions on top. check it for all function in this file , except test functions Reply by Vendor - TEL - Jashwant Gantyada on 11 December 2025, 10:16 > Done. Thank you. Revision Comment by Sean Nash on 25 November 2025, 13:41 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25291 Remove extra blank line. Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:03 > fixed. thanks ---------------------------------------- File: firmware/App/Drivers/BloodLeakDriver.h Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25275 copy right missing Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:04 > fixed. thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 13:01 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25279 structure packing statement missing Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:04 > fixed. thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 05 December 2025, 08:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25574 structure packing missing Reply by Sean Nash on 09 December 2025, 10:38 > [~dnavaei], this is not a CAN message payload, but it does > look like a sensor serial message payload. I'm assuming this > code works, so sensor does not expect a packed structure? Reply by Dara Navaei on 09 December 2025, 11:21 > [~ven.spoyil] this structure is not used to message > handling. Reply by Vendor - TEL - Sameer Poyil on 10 December 2025, 19:53 > If it is not used for serial message, its OK, but if you > are opting for packing , club it together , in line > number 36 , or bring that structure defined on top to > here ---------------------------------------- File: firmware/App/Monitors/BloodLeak.c Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25272 copy right missing Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:04 > fixed. thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25274 need structure packing Reply by Sean Nash on 25 November 2025, 13:37 > Packing only needed if it's used for transmission. I don't > see this structure being broadcast anywhere. Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:54 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25273 alignment of comments not proper, check all other places Revision Comment by Sean Nash on 25 November 2025, 13:33 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25287 Do we need to call initBloodLeakDriver() here? Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:05 > called it from here. Fixed it. Thank you Revision Comment by Sean Nash on 25 November 2025, 13:33 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25288 Remove blank line. Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:05 > Removed. Thank you. Revision Comment by Vendor - TEL - Sameer Poyil on 10 December 2025, 20:03 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25714 is it merge issue ? Reply by Vendor - TEL - Jashwant Gantyada on 11 December 2025, 10:17 > I think you are seeing previous commit. It is not there in > the present code. Revision Comment by Sean Nash on 25 November 2025, 13:38 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25290 Keep 2 blank lines above/below test banner. Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:06 > Fixed. Thank you. ---------------------------------------- File: firmware/App/Monitors/BloodLeak.h Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 12:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25271 copy right missing Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:06 > Fixed. Thank you. Revision Comment by Sean Nash on 25 November 2025, 13:28 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25285 If both monitor and driver need visibility to something, consider moving it to the driver's header file since monitor needs to include driver anyway. Driver should not have to know about the monitor stuff as it is higher level. Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:07 > Moved the enums to driver header file. Fixed it. Revision Comment by Sean Nash on 25 November 2025, 13:29 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2#c25286 Remove extra blank line. Reply by Vendor - TEL - Jashwant Gantyada on 26 November 2025, 10:07 > Removed. Thank you. --- ID: LEAHI-DD-FIRMWARE-LDT-2030-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2030-2 Title: LEAHI-DD-FIRMWARE-LDT-2030_Blood Leak - DD Statement of Objectives: State: Review Author: Vendor - TEL - Jashwant Gantyada Moderator: Vendor - TEL - Jashwant Gantyada Reviewers: (10 active, 0 completed*) Vendor - TEL - Arpita Srivastava Vendor - TEL - Varshini Nagabooshanam Sean Nash Vinayakam Mani Raghu Kallala Michael Garthwaite Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho Vendor - TEL - Sameer Poyil